From: "Arnd Bergmann" <arnd@arndb.de>
To: "Sohil Mehta" <sohil.mehta@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
Linux-Arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH] syscalls: Fix file path names in the header comments
Date: Fri, 16 Jun 2023 22:11:49 +0200 [thread overview]
Message-ID: <c2f3656f-b831-4009-8ee6-a2430c4ac8c7@app.fastmail.com> (raw)
In-Reply-To: <20230616183120.1706378-1-sohil.mehta@intel.com>
On Fri, Jun 16, 2023, at 20:31, Sohil Mehta wrote:
> Some of the syscall definitions have moved due to the original source
> file being moved into a sub-directory. Update the file path names to
> reflect that.
>
> A couple of syscalls such as lookup_dcookie() and nfsservctl() don't
> have a syscall definition anymore. Clear the filename and leave the
> original subsystem name intact for reference.
>
> Signed-off-by: Sohil Mehta <sohil.mehta@intel.com>
Thanks for going through these!
> Arguably, having filenames in comments might not be the best idea. If the
> intention is to make it easier to find a syscall definition, it is probably
> faster to just use 'git grep SYSCALL_DEFINE | grep <syscall_name>'. Please let
> me know if it would be preferable to just get rid of these comments all
> together.
It's probably not worth trying to keep the comments in sync, I'd be in
favor of just removing them all.
Arnd
next prev parent reply other threads:[~2023-06-16 20:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 18:31 [PATCH] syscalls: Fix file path names in the header comments Sohil Mehta
2023-06-16 20:11 ` Arnd Bergmann [this message]
2023-06-16 20:54 ` Sohil Mehta
2023-06-21 22:36 ` [PATCH] syscalls: Remove file path comments from headers Sohil Mehta
2023-06-22 15:10 ` Arnd Bergmann
2023-06-22 20:17 ` Sohil Mehta
2023-06-23 8:06 ` Arnd Bergmann
2023-06-23 12:25 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2f3656f-b831-4009-8ee6-a2430c4ac8c7@app.fastmail.com \
--to=arnd@arndb.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sohil.mehta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).