Linux userland API discussions
 help / color / mirror / Atom feed
From: David Ahern <dsahern@kernel.org>
To: Yuen Su <zypulsecore@gmail.com>, netdev@vger.kernel.org
Cc: Ido Schimmel <idosch@nvidia.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-api@vger.kernel.org
Subject: Re: [PATCH net 1/2] ipv4: accept nexthop dump attributes in route deletes
Date: Thu, 19 Nov 2026 08:47:08 -0700	[thread overview]
Message-ID: <c5fb4561-f12c-431d-b68d-659ea9cd8a90@kernel.org> (raw)
In-Reply-To: <20261118084510.332821-2-zypulsecore@gmail.com>

On 11/18/26 2:45 AM, Yuen Su wrote:
> diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
> index 8c123b1..6b012c8 100644
> --- a/net/ipv4/fib_frontend.c
> +++ b/net/ipv4/fib_frontend.c
> @@ -868,7 +868,10 @@ static int rtm_to_fib_config(struct net *net, struct sk_buff *skb,
>  		goto errout;
>  	}
>  
> -	if (cfg->fc_nh_id) {
> +	/* Dumps can include both a nexthop ID and compatibility attributes.
> +	 * On deletion, fib_nh_match() uses the ID to match the nexthop.
> +	 */
> +	if (cfg->fc_nh_id && nlh->nlmsg_type != RTM_DELROUTE) {
>  		if (cfg->fc_oif || cfg->fc_gw_family ||
>  		    cfg->fc_encap || cfg->fc_mp) {
>  			NL_SET_ERR_MSG(extack,

as the error message at this point shows, the 2 specifications must be
mutually exclusive. iproute2 will need to strip the nh_id or the nexthop
spec.

  parent reply	other threads:[~2026-11-19 15:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  8:45 [PATCH net 0/2] ipv4: allow route dump replay with nexthop IDs Yuen Su
2026-11-18  8:45 ` [PATCH net 1/2] ipv4: accept nexthop dump attributes in route deletes Yuen Su
2026-11-18 12:21   ` Ido Schimmel
2026-11-19 15:47   ` David Ahern [this message]
2026-11-18  8:45 ` [PATCH net 2/2] selftests: net: test flushing IPv4 nexthop routes in compat mode Yuen Su

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5fb4561-f12c-431d-b68d-659ea9cd8a90@kernel.org \
    --to=dsahern@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=zypulsecore@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox