From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D428C433FE for ; Wed, 24 Nov 2021 14:41:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354021AbhKXOo2 (ORCPT ); Wed, 24 Nov 2021 09:44:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:25952 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352445AbhKXOoU (ORCPT ); Wed, 24 Nov 2021 09:44:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637764870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=05PN9xn7GnEUgcf2Sc2TC/qS5xmqWs58yCFcmH/P7j0=; b=UTPEwn4h8KxYq86KuF3/TsqWeiXYK6diKDZiBOQsoX2OZpOk4TdjD5mZABRAG5sYMJaxJW kynDvQIz3kU27mKETbzs0SepWGiH3/eJIFiUbYqljJ63M929Y8EmZWrixsaQimsvplLFMr RAzC6xkOgL1vm1ongndWCyeEXculqzo= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-550-vIhyFB60MxeTmHSyMlaVyw-1; Wed, 24 Nov 2021 09:41:08 -0500 X-MC-Unique: vIhyFB60MxeTmHSyMlaVyw-1 Received: by mail-wr1-f72.google.com with SMTP id p3-20020a056000018300b00186b195d4ddso542722wrx.15 for ; Wed, 24 Nov 2021 06:41:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=05PN9xn7GnEUgcf2Sc2TC/qS5xmqWs58yCFcmH/P7j0=; b=5qQSBtQC+TnZaXdU4nVqDDjOp5h47UFBSYlNsUKsKkgG23YndrwhuM7H33sXBK0BNH XddKQiFSnmqc+HIZduGpDNNZK4Q11+d3OPMmXaueeuInzHoCHKLnr++TR/6SNk5WiRh6 +75SLCsurZgsZ3Lon4S5frpyg0J6/lUVdjyG6LiUfdPn7rJxS2srt8GwgDecngs8ihxq 2TDXIe1GsUIJx4wuqUQzCwS9aHZVCIy034ASsfbPTHEb1l5b78WOP9/TFbpzPcHCTTKL +1cgPxhDICJ2oOCnoHiD4+cRVO+RJxipV9Rn2cAFLfuWkQOmn+4WabsaCcXh3tuWr484 hkYQ== X-Gm-Message-State: AOAM532du1zHY9jFhFbasQ2ME5QzM4EWU2Cs8am7/Yo0vNcaP79ZGmnu vC6DSupOpLZmlaW1OOm742cGXRSyE7jvvdL8NY5xvv8ap5fMaO1nmPIiFhU/gDs8UtZZS9RXt19 /IXWLXOOhEF0iaGAfr8QC X-Received: by 2002:a7b:c008:: with SMTP id c8mr15311365wmb.87.1637764867356; Wed, 24 Nov 2021 06:41:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJxF7ZFf+xn1AKx+sORexMmiOn/XrWXeSdy5eaDUZxe1RqZJyUBzwaHLdz+J+JQnLnMzS44+XA== X-Received: by 2002:a7b:c008:: with SMTP id c8mr15311334wmb.87.1637764867166; Wed, 24 Nov 2021 06:41:07 -0800 (PST) Received: from [192.168.3.132] (p5b0c6380.dip0.t-ipconnect.de. [91.12.99.128]) by smtp.gmail.com with ESMTPSA id l8sm5226970wmc.40.2021.11.24.06.41.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Nov 2021 06:41:06 -0800 (PST) Message-ID: Date: Wed, 24 Nov 2021 15:41:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] Increase default MLOCK_LIMIT to 8 MiB Content-Language: en-US To: Vlastimil Babka , Jason Gunthorpe Cc: Jens Axboe , Andrew Dona-Couch , Andrew Morton , Drew DeVault , Ammar Faizi , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, io_uring Mailing List , Pavel Begunkov , linux-mm@kvack.org References: <8f219a64-a39f-45f0-a7ad-708a33888a3b@www.fastmail.com> <333cb52b-5b02-648e-af7a-090e23261801@redhat.com> <5f998bb7-7b5d-9253-2337-b1d9ea59c796@redhat.com> <20211123132523.GA5112@ziepe.ca> <10ccf01b-f13a-d626-beba-cbee70770cf1@redhat.com> <20211123140709.GB5112@ziepe.ca> <20211123170056.GC5112@ziepe.ca> <20211123235953.GF5112@ziepe.ca> <2adca04f-92e1-5f99-6094-5fac66a22a77@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On 24.11.21 15:37, Vlastimil Babka wrote: > On 11/24/21 09:57, David Hildenbrand wrote: >> On 24.11.21 00:59, Jason Gunthorpe wrote: >>>> Similarly for io-uring we could be migrating pages to be pinned so that >>>> the end up consolidated close together, and prevent pathologic >>>> situations like in David's reproducer. >>> >>> It is an interesting idea to have GUP do some kind of THP preserving >>> migration. >> >> >> Unfortunately it will only be a band aid AFAIU. I can rewrite my >> reproducer fairly easily to pin the whole 2M range first, pin a second >> time only a single page, and then unpin the 2M range, resulting in the >> very same way to block THP. (I can block some THP less because I always >> need the possibility to memlock 2M first, though). > > Hm I see, then we could also condsider making it possible to migrate the > pinned pages - of course io-uring would have to be cooperative here, > similarly to anything that supports PageMovable. I might be wrong but that would then essentially be an actual mlock+mmu notifier mechanism, and no longer FOLL_LONGTERM. And the mlock could actually be done by user space and would be optional. I'd be very happy to see something like that instead ... but so far people don't even agree that it's an issue worth fixing. So ... -- Thanks, David / dhildenb