From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Li, Aubrey" Subject: Re: [PATCH v13 1/3] /proc/pid/status: Add support for architecture specific output Date: Mon, 8 Apr 2019 08:45:28 +0800 Message-ID: References: <20190224044400.34975-1-aubrey.li@linux.intel.com> <20190406214143.GA21551@avx2> <7cd8fa2d-301a-5c96-ce3d-3dc373a5d8f5@linux.intel.com> <20190407154622.GA16004@avx2> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190407154622.GA16004@avx2> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Alexey Dobriyan Cc: Thomas Gleixner , mingo@redhat.com, Peter Zijlstra , "H. Peter Anvin" , ak@linux.intel.com, tim.c.chen@linux.intel.com, dave.hansen@intel.com, arjan@linux.intel.com, aubrey.li@intel.com, LKML , Linux API , Andrew Morton List-Id: linux-api@vger.kernel.org On 2019/4/7 23:46, Alexey Dobriyan wrote: > On Sun, Apr 07, 2019 at 09:02:38PM +0800, Li, Aubrey wrote: >> On 2019/4/7 5:41, Alexey Dobriyan wrote: >>> On Fri, Apr 05, 2019 at 09:32:35PM +0200, Thomas Gleixner wrote: >>>>> +/* Add support for architecture specific output in /proc/pid/status */ >>>>> +extern void arch_proc_pid_status(struct seq_file *m, struct task_struct *task); >>> ^^^^^^ >>> >>> Unnecessary extern. >>> >> The linkage is default extern, but with this functions and variables >> can be treated the same way. >> >> Is it mandatory not to use it explicitly? ./script/checkpatch.pl did >> not report this. > > "extern" is only necessary for variables. For prototypes, it is more typing > and more characters on the screen. > > checkpatch.pl doesn't report it because opening floodgates is not the plan. > > Yours, > Extern Police. > No problem, Mr. Police, I can remove it in the next version. Thanks, -Aubrey