From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Weinberger Subject: Re: [PATCH v2] fscrypt: Remove __packed from fscrypt_policy Date: Fri, 7 Apr 2017 11:22:58 +0200 Message-ID: References: <20170406231428.154187-1-joerichey94@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170406231428.154187-1-joerichey94-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Joe Richey , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: linux-fscrypt-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Richard Weinberger , Jaegeuk Kim , Theodore Ts'o , Michael Halcrow , Joe Richey List-Id: linux-api@vger.kernel.org Am 07.04.2017 um 01:14 schrieb Joe Richey: > From: Joe Richey > > This commit removes __packed from fscrypt_policy as it does not contain > any implicit padding and does not refer to an on-disk structure. Even > though this is a change to a UAPI file, no users will be broken as the > structure doesn't change. > > Signed-off-by: Joe Richey > --- > include/uapi/linux/fs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h > index 048a85e9f017..f6e1c54ac5e2 100644 > --- a/include/uapi/linux/fs.h > +++ b/include/uapi/linux/fs.h > @@ -279,7 +279,7 @@ struct fscrypt_policy { > __u8 filenames_encryption_mode; > __u8 flags; > __u8 master_key_descriptor[FS_KEY_DESCRIPTOR_SIZE]; > -} __packed; > +}; Both patches are fine, just keep my Reviewed-by. :) Thanks, //richard