From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael Kerrisk (man-pages)" Subject: Re: [PATCH 2/3] clone.2: Check for MAP_FAILED not NULL on mmap() Date: Sun, 17 Nov 2019 19:01:18 +0100 Message-ID: References: <20191116114114.7066-1-christian@brauner.io> <20191116114114.7066-2-christian@brauner.io> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20191116114114.7066-2-christian@brauner.io> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Christian Brauner Cc: mtk.manpages@gmail.com, adrian@lisas.de, akpm@linux-foundation.org, arnd@arndb.de, avagin@gmail.com, christian.brauner@ubuntu.com, dhowells@redhat.com, fweimer@redhat.com, jannh@google.com, keescook@chromium.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, linux-man@vger.kernel.org, mingo@elte.hu, oleg@redhat.com, xemul@virtuozzo.com List-Id: linux-api@vger.kernel.org On 11/16/19 12:41 PM, Christian Brauner wrote: > From: Christian Brauner > > If mmap() fails it will return MAP_FAILED which according to the manpage > is (void *)-1 not NULL. Sigh! Bad editing on my part. Thanks, Christian. Patch applied. Cheers, Michael > Signed-off-by: Christian Brauner > --- > man2/clone.2 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/man2/clone.2 b/man2/clone.2 > index 57a9eaba7..faff2ada6 100644 > --- a/man2/clone.2 > +++ b/man2/clone.2 > @@ -1628,7 +1628,7 @@ main(int argc, char *argv[]) > > stack = mmap(NULL, STACK_SIZE, PROT_READ | PROT_WRITE, > MAP_PRIVATE | MAP_ANONYMOUS | MAP_STACK, \-1, 0); > - if (stack == NULL) > + if (stack == MAP_FAILED) > errExit("mmap"); > > stackTop = stack + STACK_SIZE; /* Assume stack grows downward */ > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/