From: Jens Axboe <axboe@kernel.dk>
To: Jann Horn <jannh@google.com>
Cc: "Christoph Hellwig" <hch@infradead.org>,
"Milan P. Stanić" <mps@arvanta.net>,
io-uring <io-uring@vger.kernel.org>,
"Linux API" <linux-api@vger.kernel.org>
Subject: Re: Build 0.6 version fail on musl libc
Date: Wed, 29 Apr 2020 13:38:23 -0600 [thread overview]
Message-ID: <eca672cb-2df3-2274-c97f-c401328a40ce@kernel.dk> (raw)
In-Reply-To: <CAG48ez2k_CvXxVHW9WB+GV_+41PoKmVk0m_b_1sZaOAbnJUC1A@mail.gmail.com>
On 4/29/20 1:36 PM, Jann Horn wrote:
> +linux-api
>
> On Wed, Apr 29, 2020 at 6:14 PM Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 4/29/20 9:29 AM, Jens Axboe wrote:
>>> On 4/29/20 9:26 AM, Christoph Hellwig wrote:
>>>> On Wed, Apr 29, 2020 at 09:24:40AM -0600, Jens Axboe wrote:
>>>>>
>>>>> Not sure what the best fix is there, for 32-bit, your change will truncate
>>>>> the offset to 32-bit as off_t is only 4 bytes there. At least that's the
>>>>> case for me, maybe musl is different if it just has a nasty define for
>>>>> them.
>>>>>
>>>>> Maybe best to just make them uint64_t or something like that.
>>>>
>>>> The proper LFS type would be off64_t.
>>>
>>> Is it available anywhere? Because I don't have it.
>>
>> There seems to be better luck with __off64_t, but I don't even know
>> how widespread that is... Going to give it a go, we'll see.
>
> If you have questions about how to properly write UAPI headers,
> linux-api@ is probably a good place to ask.
This is in liburing, it's not the kernel side. The kernel side is fine.
--
Jens Axboe
prev parent reply other threads:[~2020-04-29 19:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200428192956.GA32615@arya.arvanta.net>
[not found] ` <04edfda7-0443-62e1-81af-30aa820cf256@kernel.dk>
[not found] ` <20200429152646.GA17156@infradead.org>
[not found] ` <e640dbcc-b25d-d305-ac97-a4724bd958e2@kernel.dk>
[not found] ` <6528f839-274d-9d46-dea6-b20a90ac8cf8@kernel.dk>
2020-04-29 19:36 ` Build 0.6 version fail on musl libc Jann Horn
2020-04-29 19:38 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eca672cb-2df3-2274-c97f-c401328a40ce@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=io-uring@vger.kernel.org \
--cc=jannh@google.com \
--cc=linux-api@vger.kernel.org \
--cc=mps@arvanta.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).