From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2906AECAA25 for ; Thu, 25 Aug 2022 18:48:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243455AbiHYSsv (ORCPT ); Thu, 25 Aug 2022 14:48:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243309AbiHYSso (ORCPT ); Thu, 25 Aug 2022 14:48:44 -0400 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27AB9B08B9; Thu, 25 Aug 2022 11:48:38 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id A0E735C00A7; Thu, 25 Aug 2022 14:48:35 -0400 (EDT) Received: from imap46 ([10.202.2.96]) by compute5.internal (MEProxy); Thu, 25 Aug 2022 14:48:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=verbum.org; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1661453315; x=1661539715; bh=7/QJ5cEPcM fYYVo1y1XafN6H2GK15RMZ9wDJuYjC+3c=; b=tAJRAlKJC6gwE4HsW/KFz043yK 24kBNzKUiqmnVincz1sRtGKAb19o0zAv/9Fy3yHUJ7me08gpSkhGFvCWlPjT4ER+ +fNGjc/wZ6IOXNAIT2wqi5fp++4hIugMf/rc7b0/ujORdyOq64rh2quHqGtoZDdk dLsQf6wCXqgn8RU8Hcy812rvA86MmxNSJzKD+fXCKdMwbwgJxgW6h1iB9+o1jgA+ IFur+F8TqAEKzz9HV8vU978jhpMJ/9UHc1JGXLoIg+JnodG27tUhcPdFWNzDDdpX UJ+mfLKn/kDhfRmWTKQ7v9y49Y7kQ2GfW83zU0SnddNwXV24uGXZmhQx2ZJA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1661453315; x=1661539715; bh=7/QJ5cEPcMfYYVo1y1XafN6H2GK1 5RMZ9wDJuYjC+3c=; b=aa7WC/tnYeq9OEjXMIgD5gjslo07PCVNiJjuBBQdaR38 n51GhANSSmBdeGZTtg5eDLrA4BdvWSEkvqCwaDMIfgyWc5depXXCHqTnmv8m3d8r fT0XK7FvIHXFXhcdMpTLHH/RNW06CX+x4fWxxT7+BSpuO3yDHayMs9RvS2M26UHW iNbjsaRW4egk+/gLmvM2xNiZSdbMruognidUigvjkcHjc8yNGrhD4zrxT6oImZps Np1MrDj8k9jtJQZo2sjU/Z4SucHTM7VJ4DksLpIRKM/y7/dCCcR0zG3W4nSOKS2V L18DNzyfWvFLhNSJ6GoReFAYZ8icZaxkfOMf6DkXrw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdejfedguddvlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdev ohhlihhnucghrghlthgvrhhsfdcuoeifrghlthgvrhhssehvvghrsghumhdrohhrgheqne cuggftrfgrthhtvghrnhephfejuddthedtgfeuueeltdekfeekvdfgveeifeduteekheff jefgieehheekgeetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepfigrlhhtvghrshesvhgvrhgsuhhmrdhorhhg X-ME-Proxy: Feedback-ID: ibe7c40e9:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 3C1E52A20075; Thu, 25 Aug 2022 14:48:35 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-841-g7899e99a45-fm-20220811.002-g7899e99a Mime-Version: 1.0 Message-Id: In-Reply-To: <20220823215333.GC3144495@dread.disaster.area> References: <20220819115641.14744-1-jlayton@kernel.org> <20220823215333.GC3144495@dread.disaster.area> Date: Thu, 25 Aug 2022 14:48:02 -0400 From: "Colin Walters" To: "Dave Chinner" , "Jeff Layton" Cc: "Al Viro" , linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, "Jeff Layton" , "David Howells" , "Frank Filz" Subject: Re: [PATCH] vfs: report an inode version in statx for IS_I_VERSION inodes Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Tue, Aug 23, 2022, at 5:53 PM, Dave Chinner wrote: > > THere's no definition of what consitutes an "inode change" and this > exposes internal filesystem implementation details (i.e. on disk > format behaviour) directly to userspace. That means when the > internal filesystem behaviour changes, userspace applications will > see changes in stat->ino_version changes and potentially break them. As a userspace developer (ostree, etc. who is definitely interested in this functionality) I do agree with this concern; but a random drive by comment: would it be helpful to expose iversion (or other bits like this from the vfs) via e.g. debugfs to start? I think that'd unblock writing fstests in the short term right?