public inbox for linux-api@vger.kernel.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Alejandro Colomar <alx@kernel.org>
Cc: Dorjoy Chowdhury <dorjoychy111@gmail.com>,
	 linux-man@vger.kernel.org, brauner@kernel.org,
	 jlayton@kernel.org,  libc-alpha@sourceware.org,
	linux-api@vger.kernel.org
Subject: Re: [PATCH v2 1/2] man/man3/errno.3: Document EFTYPE error code
Date: Mon, 27 Apr 2026 15:29:30 +0200	[thread overview]
Message-ID: <lhuv7dcy1j9.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <ae9gDtEo6OxHTYBt@devuan> (Alejandro Colomar's message of "Mon, 27 Apr 2026 15:13:07 +0200")

* Alejandro Colomar:

> Hi Florian,
>
> On 2026-04-27T12:34:30+0200, Florian Weimer wrote:
>> * Alejandro Colomar:
>> 
>> > [CC += libc-alpha]
>> >
>> > Hi Dorjoy,
>> >
>> > On 2026-04-26T17:14:25+0600, Dorjoy Chowdhury wrote:
>> >> Signed-off-by: Dorjoy Chowdhury <dorjoychy111@gmail.com>
>> >
>> > Thanks!
>> >
>> > 	Reviewed-by: Alejandro Colomar <alx@kernel.org>
>> >
>> > I will wait until glibc adds this error code to their <errno.h> before
>> > applying the patch.  This means either you should write and send a patch
>> > to glibc (if so, please CC me), or you should ask them to add it
>> > themselves (if you're not comfortable writing glibc code).
>> 
>> I'm not sure where this is coming from.
>
> Here's a link to the thread:
> <https://lore.kernel.org/linux-man/20260426111707.36541-1-dorjoychy111@gmail.com/T/>
>
>> POSIX says EFTYPE was rejected
>> in favor of ENOTTY.
>
> Could you please share a link to that?
>
> Anyway, I guess ENOTTY would be inappropriate in this case.  Although
> maybe a better error code could be devised; I don't know.  This is why
> I wanted glibc involved in this discussion before this arrives to a
> Linux release.  Thanks for the quick feedback!

It's in the Rationale for System Interfaces:

“
[EFTYPE]
    This error code was proposed in earlier proposals as "Inappropriate
    operation for file type", meaning that the operation requested is
    not appropriate for the file specified in the function call. This
    code was proposed, although the same idea was covered by [ENOTTY],
    because the connotations of the name would be misleading. It was
    pointed out that the fcntl() function uses the error code [EINVAL]
    for this notion, and hence all instances of [EFTYPE] were changed to
    this code.
”

I replied on linux-fsdevel, too.

(It would be nice to submit patches introducing new error codes to
linux-api with a subject mentioning the error code.)

Thanks,
Florian


  reply	other threads:[~2026-04-27 13:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260426111707.36541-1-dorjoychy111@gmail.com>
     [not found] ` <20260426111707.36541-2-dorjoychy111@gmail.com>
     [not found]   ` <ae4K_5f1g3zgSNkC@devuan>
     [not found]     ` <lhu5x5c4rpl.fsf@oldenburg.str.redhat.com>
2026-04-27 13:13       ` [PATCH v2 1/2] man/man3/errno.3: Document EFTYPE error code Alejandro Colomar
2026-04-27 13:29         ` Florian Weimer [this message]
2026-04-27 13:33           ` Alejandro Colomar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=lhuv7dcy1j9.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=alx@kernel.org \
    --cc=brauner@kernel.org \
    --cc=dorjoychy111@gmail.com \
    --cc=jlayton@kernel.org \
    --cc=libc-alpha@sourceware.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox