From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Schwab Subject: Re: F_SETOWN_EX and F_GETLK64 conflict Date: Thu, 29 Oct 2009 18:03:48 +0100 Message-ID: References: <1254691822.21044.9.camel@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <1254691822.21044.9.camel@laptop> (Peter Zijlstra's message of "Sun, 04 Oct 2009 23:30:22 +0200") Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Zijlstra Cc: "Joseph S. Myers" , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lkml , Oleg Nesterov , Stephane Eranian , Michael Kerrisk , Roland McGrath , Al Viro , Christoph Hellwig , Andrew Morton , Ingo Molnar List-Id: linux-api@vger.kernel.org Peter Zijlstra writes: > On Sun, 2009-10-04 at 12:35 +0000, Joseph S. Myers wrote: >> In asm-generic/fcntl.h, F_SETOWN_EX and F_GETLK64 both have value 12, and >> F_GETOWN_EX and F_SETLK64 both have value 13. I don't see how this is >> going to work correctly. See >> . > > > Ugh,.. yeah, non obvious collision that. > > How about something like: That really needs to be fixed before 2.6.32. Andreas. -- Andreas Schwab, schwab-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 5EC7 45C6 250E 6F00 984E "And now for something completely different."