* Re: [PATCH v4 00/30] NT synchronization primitive driver
From: Greg Kroah-Hartman @ 2024-04-16 8:49 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Elizabeth Figura, Arnd Bergmann, Jonathan Corbet, Shuah Khan,
linux-kernel, linux-api, wine-devel, André Almeida,
Wolfram Sang, Arkadiusz Hiler, Andy Lutomirski, linux-doc,
linux-kselftest, Randy Dunlap, Ingo Molnar, Will Deacon,
Waiman Long, Boqun Feng
In-Reply-To: <20240416081421.GB31647@noisy.programming.kicks-ass.net>
On Tue, Apr 16, 2024 at 10:14:21AM +0200, Peter Zijlstra wrote:
> On Mon, Apr 15, 2024 at 08:08:10PM -0500, Elizabeth Figura wrote:
> > This patch series implements a new char misc driver, /dev/ntsync, which is used
> > to implement Windows NT synchronization primitives.
>
> This patch series does not apply to anything I have at hand. Nor does it
> state anything explicit to put it on top of.
Should work on linux-next as I took a few of the original commits from
the last series already.
thanks,
greg k-h
^ permalink raw reply
* Re: [PATCH v4 00/30] NT synchronization primitive driver
From: Peter Zijlstra @ 2024-04-16 15:50 UTC (permalink / raw)
To: Elizabeth Figura
Cc: Arnd Bergmann, Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan,
linux-kernel, linux-api, wine-devel, André Almeida,
Wolfram Sang, Arkadiusz Hiler, Andy Lutomirski, linux-doc,
linux-kselftest, Randy Dunlap, Ingo Molnar, Will Deacon,
Waiman Long, Boqun Feng
In-Reply-To: <20240416081421.GB31647@noisy.programming.kicks-ass.net>
On Tue, Apr 16, 2024 at 10:14:21AM +0200, Peter Zijlstra wrote:
> > Some aspects of the implementation may deserve particular comment:
> >
> > * In the interest of performance, each object is governed only by a single
> > spinlock. However, NTSYNC_IOC_WAIT_ALL requires that the state of multiple
> > objects be changed as a single atomic operation. In order to achieve this, we
> > first take a device-wide lock ("wait_all_lock") any time we are going to lock
> > more than one object at a time.
> >
> > The maximum number of objects that can be used in a vectored wait, and
> > therefore the maximum that can be locked simultaneously, is 64. This number is
> > NT's own limit.
AFAICT:
spin_lock(&dev->wait_all_lock);
list_for_each_entry(entry, &obj->all_waiters, node)
for (i=0; i<count; i++)
spin_lock_nest_lock(q->entries[i].obj->lock, &dev->wait_all_lock);
Where @count <= NTSYNC_MAX_WAIT_COUNT.
So while this nests at most 65 spinlocks, there is no actual bound on
the amount of nested lock sections in total. That is, all_waiters list
can be grown without limits.
Can we pretty please make wait_all_lock a mutex ?
> > The acquisition of multiple spinlocks will degrade performance. This is a
> > conscious choice, however. Wait-for-all is known to be a very rare operation
> > in practice, especially with counts that approach the maximum, and it is the
> > intent of the ntsync driver to optimize wait-for-any at the expense of
> > wait-for-all as much as possible.
Typical sane usage is a good guide for performance, but you must not
forget about malicious userspace and what they can do on purpose to mess
you up.
Anyway, let me stare more at all this....
^ permalink raw reply
* Re: [PATCH v4 00/30] NT synchronization primitive driver
From: Peter Zijlstra @ 2024-04-16 15:53 UTC (permalink / raw)
To: Elizabeth Figura
Cc: Arnd Bergmann, Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan,
linux-kernel, linux-api, wine-devel, André Almeida,
Wolfram Sang, Arkadiusz Hiler, Andy Lutomirski, linux-doc,
linux-kselftest, Randy Dunlap, Ingo Molnar, Will Deacon,
Waiman Long, Boqun Feng
In-Reply-To: <20240416155014.GB12673@noisy.programming.kicks-ass.net>
On Tue, Apr 16, 2024 at 05:50:14PM +0200, Peter Zijlstra wrote:
> On Tue, Apr 16, 2024 at 10:14:21AM +0200, Peter Zijlstra wrote:
>
> > > Some aspects of the implementation may deserve particular comment:
> > >
> > > * In the interest of performance, each object is governed only by a single
> > > spinlock. However, NTSYNC_IOC_WAIT_ALL requires that the state of multiple
> > > objects be changed as a single atomic operation. In order to achieve this, we
> > > first take a device-wide lock ("wait_all_lock") any time we are going to lock
> > > more than one object at a time.
> > >
> > > The maximum number of objects that can be used in a vectored wait, and
> > > therefore the maximum that can be locked simultaneously, is 64. This number is
> > > NT's own limit.
>
> AFAICT:
>
> spin_lock(&dev->wait_all_lock);
> list_for_each_entry(entry, &obj->all_waiters, node)
> for (i=0; i<count; i++)
> spin_lock_nest_lock(q->entries[i].obj->lock, &dev->wait_all_lock);
>
> Where @count <= NTSYNC_MAX_WAIT_COUNT.
>
> So while this nests at most 65 spinlocks, there is no actual bound on
> the amount of nested lock sections in total. That is, all_waiters list
> can be grown without limits.
>
> Can we pretty please make wait_all_lock a mutex ?
Hurmph, it's worse, you do that list walk while holding some obj->lock
spinlokc too. Still need to figure out how all that works....
^ permalink raw reply
* Re: [PATCH v4 00/30] NT synchronization primitive driver
From: Peter Zijlstra @ 2024-04-16 16:05 UTC (permalink / raw)
To: Elizabeth Figura
Cc: Arnd Bergmann, Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan,
linux-kernel, linux-api, wine-devel, André Almeida,
Wolfram Sang, Arkadiusz Hiler, Andy Lutomirski, linux-doc,
linux-kselftest, Randy Dunlap, Ingo Molnar, Will Deacon,
Waiman Long, Boqun Feng
In-Reply-To: <20240416010837.333694-1-zfigura@codeweavers.com>
On Mon, Apr 15, 2024 at 08:08:10PM -0500, Elizabeth Figura wrote:
> The intended semantics of the patches are broadly intended to match those of the
> corresponding Windows functions. For those not already familiar with the Windows
> functions (or their undocumented behaviour), patch 27/27 provides a detailed
> specification, and individual patches also include a brief description of the
> API they are implementing.
You happen to have a readable copy of patch 27 around? RST is utter
garbage to read :/
^ permalink raw reply
* Re: [PATCH v4 00/30] NT synchronization primitive driver
From: Peter Zijlstra @ 2024-04-16 16:19 UTC (permalink / raw)
To: Elizabeth Figura
Cc: Arnd Bergmann, Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan,
linux-kernel, linux-api, wine-devel, André Almeida,
Wolfram Sang, Arkadiusz Hiler, Andy Lutomirski, linux-doc,
linux-kselftest, Randy Dunlap, Ingo Molnar, Will Deacon,
Waiman Long, Boqun Feng
In-Reply-To: <20240416155345.GC12673@noisy.programming.kicks-ass.net>
On Tue, Apr 16, 2024 at 05:53:45PM +0200, Peter Zijlstra wrote:
> On Tue, Apr 16, 2024 at 05:50:14PM +0200, Peter Zijlstra wrote:
> > On Tue, Apr 16, 2024 at 10:14:21AM +0200, Peter Zijlstra wrote:
> >
> > > > Some aspects of the implementation may deserve particular comment:
> > > >
> > > > * In the interest of performance, each object is governed only by a single
> > > > spinlock. However, NTSYNC_IOC_WAIT_ALL requires that the state of multiple
> > > > objects be changed as a single atomic operation. In order to achieve this, we
> > > > first take a device-wide lock ("wait_all_lock") any time we are going to lock
> > > > more than one object at a time.
> > > >
> > > > The maximum number of objects that can be used in a vectored wait, and
> > > > therefore the maximum that can be locked simultaneously, is 64. This number is
> > > > NT's own limit.
> >
> > AFAICT:
> >
> > spin_lock(&dev->wait_all_lock);
> > list_for_each_entry(entry, &obj->all_waiters, node)
> > for (i=0; i<count; i++)
> > spin_lock_nest_lock(q->entries[i].obj->lock, &dev->wait_all_lock);
> >
> > Where @count <= NTSYNC_MAX_WAIT_COUNT.
> >
> > So while this nests at most 65 spinlocks, there is no actual bound on
> > the amount of nested lock sections in total. That is, all_waiters list
> > can be grown without limits.
> >
> > Can we pretty please make wait_all_lock a mutex ?
>
> Hurmph, it's worse, you do that list walk while holding some obj->lock
> spinlokc too. Still need to figure out how all that works....
So the point of having that other lock around is so that things like:
try_wake_all_obj(dev, sem)
try_wake_any_sem(sem)
are done under the same lock?
Where I seem to note that both those functions do that same list
iteration.
Can't you write things like:
static void try_wake_all_obj(struct nysync_device *dev,
struct ntsync_obj *obj,
void (*wake_obj)(struct ntsync_obj *obj))
{
list_for_each_entry(entry, &obj->all_waiters, node) {
spin_lock(&obj->lock);
try_wake_all(dev, event->q, obj);
wake_obj(obj);
spin_unlock(&obj->lock);
}
}
And then instead of the above, write:
try_wake_all_obj(dev, sem, wake_sem);
[[ Also, should not something like try_wake_any_sem -- wake_sem in the
above -- have something like:
WARN_ON_ONCE(sem->type != NTSYNC_TYPE_SEM);
]]
^ permalink raw reply
* Re: [PATCH v4 00/30] NT synchronization primitive driver
From: Elizabeth Figura @ 2024-04-16 21:18 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Arnd Bergmann, Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan,
linux-kernel, linux-api, wine-devel, André Almeida,
Wolfram Sang, Arkadiusz Hiler, Andy Lutomirski, linux-doc,
linux-kselftest, Randy Dunlap, Ingo Molnar, Will Deacon,
Waiman Long, Boqun Feng
In-Reply-To: <20240416161917.GD12673@noisy.programming.kicks-ass.net>
On Tuesday, 16 April 2024 11:19:17 CDT Peter Zijlstra wrote:
> On Tue, Apr 16, 2024 at 05:53:45PM +0200, Peter Zijlstra wrote:
> > On Tue, Apr 16, 2024 at 05:50:14PM +0200, Peter Zijlstra wrote:
> > > On Tue, Apr 16, 2024 at 10:14:21AM +0200, Peter Zijlstra wrote:
> > > > > Some aspects of the implementation may deserve particular comment:
> > > > >
> > > > > * In the interest of performance, each object is governed only by a
> > > > > single
> > > > >
> > > > > spinlock. However, NTSYNC_IOC_WAIT_ALL requires that the state of
> > > > > multiple
> > > > > objects be changed as a single atomic operation. In order to
> > > > > achieve this, we first take a device-wide lock ("wait_all_lock")
> > > > > any time we are going to lock more than one object at a time.
> > > > >
> > > > > The maximum number of objects that can be used in a vectored wait,
> > > > > and
> > > > > therefore the maximum that can be locked simultaneously, is 64.
> > > > > This number is NT's own limit.
> > >
> > > AFAICT:
> > > spin_lock(&dev->wait_all_lock);
> > >
> > > list_for_each_entry(entry, &obj->all_waiters, node)
> > >
> > > for (i=0; i<count; i++)
> > >
> > > spin_lock_nest_lock(q->entries[i].obj->lock,
> > > &dev->wait_all_lock);
> > >
> > > Where @count <= NTSYNC_MAX_WAIT_COUNT.
> > >
> > > So while this nests at most 65 spinlocks, there is no actual bound on
> > > the amount of nested lock sections in total. That is, all_waiters list
> > > can be grown without limits.
> > >
> > > Can we pretty please make wait_all_lock a mutex ?
That should be fine, at least.
> > Hurmph, it's worse, you do that list walk while holding some obj->lock
> > spinlokc too. Still need to figure out how all that works....
>
> So the point of having that other lock around is so that things like:
>
> try_wake_all_obj(dev, sem)
> try_wake_any_sem(sem)
>
> are done under the same lock?
The point of having the other lock around is that try_wake_all() needs to lock
multiple objects at the same time. It's a way of avoiding lock inversion.
Consider task A does a wait-for-all on objects X, Y, Z. Then task B signals Y,
so we do try_wake_all_obj() on Y, which does try_wake_all() on A's queue
entry; that needs to check X and Z and consume the state of all three objects
atomically. Another task could be trying to signal Z at the same time and
could hit a task waiting on Z, Y, X, and that causes inversion.
The simple and easy way to implement everything is just to have a global lock
on the whole device, but this is kind of known to be a performance bottleneck
(this was NT's BKL, and they ditched it starting with Vista or 7 or
something).
Instead we use a lock per object, and normally in the wait-for-any case we
only ever need to grab one lock at a time, but when we need to do a wait-for-
all we need to lock multiple objects at once, and we grab the outer lock to
avoid potential lock inversion.
> Where I seem to note that both those functions do that same list
> iteration.
Over different lists. I don't know if there's a better way to name things to
make that clearer.
There's the "any" wait queue, which tasks which do a wait-for-any add
themselves to, and the "all" wait queue, which tasks that do a wait-for-all
add themselves to. Signaling an object could potentially wake up either one,
but checking whether a task is eligible is a different process.
^ permalink raw reply
* Re: [PATCH v4 00/30] NT synchronization primitive driver
From: Elizabeth Figura @ 2024-04-16 21:18 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Arnd Bergmann, Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan,
linux-kernel, linux-api, wine-devel, André Almeida,
Wolfram Sang, Arkadiusz Hiler, Andy Lutomirski, linux-doc,
linux-kselftest, Randy Dunlap, Ingo Molnar, Will Deacon,
Waiman Long, Boqun Feng
In-Reply-To: <20240416160553.GA30707@noisy.programming.kicks-ass.net>
On Tuesday, 16 April 2024 11:05:53 CDT Peter Zijlstra wrote:
> On Mon, Apr 15, 2024 at 08:08:10PM -0500, Elizabeth Figura wrote:
> > The intended semantics of the patches are broadly intended to match those
> > of the corresponding Windows functions. For those not already familiar
> > with the Windows functions (or their undocumented behaviour), patch 27/27
> > provides a detailed specification, and individual patches also include a
> > brief description of the API they are implementing.
>
> You happen to have a readable copy of patch 27 around? RST is utter
> garbage to read :/
An HTML copy should be available here now (thanks Arek):
https://ivyl.gg/ntsync/ntsync.html
Let me know if that's good enough or if I should try to render it into plain
text somehow.
^ permalink raw reply
* Re: [PATCH v4 00/30] NT synchronization primitive driver
From: Elizabeth Figura @ 2024-04-16 21:18 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Arnd Bergmann, Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan,
linux-kernel, linux-api, wine-devel, André Almeida,
Wolfram Sang, Arkadiusz Hiler, Andy Lutomirski, linux-doc,
linux-kselftest, Randy Dunlap, Ingo Molnar, Will Deacon,
Waiman Long, Boqun Feng
In-Reply-To: <20240416081421.GB31647@noisy.programming.kicks-ass.net>
On Tuesday, 16 April 2024 03:14:21 CDT Peter Zijlstra wrote:
> On Mon, Apr 15, 2024 at 08:08:10PM -0500, Elizabeth Figura wrote:
> > This patch series implements a new char misc driver, /dev/ntsync, which is
> > used to implement Windows NT synchronization primitives.
>
> This patch series does not apply to anything I have at hand. Nor does it
> state anything explicit to put it on top of.
It was written to apply against the 'char-misc-next' branch of gregkh/char-
misc.git. I'll make a note of that next time, sorry for the inconvenience.
> > Hence I would like to request review from someone familiar with locking to
> > make sure that the usage of low-level kernel primitives is correct and
> > that the wait queues work as intended, and to that end I've CC'd the
> > locking maintainers.
> I am sadly very limited atm, but I'll try and read through it. If only I
> could apply...
>
> > == Patches ==
> >
> > The intended semantics of the patches are broadly intended to match those
> > of the corresponding Windows functions. For those not already familiar
> > with the Windows functions (or their undocumented behaviour), patch 27/27
> > provides a detailed specification, and individual patches also include a
> > brief description of the API they are implementing.
> >
> > The patches making use of this driver in Wine can be retrieved or browsed
here:
> > https://repo.or.cz/wine/zf.git/shortlog/refs/heads/ntsync5
>
> I don't support GE has it in his builds? Last time I tried, building
> Wine was a bit of a pain.
It doesn't seem so. I tried to build a GE-compatible ntsync build, uploaded
here (thanks Arek for hosting):
https://f002.backblazeb2.com/file/wine-ntsync/ntsync-wine.tar.xz
> > Some aspects of the implementation may deserve particular comment:
> >
> > * In the interest of performance, each object is governed only by a single
> >
> > spinlock. However, NTSYNC_IOC_WAIT_ALL requires that the state of
> > multiple
> > objects be changed as a single atomic operation. In order to achieve
> > this, we first take a device-wide lock ("wait_all_lock") any time we
> > are going to lock more than one object at a time.
> >
> > The maximum number of objects that can be used in a vectored wait, and
> > therefore the maximum that can be locked simultaneously, is 64. This
> > number is NT's own limit.
> >
> > The acquisition of multiple spinlocks will degrade performance. This is
> > a
> > conscious choice, however. Wait-for-all is known to be a very rare
> > operation in practice, especially with counts that approach the
> > maximum, and it is the intent of the ntsync driver to optimize
> > wait-for-any at the expense of wait-for-all as much as possible.
>
> Per the example of percpu-rwsem, it would be possible to create a
> mutex-spinlock hybrid scheme, where single locks are spinlocks while
> held, but can block when the global thing is pending. And the global
> lock is always mutex like.
>
> If all that is worth it, I don't know. Nesting 64 spinlocks doesn't give
> me warm and fuzzy feelings though.
Is the concern about poor performance when ntsync is in use, or is nesting a
lot of spinlocks like that something that could cause problems for unrelated
tasks? I'm not familiar enough with the scheduler to know if this can be
abused.
I think we don't care about performance problems within Wine, at least. FWIW,
the scheme here is actually similar to what Windows does (as described by one
of their kernel engineers), although slightly different. NT nests spinlocks as
well, but instead of using the outer lock like our "wait_all_lock" to prevent
lock inversion, they instead sort the inner locks (by address, I assume).
If there's deeper problems... I can look into (ab)using a rwlock for this
purpose, at least for now.
In any case making wait_all_lock into a sleeping mutex instead of a spinlock
should be fine. I'll rerun performance tests but I don't expect it to cause
any problems.
^ permalink raw reply
* Re: [PATCH v4 00/30] NT synchronization primitive driver
From: Elizabeth Figura @ 2024-04-16 22:18 UTC (permalink / raw)
To: Peter Zijlstra, wine-devel
Cc: Arnd Bergmann, Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan,
linux-kernel, linux-api, wine-devel, André Almeida,
Wolfram Sang, Andy Lutomirski, linux-doc, linux-kselftest,
Randy Dunlap, Ingo Molnar, Will Deacon, Waiman Long, Boqun Feng,
Elizabeth Figura
In-Reply-To: <4340072.ejJDZkT8p0@terabithia>
On Tuesday, 16 April 2024 16:18:24 CDT Elizabeth Figura wrote:
> On Tuesday, 16 April 2024 03:14:21 CDT Peter Zijlstra wrote:
> > I don't support GE has it in his builds? Last time I tried, building
> > Wine was a bit of a pain.
>
> It doesn't seem so. I tried to build a GE-compatible ntsync build, uploaded
> here (thanks Arek for hosting):
>
> https://f002.backblazeb2.com/file/wine-ntsync/ntsync-wine.tar.xz
Oops, the initial version I uploaded had broken paths. Should be fixed now.
(It's also broken on an unpatched kernel unless explicitly disabled with
WINE_DISABLE_FAST_SYNC=1. Not sure what I messed up there—it should fall back
cleanly—but hopefully shouldn't be too important for testing.)
^ permalink raw reply
* Re: [PATCH v4 00/30] NT synchronization primitive driver
From: Peter Zijlstra @ 2024-04-17 5:21 UTC (permalink / raw)
To: Elizabeth Figura
Cc: Arnd Bergmann, Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan,
linux-kernel, linux-api, wine-devel, André Almeida,
Wolfram Sang, Arkadiusz Hiler, Andy Lutomirski, linux-doc,
linux-kselftest, Randy Dunlap, Ingo Molnar, Will Deacon,
Waiman Long, Boqun Feng
In-Reply-To: <23472492.6Emhk5qWAg@terabithia>
On Tue, Apr 16, 2024 at 04:18:17PM -0500, Elizabeth Figura wrote:
> Over different lists. I don't know if there's a better way to name things to
> make that clearer.
D'oh, reading hard. I'll stare more.
^ permalink raw reply
* Re: [PATCH v4 00/30] NT synchronization primitive driver
From: Peter Zijlstra @ 2024-04-17 5:22 UTC (permalink / raw)
To: Elizabeth Figura
Cc: Arnd Bergmann, Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan,
linux-kernel, linux-api, wine-devel, André Almeida,
Wolfram Sang, Arkadiusz Hiler, Andy Lutomirski, linux-doc,
linux-kselftest, Randy Dunlap, Ingo Molnar, Will Deacon,
Waiman Long, Boqun Feng
In-Reply-To: <2602449.Lt9SDvczpP@terabithia>
On Tue, Apr 16, 2024 at 04:18:19PM -0500, Elizabeth Figura wrote:
> Let me know if that's good enough or if I should try to render it into plain
> text somehow.
Plain text is much preferred. I'm more of a text editor kinda guy --
being a programmer and all that.
>
>
^ permalink raw reply
* Re: [PATCH v4 00/30] NT synchronization primitive driver
From: Peter Zijlstra @ 2024-04-17 5:24 UTC (permalink / raw)
To: Elizabeth Figura
Cc: Arnd Bergmann, Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan,
linux-kernel, linux-api, wine-devel, André Almeida,
Wolfram Sang, Arkadiusz Hiler, Andy Lutomirski, linux-doc,
linux-kselftest, Randy Dunlap, Ingo Molnar, Will Deacon,
Waiman Long, Boqun Feng
In-Reply-To: <4340072.ejJDZkT8p0@terabithia>
On Tue, Apr 16, 2024 at 04:18:24PM -0500, Elizabeth Figura wrote:
> Is the concern about poor performance when ntsync is in use, or is nesting a
> lot of spinlocks like that something that could cause problems for unrelated
> tasks? I'm not familiar enough with the scheduler to know if this can be
> abused.
The problem is keeping preemption disabled for potentially a fairly long
time. By doing that you potentially affect the performance of other tasks.
^ permalink raw reply
* Re: [PATCH v4 00/30] NT synchronization primitive driver
From: Elizabeth Figura @ 2024-04-17 6:05 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Arnd Bergmann, Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan,
linux-kernel, linux-api, wine-devel, André Almeida,
Wolfram Sang, Arkadiusz Hiler, Andy Lutomirski, linux-doc,
linux-kselftest, Randy Dunlap, Ingo Molnar, Will Deacon,
Waiman Long, Boqun Feng
In-Reply-To: <20240417052218.GI30852@noisy.programming.kicks-ass.net>
On Wednesday, 17 April 2024 00:22:18 CDT Peter Zijlstra wrote:
> On Tue, Apr 16, 2024 at 04:18:19PM -0500, Elizabeth Figura wrote:
> > Let me know if that's good enough or if I should try to render it into
> > plain text somehow.
>
> Plain text is much preferred. I'm more of a text editor kinda guy --
> being a programmer and all that.
I can certainly sympathize with that ;-)
Here's a (slightly ad-hoc) simplification of the patch into text form inlined
into this message; hopefully it's readable enough.
===================================
NT synchronization primitive driver
===================================
This page documents the user-space API for the ntsync driver.
ntsync is a support driver for emulation of NT synchronization
primitives by user-space NT emulators. It exists because implementation
in user-space, using existing tools, cannot match Windows performance
while offering accurate semantics. It is implemented entirely in
software, and does not drive any hardware device.
This interface is meant as a compatibility tool only, and should not
be used for general synchronization. Instead use generic, versatile
interfaces such as futex(2) and poll(2).
Synchronization primitives
==========================
The ntsync driver exposes three types of synchronization primitives:
semaphores, mutexes, and events.
A semaphore holds a single volatile 32-bit counter, and a static 32-bit
integer denoting the maximum value. It is considered signaled when the
counter is nonzero. The counter is decremented by one when a wait is
satisfied. Both the initial and maximum count are established when the
semaphore is created.
A mutex holds a volatile 32-bit recursion count, and a volatile 32-bit
identifier denoting its owner. A mutex is considered signaled when its
owner is zero (indicating that it is not owned). The recursion count is
incremented when a wait is satisfied, and ownership is set to the given
identifier.
A mutex also holds an internal flag denoting whether its previous owner
has died; such a mutex is said to be abandoned. Owner death is not
tracked automatically based on thread death, but rather must be
communicated using NTSYNC_IOC_MUTEX_KILL. An abandoned mutex is
inherently considered unowned.
Except for the "unowned" semantics of zero, the actual value of the
owner identifier is not interpreted by the ntsync driver at all. The
intended use is to store a thread identifier; however, the ntsync
driver does not actually validate that a calling thread provides
consistent or unique identifiers.
An event holds a volatile boolean state denoting whether it is signaled
or not. There are two types of events, auto-reset and manual-reset. An
auto-reset event is designaled when a wait is satisfied; a manual-reset
event is not. The event type is specified when the event is created.
Unless specified otherwise, all operations on an object are atomic and
totally ordered with respect to other operations on the same object.
Objects are represented by files. When all file descriptors to an
object are closed, that object is deleted.
Char device
===========
The ntsync driver creates a single char device /dev/ntsync. Each file
description opened on the device represents a unique instance intended
to back an individual NT virtual machine. Objects created by one ntsync
instance may only be used with other objects created by the same
instance.
ioctl reference
===============
All operations on the device are done through ioctls. There are four
structures used in ioctl calls::
struct ntsync_sem_args {
__u32 sem;
__u32 count;
__u32 max;
};
struct ntsync_mutex_args {
__u32 mutex;
__u32 owner;
__u32 count;
};
struct ntsync_event_args {
__u32 event;
__u32 signaled;
__u32 manual;
};
struct ntsync_wait_args {
__u64 timeout;
__u64 objs;
__u32 count;
__u32 owner;
__u32 index;
__u32 alert;
__u32 flags;
__u32 pad;
};
Depending on the ioctl, members of the structure may be used as input,
output, or not at all. All ioctls return 0 on success.
The ioctls on the device file are as follows:
.. NTSYNC_IOC_CREATE_SEM
Create a semaphore object. Takes a pointer to struct ntsync_sem_args,
which is used as follows:
* sem: On output, contains a file descriptor to the created semaphore.
* count: Initial count of the semaphore.
* max: Maximum count of the semaphore.
Fails with EINVAL if `count` is greater than `max`.
.. NTSYNC_IOC_CREATE_MUTEX
Create a mutex object. Takes a pointer to struct ntsync_mutex_args,
which is used as follows:
* mutex: On output, contains a file descriptor to the created mutex.
* count: Initial recursion count of the mutex.
* owner: Initial owner of the mutex.
If ``owner`` is nonzero and ``count`` is zero, or if ``owner`` is zero
and ``count`` is nonzero, the function fails with EINVAL.
.. NTSYNC_IOC_CREATE_EVENT
Create an event object. Takes a pointer to struct ntsync_event_args,
which is used as follows:
* event: On output, contains a file descriptor to the created event.
* signaled: If nonzero, the event is initially signaled, otherwise
nonsignaled.
* manual: If nonzero, the event is a manual-reset event, otherwise
auto-reset.
The ioctls on the individual objects are as follows:
.. NTSYNC_IOC_SEM_POST
Post to a semaphore object. Takes a pointer to a 32-bit integer,
which on input holds the count to be added to the semaphore, and on
output contains its previous count.
If adding to the semaphore's current count would raise the latter
past the semaphore's maximum count, the ioctl fails with
EOVERFLOW and the semaphore is not affected. If raising the
semaphore's count causes it to become signaled, eligible threads
waiting on this semaphore will be woken and the semaphore's count
decremented appropriately.
.. NTSYNC_IOC_MUTEX_UNLOCK
Release a mutex object. Takes a pointer to struct ntsync_mutex_args,
which is used as follows:
* mutex: Ignored.
* owner: Specifies the owner trying to release this mutex.
* count: On output, contains the previous recursion count.
If ``owner`` is zero, the ioctl fails with EINVAL. If ``owner``
is not the current owner of the mutex, the ioctl fails with
EPERM.
The mutex's count will be decremented by one. If decrementing the
mutex's count causes it to become zero, the mutex is marked as
unowned and signaled, and eligible threads waiting on it will be
woken as appropriate.
.. NTSYNC_IOC_SET_EVENT
Signal an event object. Takes a pointer to a 32-bit integer, which on
output contains the previous state of the event.
Eligible threads will be woken, and auto-reset events will be
designaled appropriately.
.. NTSYNC_IOC_RESET_EVENT
Designal an event object. Takes a pointer to a 32-bit integer, which
on output contains the previous state of the event.
.. NTSYNC_IOC_PULSE_EVENT
Wake threads waiting on an event object while leaving it in an
unsignaled state. Takes a pointer to a 32-bit integer, which on
output contains the previous state of the event.
A pulse operation can be thought of as a set followed by a reset,
performed as a single atomic operation. If two threads are waiting on
an auto-reset event which is pulsed, only one will be woken. If two
threads are waiting a manual-reset event which is pulsed, both will
be woken. However, in both cases, the event will be unsignaled
afterwards, and a simultaneous read operation will always report the
event as unsignaled.
.. NTSYNC_IOC_READ_SEM
Read the current state of a semaphore object. Takes a pointer to
struct ntsync_sem_args, which is used as follows:
* sem: Ignored.
* count: On output, contains the current count of the semaphore.
* max: On output, contains the maximum count of the semaphore.
.. NTSYNC_IOC_READ_MUTEX
Read the current state of a mutex object. Takes a pointer to struct
ntsync_mutex_args, which is used as follows:
* mutex: Ignored.
* owner: On output, contains the current owner of the mutex, or zero
if the mutex is not currently owned.
* count: On output, contains the current recursion count of the mutex.
If the mutex is marked as abandoned, the function fails with
EOWNERDEAD. In this case, ``count`` and ``owner`` are set to zero.
.. NTSYNC_IOC_READ_EVENT
Read the current state of an event object. Takes a pointer to struct
ntsync_event_args, which is used as follows:
* event: Ignored.
* signaled: On output, contains the current state of the event.
* manual: On output, contains 1 if the event is a manual-reset event,
and 0 otherwise.
.. NTSYNC_IOC_KILL_OWNER
Mark a mutex as unowned and abandoned if it is owned by the given
owner. Takes an input-only pointer to a 32-bit integer denoting the
owner. If the owner is zero, the ioctl fails with EINVAL. If the
owner does not own the mutex, the function fails with EPERM.
Eligible threads waiting on the mutex will be woken as appropriate
(and such waits will fail with EOWNERDEAD, as described below).
.. NTSYNC_IOC_WAIT_ANY
Poll on any of a list of objects, atomically acquiring at most one.
Takes a pointer to struct ntsync_wait_args, which is used as follows:
* timeout: Absolute timeout in nanoseconds. If NTSYNC_WAIT_REALTIME
is set, the timeout is measured against the REALTIME
clock; otherwise it is measured against the MONOTONIC
clock. If the timeout is equal to or earlier than the
current time, the function returns immediately without
sleeping. If ``timeout`` is U64_MAX, the function will
sleep until an object is signaled, and will not fail
with ETIMEDOUT.
* objs: Pointer to an array of ``count`` file descriptors
(specified as an integer so that the structure has the
same size regardless of architecture). If any object is
invalid, the function fails with EINVAL.
* count: Number of objects specified in the ``objs`` array. If
greater than NTSYNC_MAX_WAIT_COUNT, the function fails
with EINVAL.
* owner: Mutex owner identifier. If any object in ``objs`` is a
mutex, the ioctl will attempt to acquire that mutex on
behalf of ``owner``. If ``owner`` is zero, the ioctl
fails with EINVAL.
* index: On success, contains the index (into ``objs``) of the
object which was signaled. If ``alert`` was signaled
instead, this contains ``count``.
* alert: Optional event object file descriptor. If nonzero, this
specifies an "alert" event object which, if signaled,
will terminate the wait. If nonzero, the identifier must
point to a valid event.
* flags: Zero or more flags. Currently the only flag is
NTSYNC_WAIT_REALTIME, which causes the timeout to be
measured against the REALTIME clock instead of
MONOTONIC.
* pad: Unused, must be set to zero.
This function attempts to acquire one of the given objects. If unable
to do so, it sleeps until an object becomes signaled, subsequently
acquiring it, or the timeout expires. In the latter case the ioctl
fails with ETIMEDOUT. The function only acquires one object, even if
multiple objects are signaled.
A semaphore is considered to be signaled if its count is nonzero, and
is acquired by decrementing its count by one. A mutex is considered
to be signaled if it is unowned or if its owner matches the ``owner``
argument, and is acquired by incrementing its recursion count by one
and setting its owner to the ``owner`` argument. An auto-reset event
is acquired by designaling it; a manual-reset event is not affected
by acquisition.
Acquisition is atomic and totally ordered with respect to other
operations on the same object. If two wait operations (with different
``owner`` identifiers) are queued on the same mutex, only one is
signaled. If two wait operations are queued on the same semaphore,
and a value of one is posted to it, only one is signaled. The order
in which threads are signaled is not specified.
If an abandoned mutex is acquired, the ioctl fails with
EOWNERDEAD. Although this is a failure return, the function may
otherwise be considered successful. The mutex is marked as owned by
the given owner (with a recursion count of 1) and as no longer
abandoned, and ``index`` is still set to the index of the mutex.
The ``alert`` argument is an "extra" event which can terminate the
wait, independently of all other objects. If members of ``objs`` and
``alert`` are both simultaneously signaled, a member of ``objs`` will
always be given priority and acquired first.
It is valid to pass the same object more than once, including by
passing the same event in the ``objs`` array and in ``alert``. If a
wakeup occurs due to that object being signaled, ``index`` is set to
the lowest index corresponding to that object.
The function may fail with EINTR if a signal is received.
.. NTSYNC_IOC_WAIT_ALL
Poll on a list of objects, atomically acquiring all of them. Takes a
pointer to struct ntsync_wait_args, which is used identically to
NTSYNC_IOC_WAIT_ANY, except that ``index`` is always filled with zero
on success if not woken via alert.
This function attempts to simultaneously acquire all of the given
objects. If unable to do so, it sleeps until all objects become
simultaneously signaled, subsequently acquiring them, or the timeout
expires. In the latter case the ioctl fails with ETIMEDOUT and no
objects are modified.
Objects may become signaled and subsequently designaled (through
acquisition by other threads) while this thread is sleeping. Only
once all objects are simultaneously signaled does the ioctl acquire
them and return. The entire acquisition is atomic and totally ordered
with respect to other operations on any of the given objects.
If an abandoned mutex is acquired, the ioctl fails with
EOWNERDEAD. Similarly to NTSYNC_IOC_WAIT_ANY, all objects are
nevertheless marked as acquired. Note that if multiple mutex objects
are specified, there is no way to know which were marked as
abandoned.
As with "any" waits, the ``alert`` argument is an "extra" event which
can terminate the wait. Critically, however, an "all" wait will
succeed if all members in ``objs`` are signaled, *or* if ``alert`` is
signaled. In the latter case ``index`` will be set to ``count``. As
with "any" waits, if both conditions are filled, the former takes
priority, and objects in ``objs`` will be acquired.
Unlike NTSYNC_IOC_WAIT_ANY, it is not valid to pass the same
object more than once, nor is it valid to pass the same object in
``objs`` and in ``alert``. If this is attempted, the function fails
with EINVAL.
^ permalink raw reply
* Re: [PATCH v4 00/30] NT synchronization primitive driver
From: Peter Zijlstra @ 2024-04-17 10:01 UTC (permalink / raw)
To: Elizabeth Figura
Cc: Arnd Bergmann, Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan,
linux-kernel, linux-api, wine-devel, André Almeida,
Wolfram Sang, Arkadiusz Hiler, Andy Lutomirski, linux-doc,
linux-kselftest, Randy Dunlap, Ingo Molnar, Will Deacon,
Waiman Long, Boqun Feng
In-Reply-To: <1856855.atdPhlSkOF@terabithia>
On Wed, Apr 17, 2024 at 01:05:47AM -0500, Elizabeth Figura wrote:
> Here's a (slightly ad-hoc) simplification of the patch into text form inlined
> into this message; hopefully it's readable enough.
Thanks!
Still needed:
s/\`\`/"/g
s/\.\.\ //g
But then it's readable
>
> ===================================
> NT synchronization primitive driver
> ===================================
>
> This page documents the user-space API for the ntsync driver.
>
> ntsync is a support driver for emulation of NT synchronization
> primitives by user-space NT emulators. It exists because implementation
> in user-space, using existing tools, cannot match Windows performance
> while offering accurate semantics. It is implemented entirely in
> software, and does not drive any hardware device.
>
> This interface is meant as a compatibility tool only, and should not
> be used for general synchronization. Instead use generic, versatile
> interfaces such as futex(2) and poll(2).
>
> Synchronization primitives
> ==========================
>
> The ntsync driver exposes three types of synchronization primitives:
> semaphores, mutexes, and events.
>
> A semaphore holds a single volatile 32-bit counter, and a static 32-bit
> integer denoting the maximum value. It is considered signaled when the
> counter is nonzero. The counter is decremented by one when a wait is
> satisfied. Both the initial and maximum count are established when the
> semaphore is created.
>
> A mutex holds a volatile 32-bit recursion count, and a volatile 32-bit
> identifier denoting its owner. A mutex is considered signaled when its
> owner is zero (indicating that it is not owned). The recursion count is
> incremented when a wait is satisfied, and ownership is set to the given
> identifier.
'signaled' is used twice now but not defined. For both Semaphore and
Mutex this seems to indicate uncontended? Edit: seems to be needs-wakeup
more than uncontended.
> A mutex also holds an internal flag denoting whether its previous owner
> has died; such a mutex is said to be abandoned. Owner death is not
> tracked automatically based on thread death, but rather must be
> communicated using NTSYNC_IOC_MUTEX_KILL. An abandoned mutex is
> inherently considered unowned.
>
> Except for the "unowned" semantics of zero, the actual value of the
> owner identifier is not interpreted by the ntsync driver at all. The
> intended use is to store a thread identifier; however, the ntsync
> driver does not actually validate that a calling thread provides
> consistent or unique identifiers.
Why not verify it? Seems simple enough to put in a TID check, esp. if NT
mandates the same.
> An event holds a volatile boolean state denoting whether it is signaled
> or not. There are two types of events, auto-reset and manual-reset. An
> auto-reset event is designaled when a wait is satisfied; a manual-reset
> event is not. The event type is specified when the event is created.
But what is an event? I'm familiar with semaphores and mutexes, but less
so with events.
> Unless specified otherwise, all operations on an object are atomic and
> totally ordered with respect to other operations on the same object.
>
> Objects are represented by files. When all file descriptors to an
> object are closed, that object is deleted.
>
> Char device
> ===========
>
> The ntsync driver creates a single char device /dev/ntsync. Each file
> description opened on the device represents a unique instance intended
> to back an individual NT virtual machine. Objects created by one ntsync
> instance may only be used with other objects created by the same
> instance.
>
> ioctl reference
> ===============
>
> All operations on the device are done through ioctls. There are four
> structures used in ioctl calls::
>
> struct ntsync_sem_args {
> __u32 sem;
> __u32 count;
> __u32 max;
> };
>
> struct ntsync_mutex_args {
> __u32 mutex;
> __u32 owner;
> __u32 count;
> };
>
> struct ntsync_event_args {
> __u32 event;
> __u32 signaled;
> __u32 manual;
> };
>
> struct ntsync_wait_args {
> __u64 timeout;
> __u64 objs;
> __u32 count;
> __u32 owner;
> __u32 index;
> __u32 alert;
> __u32 flags;
> __u32 pad;
> };
>
> Depending on the ioctl, members of the structure may be used as input,
> output, or not at all. All ioctls return 0 on success.
>
> The ioctls on the device file are as follows:
>
> NTSYNC_IOC_CREATE_SEM
>
> Create a semaphore object. Takes a pointer to struct ntsync_sem_args,
> which is used as follows:
>
> * sem: On output, contains a file descriptor to the created semaphore.
> * count: Initial count of the semaphore.
> * max: Maximum count of the semaphore.
>
> Fails with EINVAL if `count` is greater than `max`.
So the implication is that @count and @max are input argument and as
such should be set before calling the ioctl()?
It would not have been weird to have the ioctl() return the fd on
success I suppose, instead of mixing input and output arguments like
this, but whatever, this works.
> NTSYNC_IOC_CREATE_MUTEX
>
> Create a mutex object. Takes a pointer to struct ntsync_mutex_args,
> which is used as follows:
>
> * mutex: On output, contains a file descriptor to the created mutex.
> * count: Initial recursion count of the mutex.
> * owner: Initial owner of the mutex.
>
> If "owner" is nonzero and "count" is zero, or if "owner" is zero
> and "count" is nonzero, the function fails with EINVAL.
>
> NTSYNC_IOC_CREATE_EVENT
>
> Create an event object. Takes a pointer to struct ntsync_event_args,
> which is used as follows:
>
> * event: On output, contains a file descriptor to the created event.
> * signaled: If nonzero, the event is initially signaled, otherwise
> nonsignaled.
> * manual: If nonzero, the event is a manual-reset event, otherwise
> auto-reset.
>
Still mystified as to what event actually is, perhaps more clues
below...
> The ioctls on the individual objects are as follows:
>
> NTSYNC_IOC_SEM_POST
>
> Post to a semaphore object. Takes a pointer to a 32-bit integer,
> which on input holds the count to be added to the semaphore, and on
> output contains its previous count.
>
> If adding to the semaphore's current count would raise the latter
> past the semaphore's maximum count, the ioctl fails with
> EOVERFLOW and the semaphore is not affected. If raising the
> semaphore's count causes it to become signaled, eligible threads
> waiting on this semaphore will be woken and the semaphore's count
> decremented appropriately.
Urg, so this is the traditional V (vrijgeven per Dijkstra, release in
English), but now 'conveniently' called POST, such that it can be
readily confused with the P operation (passering, or passing) which it
is not.
Glorious :-/
You're of course going to tell me NT did this and you can't help this
naming foible.
> NTSYNC_IOC_MUTEX_UNLOCK
>
> Release a mutex object. Takes a pointer to struct ntsync_mutex_args,
> which is used as follows:
>
> * mutex: Ignored.
> * owner: Specifies the owner trying to release this mutex.
> * count: On output, contains the previous recursion count.
>
> If "owner" is zero, the ioctl fails with EINVAL. If "owner"
> is not the current owner of the mutex, the ioctl fails with
> EPERM.
ISTR you having written elsewhere that NT actually demands mutexes to be
strictly per thread, which for the above would mandate @owner to be
current, no?
> The mutex's count will be decremented by one. If decrementing the
> mutex's count causes it to become zero, the mutex is marked as
> unowned and signaled, and eligible threads waiting on it will be
> woken as appropriate.
>
> NTSYNC_IOC_SET_EVENT
>
> Signal an event object. Takes a pointer to a 32-bit integer, which on
> output contains the previous state of the event.
>
> Eligible threads will be woken, and auto-reset events will be
> designaled appropriately.
Hmm, so the event thing is like a simple wait-wake scheme? Where the
'signaled' bit is used as the wakeup state?
> NTSYNC_IOC_RESET_EVENT
>
> Designal an event object. Takes a pointer to a 32-bit integer, which
> on output contains the previous state of the event.
>
> NTSYNC_IOC_PULSE_EVENT
>
> Wake threads waiting on an event object while leaving it in an
> unsignaled state. Takes a pointer to a 32-bit integer, which on
> output contains the previous state of the event.
>
> A pulse operation can be thought of as a set followed by a reset,
> performed as a single atomic operation. If two threads are waiting on
> an auto-reset event which is pulsed, only one will be woken. If two
> threads are waiting a manual-reset event which is pulsed, both will
> be woken. However, in both cases, the event will be unsignaled
> afterwards, and a simultaneous read operation will always report the
> event as unsignaled.
*groan*
> NTSYNC_IOC_READ_SEM
>
> Read the current state of a semaphore object. Takes a pointer to
> struct ntsync_sem_args, which is used as follows:
>
> * sem: Ignored.
> * count: On output, contains the current count of the semaphore.
> * max: On output, contains the maximum count of the semaphore.
This seems inherently racy -- what is the intended purpose of this
interface?
Specifically the moment a value is returned, either P or V operations
can change it, rendering the (as yet unused) return value incorrect.
> NTSYNC_IOC_READ_MUTEX
>
> Read the current state of a mutex object. Takes a pointer to struct
> ntsync_mutex_args, which is used as follows:
>
> * mutex: Ignored.
> * owner: On output, contains the current owner of the mutex, or zero
> if the mutex is not currently owned.
> * count: On output, contains the current recursion count of the mutex.
>
> If the mutex is marked as abandoned, the function fails with
> EOWNERDEAD. In this case, "count" and "owner" are set to zero.
Another questionable interface. I suspect you're going to be telling me
NT has them so you have to have them, but urgh.
> NTSYNC_IOC_READ_EVENT
>
> Read the current state of an event object. Takes a pointer to struct
> ntsync_event_args, which is used as follows:
>
> * event: Ignored.
> * signaled: On output, contains the current state of the event.
> * manual: On output, contains 1 if the event is a manual-reset event,
> and 0 otherwise.
I can't help but notice all those @sem, @mutex, @event 'output' members
being unused except for create. Seems like a waste to have them.
> NTSYNC_IOC_KILL_OWNER
>
> Mark a mutex as unowned and abandoned if it is owned by the given
> owner. Takes an input-only pointer to a 32-bit integer denoting the
> owner. If the owner is zero, the ioctl fails with EINVAL. If the
> owner does not own the mutex, the function fails with EPERM.
>
> Eligible threads waiting on the mutex will be woken as appropriate
> (and such waits will fail with EOWNERDEAD, as described below).
Wine will use this when it detects a thread exit I suppose.
> NTSYNC_IOC_WAIT_ANY
>
> Poll on any of a list of objects, atomically acquiring at most one.
> Takes a pointer to struct ntsync_wait_args, which is used as follows:
>
> * timeout: Absolute timeout in nanoseconds. If NTSYNC_WAIT_REALTIME
> is set, the timeout is measured against the REALTIME
> clock; otherwise it is measured against the MONOTONIC
> clock. If the timeout is equal to or earlier than the
> current time, the function returns immediately without
> sleeping. If "timeout" is U64_MAX, the function will
> sleep until an object is signaled, and will not fail
> with ETIMEDOUT.
>
> * objs: Pointer to an array of "count" file descriptors
> (specified as an integer so that the structure has the
> same size regardless of architecture). If any object is
> invalid, the function fails with EINVAL.
>
> * count: Number of objects specified in the "objs" array. If
> greater than NTSYNC_MAX_WAIT_COUNT, the function fails
> with EINVAL.
>
> * owner: Mutex owner identifier. If any object in "objs" is a
> mutex, the ioctl will attempt to acquire that mutex on
> behalf of "owner". If "owner" is zero, the ioctl
> fails with EINVAL.
Again, should that not be current? That is, why not maintain the NT
invariant and mandates TIDs and avoid the arguments in both cases?
> * index: On success, contains the index (into "objs") of the
> object which was signaled. If "alert" was signaled
> instead, this contains "count".
Could be the actual return value, no? Edit: no it cannot be because
-EOWNERDEAD case below.
>
> * alert: Optional event object file descriptor. If nonzero, this
> specifies an "alert" event object which, if signaled,
> will terminate the wait. If nonzero, the identifier must
> point to a valid event.
>
> * flags: Zero or more flags. Currently the only flag is
> NTSYNC_WAIT_REALTIME, which causes the timeout to be
> measured against the REALTIME clock instead of
> MONOTONIC.
>
> * pad: Unused, must be set to zero.
>
> This function attempts to acquire one of the given objects. If unable
> to do so, it sleeps until an object becomes signaled, subsequently
> acquiring it, or the timeout expires. In the latter case the ioctl
> fails with ETIMEDOUT. The function only acquires one object, even if
> multiple objects are signaled.
Any guarantee as to which will be acquired in case multiple are
available? [A]
> A semaphore is considered to be signaled if its count is nonzero, and
> is acquired by decrementing its count by one. A mutex is considered
> to be signaled if it is unowned or if its owner matches the "owner"
> argument, and is acquired by incrementing its recursion count by one
> and setting its owner to the "owner" argument. An auto-reset event
> is acquired by designaling it; a manual-reset event is not affected
> by acquisition.
>
> Acquisition is atomic and totally ordered with respect to other
> operations on the same object. If two wait operations (with different
> "owner" identifiers) are queued on the same mutex, only one is
> signaled. If two wait operations are queued on the same semaphore,
> and a value of one is posted to it, only one is signaled. The order
> in which threads are signaled is not specified.
Note that you do list the lack of guarantee here, but not above. I
suspect both cases are similar and guarantee nothing.
> If an abandoned mutex is acquired, the ioctl fails with
> EOWNERDEAD. Although this is a failure return, the function may
> otherwise be considered successful. The mutex is marked as owned by
> the given owner (with a recursion count of 1) and as no longer
> abandoned, and "index" is still set to the index of the mutex.
Aaah, I see, this does indeed preclude @index from being the return
value.
> The "alert" argument is an "extra" event which can terminate the
> wait, independently of all other objects. If members of "objs" and
> "alert" are both simultaneously signaled, a member of "objs" will
> always be given priority and acquired first.
>
> It is valid to pass the same object more than once, including by
> passing the same event in the "objs" array and in "alert". If a
> wakeup occurs due to that object being signaled, "index" is set to
> the lowest index corresponding to that object.
Urgh, is this an actual guarantee? This almost seems to imply that at
[A] above we can indeed guarantee the lowest indexed object is acquired
first.
> The function may fail with EINTR if a signal is received.
In which case @index must be disregarded since nothing will be acquired,
right?
So far nothing really weird, and I'm thinking futexes should be able to
do all this, no?
> NTSYNC_IOC_WAIT_ALL
>
> Poll on a list of objects, atomically acquiring all of them. Takes a
> pointer to struct ntsync_wait_args, which is used identically to
> NTSYNC_IOC_WAIT_ANY, except that "index" is always filled with zero
> on success if not woken via alert.
Whee, and this is the one weird operation that you're all struggling to
emulate, right? The atomic multi-acquire is 'hard' to do with futexes.
> This function attempts to simultaneously acquire all of the given
> objects. If unable to do so, it sleeps until all objects become
> simultaneously signaled, subsequently acquiring them, or the timeout
> expires. In the latter case the ioctl fails with ETIMEDOUT and no
> objects are modified.
>
> Objects may become signaled and subsequently designaled (through
> acquisition by other threads) while this thread is sleeping. Only
> once all objects are simultaneously signaled does the ioctl acquire
> them and return. The entire acquisition is atomic and totally ordered
> with respect to other operations on any of the given objects.
>
> If an abandoned mutex is acquired, the ioctl fails with
> EOWNERDEAD. Similarly to NTSYNC_IOC_WAIT_ANY, all objects are
> nevertheless marked as acquired. Note that if multiple mutex objects
> are specified, there is no way to know which were marked as
> abandoned.
>
> As with "any" waits, the "alert" argument is an "extra" event which
> can terminate the wait. Critically, however, an "all" wait will
> succeed if all members in "objs" are signaled, *or* if "alert" is
> signaled. In the latter case "index" will be set to "count". As
> with "any" waits, if both conditions are filled, the former takes
> priority, and objects in "objs" will be acquired.
>
> Unlike NTSYNC_IOC_WAIT_ANY, it is not valid to pass the same
> object more than once, nor is it valid to pass the same object in
> "objs" and in "alert". If this is attempted, the function fails
> with EINVAL.
OK, this all was helpful, I'll go stare at the code again.
Thanks!
^ permalink raw reply
* Re: [PATCH v4 02/27] ntsync: Introduce NTSYNC_IOC_WAIT_ALL.
From: Peter Zijlstra @ 2024-04-17 11:37 UTC (permalink / raw)
To: Elizabeth Figura
Cc: Arnd Bergmann, Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan,
linux-kernel, linux-api, wine-devel, André Almeida,
Wolfram Sang, Arkadiusz Hiler, Andy Lutomirski, linux-doc,
linux-kselftest, Randy Dunlap, Ingo Molnar, Will Deacon,
Waiman Long, Boqun Feng
In-Reply-To: <20240416010837.333694-3-zfigura@codeweavers.com>
On Mon, Apr 15, 2024 at 08:08:12PM -0500, Elizabeth Figura wrote:
> + if (atomic_read(&sem->all_hint) > 0) {
> + spin_lock(&dev->wait_all_lock);
> + spin_lock_nest_lock(&sem->lock, &dev->wait_all_lock);
>
> + prev_count = sem->u.sem.count;
> + ret = post_sem_state(sem, args);
> + if (!ret) {
> + try_wake_all_obj(dev, sem);
> + try_wake_any_sem(sem);
> + }
>
> + spin_unlock(&sem->lock);
> + spin_unlock(&dev->wait_all_lock);
> + } else {
> + spin_lock(&sem->lock);
> +
> + prev_count = sem->u.sem.count;
> + ret = post_sem_state(sem, args);
> + if (!ret)
> + try_wake_any_sem(sem);
> +
> + spin_unlock(&sem->lock);
> + }
>
> if (!ret && put_user(prev_count, user_args))
> ret = -EFAULT;
vs.
> + /* queue ourselves */
> +
> + spin_lock(&dev->wait_all_lock);
> +
> + for (i = 0; i < args.count; i++) {
> + struct ntsync_q_entry *entry = &q->entries[i];
> + struct ntsync_obj *obj = entry->obj;
> +
> + atomic_inc(&obj->all_hint);
> +
> + /*
> + * obj->all_waiters is protected by dev->wait_all_lock rather
> + * than obj->lock, so there is no need to acquire obj->lock
> + * here.
> + */
> + list_add_tail(&entry->node, &obj->all_waiters);
> + }
This looks racy, consider:
atomic_read(all_hints) /* 0 */
spin_lock(wait_all_lock)
atomic_inc(all_hint) /* 1 */
list_add_tail()
spin_lock(sem->lock)
/* try_wake_all_obj() missing */
I've not yet thought about if this is harmful or not, but if not, it
definitely needs a comment.
Anyway, I need a break, maybe more this evening.
^ permalink raw reply
* [PATCH v5 0/3] VT: Add ability to get font requirements
From: Alexey Gladkov @ 2024-04-17 17:37 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby
Cc: LKML, kbd, linux-api, linux-fbdev, linux-serial
In-Reply-To: <cover.1712080158.git.legion@kernel.org>
We now have KD_FONT_OP_SET_TALL, but in fact such large fonts cannot be
loaded. No console driver supports tall fonts. Unfortunately, userspace
cannot distinguish the lack of support in the driver from errors in the
font itself. In all cases, EINVAL will be returned.
This patchset adds a separate ioctl to obtain the font parameters
supported by the console driver.
v5:
* Use data types that are compatible with the uapi structure.
* Use _IOR to define a new ioctl as required for new ioctls.
v4:
* Rebased on v6.9-rc1 and conflicts have been fixed.
* Do not copy KDFONTINFO data from the userspace.
* Header include/uapi/linux/kd.h uses _IOC macros to define ioctls.
v3:
* Added the use of the in_range macro.
* Squashed the commits that add ioctl to console divers.
v2:
* Instead of the KDFONTOP extension, a new ioctl has been added to
obtain font information.
Alexey Gladkov (3):
VT: Use macros to define ioctls
VT: Add KDFONTINFO ioctl
VT: Allow to get max font width and height
drivers/tty/vt/vt.c | 24 ++++++
drivers/tty/vt/vt_ioctl.c | 13 ++++
drivers/video/console/newport_con.c | 21 +++++-
drivers/video/console/sticon.c | 25 ++++++-
drivers/video/console/vgacon.c | 21 +++++-
drivers/video/fbdev/core/fbcon.c | 16 ++++
include/linux/console.h | 3 +
include/linux/vt_kern.h | 1 +
include/uapi/linux/kd.h | 110 ++++++++++++++++------------
9 files changed, 180 insertions(+), 54 deletions(-)
--
2.44.0
^ permalink raw reply
* [PATCH v5 1/3] VT: Use macros to define ioctls
From: Alexey Gladkov @ 2024-04-17 17:37 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby
Cc: LKML, kbd, linux-api, linux-fbdev, linux-serial
In-Reply-To: <cover.1713375378.git.legion@kernel.org>
All other headers use _IOC() macros to describe ioctls for a long time
now. This header is stuck in the last century.
Simply use the _IO() macro. No other changes.
Signed-off-by: Alexey Gladkov <legion@kernel.org>
---
include/uapi/linux/kd.h | 96 +++++++++++++++++++++--------------------
1 file changed, 49 insertions(+), 47 deletions(-)
diff --git a/include/uapi/linux/kd.h b/include/uapi/linux/kd.h
index 6b384065c013..8ddb2219a84b 100644
--- a/include/uapi/linux/kd.h
+++ b/include/uapi/linux/kd.h
@@ -5,60 +5,61 @@
#include <linux/compiler.h>
/* 0x4B is 'K', to avoid collision with termios and vt */
+#define KD_IOCTL_BASE 'K'
-#define GIO_FONT 0x4B60 /* gets font in expanded form */
-#define PIO_FONT 0x4B61 /* use font in expanded form */
+#define GIO_FONT _IO(KD_IOCTL_BASE, 0x60) /* gets font in expanded form */
+#define PIO_FONT _IO(KD_IOCTL_BASE, 0x61) /* use font in expanded form */
-#define GIO_FONTX 0x4B6B /* get font using struct consolefontdesc */
-#define PIO_FONTX 0x4B6C /* set font using struct consolefontdesc */
+#define GIO_FONTX _IO(KD_IOCTL_BASE, 0x6B) /* get font using struct consolefontdesc */
+#define PIO_FONTX _IO(KD_IOCTL_BASE, 0x6C) /* set font using struct consolefontdesc */
struct consolefontdesc {
unsigned short charcount; /* characters in font (256 or 512) */
unsigned short charheight; /* scan lines per character (1-32) */
char __user *chardata; /* font data in expanded form */
};
-#define PIO_FONTRESET 0x4B6D /* reset to default font */
+#define PIO_FONTRESET _IO(KD_IOCTL_BASE, 0x6D) /* reset to default font */
-#define GIO_CMAP 0x4B70 /* gets colour palette on VGA+ */
-#define PIO_CMAP 0x4B71 /* sets colour palette on VGA+ */
+#define GIO_CMAP _IO(KD_IOCTL_BASE, 0x70) /* gets colour palette on VGA+ */
+#define PIO_CMAP _IO(KD_IOCTL_BASE, 0x71) /* sets colour palette on VGA+ */
-#define KIOCSOUND 0x4B2F /* start sound generation (0 for off) */
-#define KDMKTONE 0x4B30 /* generate tone */
+#define KIOCSOUND _IO(KD_IOCTL_BASE, 0x2F) /* start sound generation (0 for off) */
+#define KDMKTONE _IO(KD_IOCTL_BASE, 0x30) /* generate tone */
-#define KDGETLED 0x4B31 /* return current led state */
-#define KDSETLED 0x4B32 /* set led state [lights, not flags] */
+#define KDGETLED _IO(KD_IOCTL_BASE, 0x31) /* return current led state */
+#define KDSETLED _IO(KD_IOCTL_BASE, 0x32) /* set led state [lights, not flags] */
#define LED_SCR 0x01 /* scroll lock led */
#define LED_NUM 0x02 /* num lock led */
#define LED_CAP 0x04 /* caps lock led */
-#define KDGKBTYPE 0x4B33 /* get keyboard type */
+#define KDGKBTYPE _IO(KD_IOCTL_BASE, 0x33) /* get keyboard type */
#define KB_84 0x01
#define KB_101 0x02 /* this is what we always answer */
#define KB_OTHER 0x03
-#define KDADDIO 0x4B34 /* add i/o port as valid */
-#define KDDELIO 0x4B35 /* del i/o port as valid */
-#define KDENABIO 0x4B36 /* enable i/o to video board */
-#define KDDISABIO 0x4B37 /* disable i/o to video board */
+#define KDADDIO _IO(KD_IOCTL_BASE, 0x34) /* add i/o port as valid */
+#define KDDELIO _IO(KD_IOCTL_BASE, 0x35) /* del i/o port as valid */
+#define KDENABIO _IO(KD_IOCTL_BASE, 0x36) /* enable i/o to video board */
+#define KDDISABIO _IO(KD_IOCTL_BASE, 0x37) /* disable i/o to video board */
-#define KDSETMODE 0x4B3A /* set text/graphics mode */
+#define KDSETMODE _IO(KD_IOCTL_BASE, 0x3A) /* set text/graphics mode */
#define KD_TEXT 0x00
#define KD_GRAPHICS 0x01
#define KD_TEXT0 0x02 /* obsolete */
#define KD_TEXT1 0x03 /* obsolete */
-#define KDGETMODE 0x4B3B /* get current mode */
+#define KDGETMODE _IO(KD_IOCTL_BASE, 0x3B) /* get current mode */
-#define KDMAPDISP 0x4B3C /* map display into address space */
-#define KDUNMAPDISP 0x4B3D /* unmap display from address space */
+#define KDMAPDISP _IO(KD_IOCTL_BASE, 0x3C) /* map display into address space */
+#define KDUNMAPDISP _IO(KD_IOCTL_BASE, 0x3D) /* unmap display from address space */
typedef char scrnmap_t;
#define E_TABSZ 256
-#define GIO_SCRNMAP 0x4B40 /* get screen mapping from kernel */
-#define PIO_SCRNMAP 0x4B41 /* put screen mapping table in kernel */
-#define GIO_UNISCRNMAP 0x4B69 /* get full Unicode screen mapping */
-#define PIO_UNISCRNMAP 0x4B6A /* set full Unicode screen mapping */
+#define GIO_SCRNMAP _IO(KD_IOCTL_BASE, 0x40) /* get screen mapping from kernel */
+#define PIO_SCRNMAP _IO(KD_IOCTL_BASE, 0x41) /* put screen mapping table in kernel */
+#define GIO_UNISCRNMAP _IO(KD_IOCTL_BASE, 0x69) /* get full Unicode screen mapping */
+#define PIO_UNISCRNMAP _IO(KD_IOCTL_BASE, 0x6A) /* set full Unicode screen mapping */
-#define GIO_UNIMAP 0x4B66 /* get unicode-to-font mapping from kernel */
+#define GIO_UNIMAP _IO(KD_IOCTL_BASE, 0x66) /* get unicode-to-font mapping from kernel */
struct unipair {
unsigned short unicode;
unsigned short fontpos;
@@ -67,8 +68,8 @@ struct unimapdesc {
unsigned short entry_ct;
struct unipair __user *entries;
};
-#define PIO_UNIMAP 0x4B67 /* put unicode-to-font mapping in kernel */
-#define PIO_UNIMAPCLR 0x4B68 /* clear table, possibly advise hash algorithm */
+#define PIO_UNIMAP _IO(KD_IOCTL_BASE, 0x67) /* put unicode-to-font mapping in kernel */
+#define PIO_UNIMAPCLR _IO(KD_IOCTL_BASE, 0x68) /* clear table, possibly advise hash algorithm */
struct unimapinit {
unsigned short advised_hashsize; /* 0 if no opinion */
unsigned short advised_hashstep; /* 0 if no opinion */
@@ -83,19 +84,19 @@ struct unimapinit {
#define K_MEDIUMRAW 0x02
#define K_UNICODE 0x03
#define K_OFF 0x04
-#define KDGKBMODE 0x4B44 /* gets current keyboard mode */
-#define KDSKBMODE 0x4B45 /* sets current keyboard mode */
+#define KDGKBMODE _IO(KD_IOCTL_BASE, 0x44) /* gets current keyboard mode */
+#define KDSKBMODE _IO(KD_IOCTL_BASE, 0x45) /* sets current keyboard mode */
#define K_METABIT 0x03
#define K_ESCPREFIX 0x04
-#define KDGKBMETA 0x4B62 /* gets meta key handling mode */
-#define KDSKBMETA 0x4B63 /* sets meta key handling mode */
+#define KDGKBMETA _IO(KD_IOCTL_BASE, 0x62) /* gets meta key handling mode */
+#define KDSKBMETA _IO(KD_IOCTL_BASE, 0x63) /* sets meta key handling mode */
#define K_SCROLLLOCK 0x01
#define K_NUMLOCK 0x02
#define K_CAPSLOCK 0x04
-#define KDGKBLED 0x4B64 /* get led flags (not lights) */
-#define KDSKBLED 0x4B65 /* set led flags (not lights) */
+#define KDGKBLED _IO(KD_IOCTL_BASE, 0x64) /* get led flags (not lights) */
+#define KDSKBLED _IO(KD_IOCTL_BASE, 0x65) /* set led flags (not lights) */
struct kbentry {
unsigned char kb_table;
@@ -107,15 +108,15 @@ struct kbentry {
#define K_ALTTAB 0x02
#define K_ALTSHIFTTAB 0x03
-#define KDGKBENT 0x4B46 /* gets one entry in translation table */
-#define KDSKBENT 0x4B47 /* sets one entry in translation table */
+#define KDGKBENT _IO(KD_IOCTL_BASE, 0x46) /* gets one entry in translation table */
+#define KDSKBENT _IO(KD_IOCTL_BASE, 0x47) /* sets one entry in translation table */
struct kbsentry {
unsigned char kb_func;
unsigned char kb_string[512];
};
-#define KDGKBSENT 0x4B48 /* gets one function key string entry */
-#define KDSKBSENT 0x4B49 /* sets one function key string entry */
+#define KDGKBSENT _IO(KD_IOCTL_BASE, 0x48) /* gets one function key string entry */
+#define KDSKBSENT _IO(KD_IOCTL_BASE, 0x49) /* sets one function key string entry */
struct kbdiacr {
unsigned char diacr, base, result;
@@ -124,8 +125,8 @@ struct kbdiacrs {
unsigned int kb_cnt; /* number of entries in following array */
struct kbdiacr kbdiacr[256]; /* MAX_DIACR from keyboard.h */
};
-#define KDGKBDIACR 0x4B4A /* read kernel accent table */
-#define KDSKBDIACR 0x4B4B /* write kernel accent table */
+#define KDGKBDIACR _IO(KD_IOCTL_BASE, 0x4A) /* read kernel accent table */
+#define KDSKBDIACR _IO(KD_IOCTL_BASE, 0x4B) /* write kernel accent table */
struct kbdiacruc {
unsigned int diacr, base, result;
@@ -134,16 +135,16 @@ struct kbdiacrsuc {
unsigned int kb_cnt; /* number of entries in following array */
struct kbdiacruc kbdiacruc[256]; /* MAX_DIACR from keyboard.h */
};
-#define KDGKBDIACRUC 0x4BFA /* read kernel accent table - UCS */
-#define KDSKBDIACRUC 0x4BFB /* write kernel accent table - UCS */
+#define KDGKBDIACRUC _IO(KD_IOCTL_BASE, 0xFA) /* read kernel accent table - UCS */
+#define KDSKBDIACRUC _IO(KD_IOCTL_BASE, 0xFB) /* write kernel accent table - UCS */
struct kbkeycode {
unsigned int scancode, keycode;
};
-#define KDGETKEYCODE 0x4B4C /* read kernel keycode table entry */
-#define KDSETKEYCODE 0x4B4D /* write kernel keycode table entry */
+#define KDGETKEYCODE _IO(KD_IOCTL_BASE, 0x4C) /* read kernel keycode table entry */
+#define KDSETKEYCODE _IO(KD_IOCTL_BASE, 0x4D) /* write kernel keycode table entry */
-#define KDSIGACCEPT 0x4B4E /* accept kbd generated signals */
+#define KDSIGACCEPT _IO(KD_IOCTL_BASE, 0x4E) /* accept kbd generated signals */
struct kbd_repeat {
int delay; /* in msec; <= 0: don't change */
@@ -151,10 +152,11 @@ struct kbd_repeat {
/* earlier this field was misnamed "rate" */
};
-#define KDKBDREP 0x4B52 /* set keyboard delay/repeat rate;
- * actually used values are returned */
+#define KDKBDREP _IO(KD_IOCTL_BASE, 0x52) /* set keyboard delay/repeat rate;
+ * actually used values are returned
+ */
-#define KDFONTOP 0x4B72 /* font operations */
+#define KDFONTOP _IO(KD_IOCTL_BASE, 0x72) /* font operations */
struct console_font_op {
unsigned int op; /* operation code KD_FONT_OP_* */
--
2.44.0
^ permalink raw reply related
* [PATCH v5 2/3] VT: Add KDFONTINFO ioctl
From: Alexey Gladkov @ 2024-04-17 17:37 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby
Cc: LKML, kbd, linux-api, linux-fbdev, linux-serial, Helge Deller
In-Reply-To: <cover.1713375378.git.legion@kernel.org>
Each driver has its own restrictions on font size. There is currently no
way to understand what the requirements are. The new ioctl allows
userspace to get the minimum and maximum font size values.
Acked-by: Helge Deller <deller@gmx.de>
Signed-off-by: Alexey Gladkov <legion@kernel.org>
---
drivers/tty/vt/vt.c | 24 ++++++++++++++++++++++++
drivers/tty/vt/vt_ioctl.c | 13 +++++++++++++
include/linux/console.h | 3 +++
include/linux/vt_kern.h | 1 +
include/uapi/linux/kd.h | 14 ++++++++++++++
5 files changed, 55 insertions(+)
diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index 9b5b98dfc8b4..e8db0e9ea674 100644
--- a/drivers/tty/vt/vt.c
+++ b/drivers/tty/vt/vt.c
@@ -4851,6 +4851,30 @@ int con_font_op(struct vc_data *vc, struct console_font_op *op)
return -ENOSYS;
}
+int con_font_info(struct vc_data *vc, struct console_font_info *info)
+{
+ int rc;
+
+ info->min_height = 0;
+ info->max_height = max_font_height;
+
+ info->min_width = 0;
+ info->max_width = max_font_width;
+
+ info->flags = KD_FONT_INFO_FLAG_LOW_SIZE | KD_FONT_INFO_FLAG_HIGH_SIZE;
+
+ console_lock();
+ if (vc->vc_mode != KD_TEXT)
+ rc = -EINVAL;
+ else if (vc->vc_sw->con_font_info)
+ rc = vc->vc_sw->con_font_info(vc, info);
+ else
+ rc = -ENOSYS;
+ console_unlock();
+
+ return rc;
+}
+
/*
* Interface exported to selection and vcs.
*/
diff --git a/drivers/tty/vt/vt_ioctl.c b/drivers/tty/vt/vt_ioctl.c
index 4b91072f3a4e..9a2f8081f650 100644
--- a/drivers/tty/vt/vt_ioctl.c
+++ b/drivers/tty/vt/vt_ioctl.c
@@ -479,6 +479,19 @@ static int vt_k_ioctl(struct tty_struct *tty, unsigned int cmd,
break;
}
+ case KDFONTINFO: {
+ struct console_font_info fnt_info;
+
+ memset(&fnt_info, 0, sizeof(fnt_info));
+
+ ret = con_font_info(vc, &fnt_info);
+ if (ret)
+ return ret;
+ if (copy_to_user(up, &fnt_info, sizeof(fnt_info)))
+ return -EFAULT;
+ break;
+ }
+
default:
return -ENOIOCTLCMD;
}
diff --git a/include/linux/console.h b/include/linux/console.h
index 31a8f5b85f5d..4b798322aa01 100644
--- a/include/linux/console.h
+++ b/include/linux/console.h
@@ -21,6 +21,7 @@
#include <linux/vesa.h>
struct vc_data;
+struct console_font_info;
struct console_font_op;
struct console_font;
struct module;
@@ -102,6 +103,8 @@ struct consw {
bool (*con_switch)(struct vc_data *vc);
bool (*con_blank)(struct vc_data *vc, enum vesa_blank_mode blank,
bool mode_switch);
+ int (*con_font_info)(struct vc_data *vc,
+ struct console_font_info *info);
int (*con_font_set)(struct vc_data *vc,
const struct console_font *font,
unsigned int vpitch, unsigned int flags);
diff --git a/include/linux/vt_kern.h b/include/linux/vt_kern.h
index d008c3d0a9bb..383b3a4f6113 100644
--- a/include/linux/vt_kern.h
+++ b/include/linux/vt_kern.h
@@ -33,6 +33,7 @@ void do_blank_screen(int entering_gfx);
void do_unblank_screen(int leaving_gfx);
void poke_blanked_console(void);
int con_font_op(struct vc_data *vc, struct console_font_op *op);
+int con_font_info(struct vc_data *vc, struct console_font_info *info);
int con_set_cmap(unsigned char __user *cmap);
int con_get_cmap(unsigned char __user *cmap);
void scrollback(struct vc_data *vc);
diff --git a/include/uapi/linux/kd.h b/include/uapi/linux/kd.h
index 8ddb2219a84b..68b715ad4d5c 100644
--- a/include/uapi/linux/kd.h
+++ b/include/uapi/linux/kd.h
@@ -185,6 +185,20 @@ struct console_font {
#define KD_FONT_FLAG_DONT_RECALC 1 /* Don't recalculate hw charcell size [compat] */
+/* font information */
+
+#define KD_FONT_INFO_FLAG_LOW_SIZE _BITUL(0) /* 256 */
+#define KD_FONT_INFO_FLAG_HIGH_SIZE _BITUL(1) /* 512 */
+
+struct console_font_info {
+ __u32 flags; /* KD_FONT_INFO_FLAG_* */
+ __u32 min_width, min_height; /* minimal font size */
+ __u32 max_width, max_height; /* maximum font size */
+ __u32 reserved[5]; /* This field is reserved for future use. Must be 0. */
+};
+
+#define KDFONTINFO _IOR(KD_IOCTL_BASE, 0x73, struct console_font_info)
+
/* note: 0x4B00-0x4B4E all have had a value at some time;
don't reuse for the time being */
/* note: 0x4B60-0x4B6D, 0x4B70-0x4B72 used above */
--
2.44.0
^ permalink raw reply related
* [PATCH v5 3/3] VT: Allow to get max font width and height
From: Alexey Gladkov @ 2024-04-17 17:37 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby
Cc: LKML, kbd, linux-api, linux-fbdev, linux-serial, Helge Deller
In-Reply-To: <cover.1713375378.git.legion@kernel.org>
The Console drivers has more restrictive font size limits than vt_ioctl.
This leads to errors that are difficult to handle. If a font whose size
is not supported is used, an EINVAL error will be returned, which is
also returned in case of errors in the font itself. At the moment there
is no way to understand what font sizes the current console driver
supports.
To solve this problem, we need to transfer information about the
supported font to userspace from the console driver.
Acked-by: Helge Deller <deller@gmx.de>
Signed-off-by: Alexey Gladkov <legion@kernel.org>
---
drivers/video/console/newport_con.c | 21 +++++++++++++++++----
drivers/video/console/sticon.c | 25 +++++++++++++++++++++++--
drivers/video/console/vgacon.c | 21 ++++++++++++++++++++-
drivers/video/fbdev/core/fbcon.c | 16 ++++++++++++++++
4 files changed, 76 insertions(+), 7 deletions(-)
diff --git a/drivers/video/console/newport_con.c b/drivers/video/console/newport_con.c
index a51cfc1d560e..6167f45326ac 100644
--- a/drivers/video/console/newport_con.c
+++ b/drivers/video/console/newport_con.c
@@ -33,6 +33,9 @@
#define NEWPORT_LEN 0x10000
+#define NEWPORT_MAX_FONT_WIDTH 8
+#define NEWPORT_MAX_FONT_HEIGHT 16
+
#define FONT_DATA ((unsigned char *)font_vga_8x16.data)
static unsigned char *font_data[MAX_NR_CONSOLES];
@@ -328,8 +331,8 @@ static void newport_init(struct vc_data *vc, bool init)
{
int cols, rows;
- cols = newport_xsize / 8;
- rows = newport_ysize / 16;
+ cols = newport_xsize / NEWPORT_MAX_FONT_WIDTH;
+ rows = newport_ysize / NEWPORT_MAX_FONT_HEIGHT;
vc->vc_can_do_color = 1;
if (init) {
vc->vc_cols = cols;
@@ -507,8 +510,8 @@ static int newport_set_font(int unit, const struct console_font *op,
/* ladis: when I grow up, there will be a day... and more sizes will
* be supported ;-) */
- if ((w != 8) || (h != 16) || (vpitch != 32)
- || (op->charcount != 256 && op->charcount != 512))
+ if ((w != NEWPORT_MAX_FONT_WIDTH) || (h != NEWPORT_MAX_FONT_HEIGHT) ||
+ (vpitch != 32) || (op->charcount != 256 && op->charcount != 512))
return -EINVAL;
if (!(new_data = kmalloc(FONT_EXTRA_WORDS * sizeof(int) + size,
@@ -570,6 +573,15 @@ static int newport_font_default(struct vc_data *vc, struct console_font *op,
return newport_set_def_font(vc->vc_num, op);
}
+static int newport_font_info(struct vc_data *vc, struct console_font_info *info)
+{
+ info->min_width = info->max_width = NEWPORT_MAX_FONT_WIDTH;
+ info->min_height = info->max_height = NEWPORT_MAX_FONT_HEIGHT;
+ info->flags = KD_FONT_INFO_FLAG_LOW_SIZE | KD_FONT_INFO_FLAG_HIGH_SIZE;
+
+ return 0;
+}
+
static int newport_font_set(struct vc_data *vc, const struct console_font *font,
unsigned int vpitch, unsigned int flags)
{
@@ -689,6 +701,7 @@ const struct consw newport_con = {
.con_scroll = newport_scroll,
.con_switch = newport_switch,
.con_blank = newport_blank,
+ .con_font_info = newport_font_info,
.con_font_set = newport_font_set,
.con_font_default = newport_font_default,
.con_save_screen = newport_save_screen
diff --git a/drivers/video/console/sticon.c b/drivers/video/console/sticon.c
index 4c7b4959a1aa..490e6b266a31 100644
--- a/drivers/video/console/sticon.c
+++ b/drivers/video/console/sticon.c
@@ -56,6 +56,11 @@
#define BLANK 0
static int vga_is_gfx;
+#define STICON_MIN_FONT_WIDTH 6
+#define STICON_MIN_FONT_HEIGHT 6
+#define STICON_MAX_FONT_WIDTH 32
+#define STICON_MAX_FONT_HEIGHT 32
+
#define STI_DEF_FONT sticon_sti->font
/* borrowed from fbcon.c */
@@ -166,8 +171,10 @@ static int sticon_set_font(struct vc_data *vc, const struct console_font *op,
struct sti_cooked_font *cooked_font;
unsigned char *data = op->data, *p;
- if ((w < 6) || (h < 6) || (w > 32) || (h > 32) || (vpitch != 32)
- || (op->charcount != 256 && op->charcount != 512))
+ if (!in_range(w, STICON_MIN_FONT_WIDTH, STICON_MAX_FONT_WIDTH) ||
+ !in_range(h, STICON_MIN_FONT_HEIGHT, STICON_MAX_FONT_HEIGHT) ||
+ (vpitch != 32) ||
+ (op->charcount != 256 && op->charcount != 512))
return -EINVAL;
pitch = ALIGN(w, 8) / 8;
bpc = pitch * h;
@@ -260,6 +267,19 @@ static int sticon_font_set(struct vc_data *vc, const struct console_font *font,
return sticon_set_font(vc, font, vpitch);
}
+static int sticon_font_info(struct vc_data *vc, struct console_font_info *info)
+{
+ info->min_width = STICON_MIN_FONT_WIDTH;
+ info->min_height = STICON_MIN_FONT_HEIGHT;
+
+ info->max_width = STICON_MAX_FONT_WIDTH;
+ info->max_height = STICON_MAX_FONT_HEIGHT;
+
+ info->flags = KD_FONT_INFO_FLAG_LOW_SIZE | KD_FONT_INFO_FLAG_HIGH_SIZE;
+
+ return 0;
+}
+
static void sticon_init(struct vc_data *c, bool init)
{
struct sti_struct *sti = sticon_sti;
@@ -356,6 +376,7 @@ static const struct consw sti_con = {
.con_scroll = sticon_scroll,
.con_switch = sticon_switch,
.con_blank = sticon_blank,
+ .con_font_info = sticon_font_info,
.con_font_set = sticon_font_set,
.con_font_default = sticon_font_default,
.con_build_attr = sticon_build_attr,
diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
index 7597f04b0dc7..b5465e555fdc 100644
--- a/drivers/video/console/vgacon.c
+++ b/drivers/video/console/vgacon.c
@@ -61,6 +61,10 @@ static struct vgastate vgastate;
#define BLANK 0x0020
#define VGA_FONTWIDTH 8 /* VGA does not support fontwidths != 8 */
+
+#define VGACON_MAX_FONT_WIDTH VGA_FONTWIDTH
+#define VGACON_MAX_FONT_HEIGHT 32
+
/*
* Interface used by the world
*/
@@ -1039,6 +1043,19 @@ static int vgacon_adjust_height(struct vc_data *vc, unsigned fontheight)
return 0;
}
+static int vgacon_font_info(struct vc_data *vc, struct console_font_info *info)
+{
+ info->min_width = VGACON_MAX_FONT_WIDTH;
+ info->min_height = 0;
+
+ info->max_width = VGACON_MAX_FONT_WIDTH;
+ info->max_height = VGACON_MAX_FONT_HEIGHT;
+
+ info->flags = KD_FONT_INFO_FLAG_LOW_SIZE | KD_FONT_INFO_FLAG_HIGH_SIZE;
+
+ return 0;
+}
+
static int vgacon_font_set(struct vc_data *c, const struct console_font *font,
unsigned int vpitch, unsigned int flags)
{
@@ -1048,7 +1065,8 @@ static int vgacon_font_set(struct vc_data *c, const struct console_font *font,
if (vga_video_type < VIDEO_TYPE_EGAM)
return -EINVAL;
- if (font->width != VGA_FONTWIDTH || font->height > 32 || vpitch != 32 ||
+ if (font->width != VGACON_MAX_FONT_WIDTH ||
+ font->height > VGACON_MAX_FONT_HEIGHT || vpitch != 32 ||
(charcount != 256 && charcount != 512))
return -EINVAL;
@@ -1201,6 +1219,7 @@ const struct consw vga_con = {
.con_scroll = vgacon_scroll,
.con_switch = vgacon_switch,
.con_blank = vgacon_blank,
+ .con_font_info = vgacon_font_info,
.con_font_set = vgacon_font_set,
.con_font_get = vgacon_font_get,
.con_resize = vgacon_resize,
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index fcabc668e9fb..b54031da49fd 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@ -2452,6 +2452,21 @@ static int fbcon_do_set_font(struct vc_data *vc, int w, int h, int charcount,
return ret;
}
+
+static int fbcon_font_info(struct vc_data *vc, struct console_font_info *info)
+{
+ info->min_width = 0;
+ info->min_height = 0;
+
+ info->max_width = FB_MAX_BLIT_WIDTH;
+ info->max_height = FB_MAX_BLIT_HEIGHT;
+
+ info->flags = KD_FONT_INFO_FLAG_LOW_SIZE | KD_FONT_INFO_FLAG_HIGH_SIZE;
+
+ return 0;
+}
+
+
/*
* User asked to set font; we are guaranteed that charcount does not exceed 512
* but lets not assume that, since charcount of 512 is small for unicode support.
@@ -3127,6 +3142,7 @@ static const struct consw fb_con = {
.con_scroll = fbcon_scroll,
.con_switch = fbcon_switch,
.con_blank = fbcon_blank,
+ .con_font_info = fbcon_font_info,
.con_font_set = fbcon_set_font,
.con_font_get = fbcon_get_font,
.con_font_default = fbcon_set_def_font,
--
2.44.0
^ permalink raw reply related
* Re: [PATCH v5 2/3] VT: Add KDFONTINFO ioctl
From: Helge Deller @ 2024-04-17 19:31 UTC (permalink / raw)
To: Alexey Gladkov, Greg Kroah-Hartman, Jiri Slaby
Cc: LKML, kbd, linux-api, linux-fbdev, linux-serial
In-Reply-To: <bd2755e7b6ebe9b49e82d04d9908a176e0fe2f15.1713375378.git.legion@kernel.org>
On 4/17/24 19:37, Alexey Gladkov wrote:
> Each driver has its own restrictions on font size. There is currently no
> way to understand what the requirements are. The new ioctl allows
> userspace to get the minimum and maximum font size values.
>
> Acked-by: Helge Deller <deller@gmx.de>
> Signed-off-by: Alexey Gladkov <legion@kernel.org>
> ---
> drivers/tty/vt/vt.c | 24 ++++++++++++++++++++++++
> drivers/tty/vt/vt_ioctl.c | 13 +++++++++++++
> include/linux/console.h | 3 +++
> include/linux/vt_kern.h | 1 +
> include/uapi/linux/kd.h | 14 ++++++++++++++
> 5 files changed, 55 insertions(+)
>
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index 9b5b98dfc8b4..e8db0e9ea674 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -4851,6 +4851,30 @@ int con_font_op(struct vc_data *vc, struct console_font_op *op)
> return -ENOSYS;
> }
>
> +int con_font_info(struct vc_data *vc, struct console_font_info *info)
> +{
> + int rc;
> +
> + info->min_height = 0;
> + info->max_height = max_font_height;
> +
> + info->min_width = 0;
> + info->max_width = max_font_width;
> +
> + info->flags = KD_FONT_INFO_FLAG_LOW_SIZE | KD_FONT_INFO_FLAG_HIGH_SIZE;
> +
> + console_lock();
> + if (vc->vc_mode != KD_TEXT)
> + rc = -EINVAL;
> + else if (vc->vc_sw->con_font_info)
> + rc = vc->vc_sw->con_font_info(vc, info);
> + else
> + rc = -ENOSYS;
> + console_unlock();
> +
> + return rc;
> +}
> +
> /*
> * Interface exported to selection and vcs.
> */
> diff --git a/drivers/tty/vt/vt_ioctl.c b/drivers/tty/vt/vt_ioctl.c
> index 4b91072f3a4e..9a2f8081f650 100644
> --- a/drivers/tty/vt/vt_ioctl.c
> +++ b/drivers/tty/vt/vt_ioctl.c
> @@ -479,6 +479,19 @@ static int vt_k_ioctl(struct tty_struct *tty, unsigned int cmd,
> break;
> }
>
> + case KDFONTINFO: {
> + struct console_font_info fnt_info;
> +
> + memset(&fnt_info, 0, sizeof(fnt_info));
> +
> + ret = con_font_info(vc, &fnt_info);
> + if (ret)
> + return ret;
> + if (copy_to_user(up, &fnt_info, sizeof(fnt_info)))
> + return -EFAULT;
> + break;
> + }
> +
> default:
> return -ENOIOCTLCMD;
> }
> diff --git a/include/linux/console.h b/include/linux/console.h
> index 31a8f5b85f5d..4b798322aa01 100644
> --- a/include/linux/console.h
> +++ b/include/linux/console.h
> @@ -21,6 +21,7 @@
> #include <linux/vesa.h>
>
> struct vc_data;
> +struct console_font_info;
> struct console_font_op;
> struct console_font;
> struct module;
> @@ -102,6 +103,8 @@ struct consw {
> bool (*con_switch)(struct vc_data *vc);
> bool (*con_blank)(struct vc_data *vc, enum vesa_blank_mode blank,
> bool mode_switch);
> + int (*con_font_info)(struct vc_data *vc,
> + struct console_font_info *info);
> int (*con_font_set)(struct vc_data *vc,
> const struct console_font *font,
> unsigned int vpitch, unsigned int flags);
> diff --git a/include/linux/vt_kern.h b/include/linux/vt_kern.h
> index d008c3d0a9bb..383b3a4f6113 100644
> --- a/include/linux/vt_kern.h
> +++ b/include/linux/vt_kern.h
> @@ -33,6 +33,7 @@ void do_blank_screen(int entering_gfx);
> void do_unblank_screen(int leaving_gfx);
> void poke_blanked_console(void);
> int con_font_op(struct vc_data *vc, struct console_font_op *op);
> +int con_font_info(struct vc_data *vc, struct console_font_info *info);
> int con_set_cmap(unsigned char __user *cmap);
> int con_get_cmap(unsigned char __user *cmap);
> void scrollback(struct vc_data *vc);
> diff --git a/include/uapi/linux/kd.h b/include/uapi/linux/kd.h
> index 8ddb2219a84b..68b715ad4d5c 100644
> --- a/include/uapi/linux/kd.h
> +++ b/include/uapi/linux/kd.h
> @@ -185,6 +185,20 @@ struct console_font {
>
> #define KD_FONT_FLAG_DONT_RECALC 1 /* Don't recalculate hw charcell size [compat] */
>
> +/* font information */
> +
> +#define KD_FONT_INFO_FLAG_LOW_SIZE _BITUL(0) /* 256 */
> +#define KD_FONT_INFO_FLAG_HIGH_SIZE _BITUL(1) /* 512 */
Do we really need those bits?
You set a default min/max font size in con_font_info() above,
and all drivers can override those values.
So, there are always min/max sizes available.
> +struct console_font_info {
> + __u32 flags; /* KD_FONT_INFO_FLAG_* */
One space too much in front of "flags" ?
> + __u32 min_width, min_height; /* minimal font size */
> + __u32 max_width, max_height; /* maximum font size */
> + __u32 reserved[5]; /* This field is reserved for future use. Must be 0. */
> +};
> +
> +#define KDFONTINFO _IOR(KD_IOCTL_BASE, 0x73, struct console_font_info)
> +
> /* note: 0x4B00-0x4B4E all have had a value at some time;
> don't reuse for the time being */
> /* note: 0x4B60-0x4B6D, 0x4B70-0x4B72 used above */
^ permalink raw reply
* Re: [PATCH v4 00/30] NT synchronization primitive driver
From: Elizabeth Figura @ 2024-04-17 20:02 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Arnd Bergmann, Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan,
linux-kernel, linux-api, wine-devel, André Almeida,
Wolfram Sang, Arkadiusz Hiler, Andy Lutomirski, linux-doc,
linux-kselftest, Randy Dunlap, Ingo Molnar, Will Deacon,
Waiman Long, Boqun Feng
In-Reply-To: <20240417100132.GK30852@noisy.programming.kicks-ass.net>
On Wednesday, 17 April 2024 05:01:32 CDT Peter Zijlstra wrote:
> >
> > ===================================
> > NT synchronization primitive driver
> > ===================================
> >
> > This page documents the user-space API for the ntsync driver.
> >
> > ntsync is a support driver for emulation of NT synchronization
> > primitives by user-space NT emulators. It exists because implementation
> > in user-space, using existing tools, cannot match Windows performance
> > while offering accurate semantics. It is implemented entirely in
> > software, and does not drive any hardware device.
> >
> > This interface is meant as a compatibility tool only, and should not
> > be used for general synchronization. Instead use generic, versatile
> > interfaces such as futex(2) and poll(2).
> >
> > Synchronization primitives
> > ==========================
> >
> > The ntsync driver exposes three types of synchronization primitives:
> > semaphores, mutexes, and events.
> >
> > A semaphore holds a single volatile 32-bit counter, and a static 32-bit
> > integer denoting the maximum value. It is considered signaled when the
> > counter is nonzero. The counter is decremented by one when a wait is
> > satisfied. Both the initial and maximum count are established when the
> > semaphore is created.
> >
> > A mutex holds a volatile 32-bit recursion count, and a volatile 32-bit
> > identifier denoting its owner. A mutex is considered signaled when its
> > owner is zero (indicating that it is not owned). The recursion count is
> > incremented when a wait is satisfied, and ownership is set to the given
> > identifier.
>
> 'signaled' is used twice now but not defined. For both Semaphore and
> Mutex this seems to indicate uncontended? Edit: seems to be needs-wakeup
> more than uncontended.
Uncontended, yes, or needs-wakeup (I'm not sure what the difference
between the two is?)
> > A mutex also holds an internal flag denoting whether its previous owner
> > has died; such a mutex is said to be abandoned. Owner death is not
> > tracked automatically based on thread death, but rather must be
> > communicated using NTSYNC_IOC_MUTEX_KILL. An abandoned mutex is
> > inherently considered unowned.
> >
> > Except for the "unowned" semantics of zero, the actual value of the
> > owner identifier is not interpreted by the ntsync driver at all. The
> > intended use is to store a thread identifier; however, the ntsync
> > driver does not actually validate that a calling thread provides
> > consistent or unique identifiers.
>
> Why not verify it? Seems simple enough to put in a TID check, esp. if NT
> mandates the same.
I mostly figured it'd be simplest to leave the driver completely
agnostic, but I don't think there's any reason we can't use the real
TID for most calls.
> > An event holds a volatile boolean state denoting whether it is signaled
> > or not. There are two types of events, auto-reset and manual-reset. An
> > auto-reset event is designaled when a wait is satisfied; a manual-reset
> > event is not. The event type is specified when the event is created.
>
> But what is an event? I'm familiar with semaphores and mutexes, but less
> so with events.
It's what I'm trying to define there, a single bit of state that's
either contended or not. It acts broadly like an eventfd, in that you
can wake (write) or wait (read), but without the distinction of having
different nonzero values in the internal counter.
You could also think of it as a semaphore with a maximum count of one.
However, unlike a semaphore it also supports the "pulse" operation, and
you can also have "manual-reset" events that *don't* change state when
you wait on them (no equivalent for regular semaphores).
> > Unless specified otherwise, all operations on an object are atomic and
> > totally ordered with respect to other operations on the same object.
> >
> > Objects are represented by files. When all file descriptors to an
> > object are closed, that object is deleted.
> >
> > Char device
> > ===========
> >
> > The ntsync driver creates a single char device /dev/ntsync. Each file
> > description opened on the device represents a unique instance intended
> > to back an individual NT virtual machine. Objects created by one ntsync
> > instance may only be used with other objects created by the same
> > instance.
> >
> > ioctl reference
> > ===============
> >
> > All operations on the device are done through ioctls. There are four
> > structures used in ioctl calls::
> >
> > struct ntsync_sem_args {
> > __u32 sem;
> > __u32 count;
> > __u32 max;
> > };
> >
> > struct ntsync_mutex_args {
> > __u32 mutex;
> > __u32 owner;
> > __u32 count;
> > };
> >
> > struct ntsync_event_args {
> > __u32 event;
> > __u32 signaled;
> > __u32 manual;
> > };
> >
> > struct ntsync_wait_args {
> > __u64 timeout;
> > __u64 objs;
> > __u32 count;
> > __u32 owner;
> > __u32 index;
> > __u32 alert;
> > __u32 flags;
> > __u32 pad;
> > };
> >
> > Depending on the ioctl, members of the structure may be used as input,
> > output, or not at all. All ioctls return 0 on success.
> >
> > The ioctls on the device file are as follows:
> >
> > NTSYNC_IOC_CREATE_SEM
> >
> > Create a semaphore object. Takes a pointer to struct ntsync_sem_args,
> > which is used as follows:
> >
> > * sem: On output, contains a file descriptor to the created semaphore.
> > * count: Initial count of the semaphore.
> > * max: Maximum count of the semaphore.
> >
> > Fails with EINVAL if `count` is greater than `max`.
>
> So the implication is that @count and @max are input argument and as
> such should be set before calling the ioctl()?
>
> It would not have been weird to have the ioctl() return the fd on
> success I suppose, instead of mixing input and output arguments like
> this, but whatever, this works.
I think that would have been fine, and I could still change it
accordingly. The reason I didn't do that was that [1] advises against
it (although I don't know why).
[1] https://docs.kernel.org/driver-api/ioctl.html#return-code
> > The ioctls on the individual objects are as follows:
> >
> > NTSYNC_IOC_SEM_POST
> >
> > Post to a semaphore object. Takes a pointer to a 32-bit integer,
> > which on input holds the count to be added to the semaphore, and on
> > output contains its previous count.
> >
> > If adding to the semaphore's current count would raise the latter
> > past the semaphore's maximum count, the ioctl fails with
> > EOVERFLOW and the semaphore is not affected. If raising the
> > semaphore's count causes it to become signaled, eligible threads
> > waiting on this semaphore will be woken and the semaphore's count
> > decremented appropriately.
>
> Urg, so this is the traditional V (vrijgeven per Dijkstra, release in
> English), but now 'conveniently' called POST, such that it can be
> readily confused with the P operation (passering, or passing) which it
> is not.
>
> Glorious :-/
>
> You're of course going to tell me NT did this and you can't help this
> naming foible.
No, NT calls it "release" (and the operation on a mutex is also
"release" rather than "unlock".) I called it "post" after POSIX
semaphores, on the idea that it'd be more familiar to a Unix developer
(and shorter). I see I was wrong, so I'll rename it to "release".
> > NTSYNC_IOC_MUTEX_UNLOCK
> >
> > Release a mutex object. Takes a pointer to struct ntsync_mutex_args,
> > which is used as follows:
> >
> > * mutex: Ignored.
> > * owner: Specifies the owner trying to release this mutex.
> > * count: On output, contains the previous recursion count.
> >
> > If "owner" is zero, the ioctl fails with EINVAL. If "owner"
> > is not the current owner of the mutex, the ioctl fails with
> > EPERM.
>
> ISTR you having written elsewhere that NT actually demands mutexes to be
> strictly per thread, which for the above would mandate @owner to be
> current, no?
Right. We could replace owner with current everywhere except for
NTSYNC_IOC_KILL_OWNER.
> > The mutex's count will be decremented by one. If decrementing the
> > mutex's count causes it to become zero, the mutex is marked as
> > unowned and signaled, and eligible threads waiting on it will be
> > woken as appropriate.
> >
> > NTSYNC_IOC_SET_EVENT
> >
> > Signal an event object. Takes a pointer to a 32-bit integer, which on
> > output contains the previous state of the event.
> >
> > Eligible threads will be woken, and auto-reset events will be
> > designaled appropriately.
>
> Hmm, so the event thing is like a simple wait-wake scheme? Where the
> 'signaled' bit is used as the wakeup state?
Yes, exactly.
> > NTSYNC_IOC_RESET_EVENT
> >
> > Designal an event object. Takes a pointer to a 32-bit integer, which
> > on output contains the previous state of the event.
> >
> > NTSYNC_IOC_PULSE_EVENT
> >
> > Wake threads waiting on an event object while leaving it in an
> > unsignaled state. Takes a pointer to a 32-bit integer, which on
> > output contains the previous state of the event.
> >
> > A pulse operation can be thought of as a set followed by a reset,
> > performed as a single atomic operation. If two threads are waiting on
> > an auto-reset event which is pulsed, only one will be woken. If two
> > threads are waiting a manual-reset event which is pulsed, both will
> > be woken. However, in both cases, the event will be unsignaled
> > afterwards, and a simultaneous read operation will always report the
> > event as unsignaled.
>
> *groan*
Yep :D
This one is terrible, and it's the only one that Microsoft has come out
and explicitly said "don't use this". Supposedly their kernel is even
coded such that if a waiting thread gets hit by an interrupt that the
pulse will go unnoticed, although I've tried to reproduce this in
practice and been unsuccessful.
But of course it's terrible regardless, because you never know if your
thread is waiting or not. In practice it seems to usually be used on a
timer, though, so that part doesn't matter as much.
> > NTSYNC_IOC_READ_SEM
> >
> > Read the current state of a semaphore object. Takes a pointer to
> > struct ntsync_sem_args, which is used as follows:
> >
> > * sem: Ignored.
> > * count: On output, contains the current count of the semaphore.
> > * max: On output, contains the maximum count of the semaphore.
>
> This seems inherently racy -- what is the intended purpose of this
> interface?
>
> Specifically the moment a value is returned, either P or V operations
> can change it, rendering the (as yet unused) return value incorrect.
I have no idea what it's intended for. Actually it's not even exposed
as a documented API, only an undocumented one. But it does work, and
applications use it.
> > NTSYNC_IOC_READ_MUTEX
> >
> > Read the current state of a mutex object. Takes a pointer to struct
> > ntsync_mutex_args, which is used as follows:
> >
> > * mutex: Ignored.
> > * owner: On output, contains the current owner of the mutex, or zero
> > if the mutex is not currently owned.
> > * count: On output, contains the current recursion count of the mutex.
> >
> > If the mutex is marked as abandoned, the function fails with
> > EOWNERDEAD. In this case, "count" and "owner" are set to zero.
>
> Another questionable interface. I suspect you're going to be telling me
> NT has them so you have to have them, but urgh.
Unfortunately yes.
> > NTSYNC_IOC_READ_EVENT
> >
> > Read the current state of an event object. Takes a pointer to struct
> > ntsync_event_args, which is used as follows:
> >
> > * event: Ignored.
> > * signaled: On output, contains the current state of the event.
> > * manual: On output, contains 1 if the event is a manual-reset event,
> > and 0 otherwise.
>
> I can't help but notice all those @sem, @mutex, @event 'output' members
> being unused except for create. Seems like a waste to have them.
Yes, mostly so I could reuse the existing structures.
On the other hand if there's no reason not to return fds from the
create ioctls, then we could just remove those members.
> > NTSYNC_IOC_KILL_OWNER
> >
> > Mark a mutex as unowned and abandoned if it is owned by the given
> > owner. Takes an input-only pointer to a 32-bit integer denoting the
> > owner. If the owner is zero, the ioctl fails with EINVAL. If the
> > owner does not own the mutex, the function fails with EPERM.
> >
> > Eligible threads waiting on the mutex will be woken as appropriate
> > (and such waits will fail with EOWNERDEAD, as described below).
>
> Wine will use this when it detects a thread exit I suppose.
Exactly.
> > NTSYNC_IOC_WAIT_ANY
> >
> > Poll on any of a list of objects, atomically acquiring at most one.
> > Takes a pointer to struct ntsync_wait_args, which is used as follows:
> >
> > * timeout: Absolute timeout in nanoseconds. If NTSYNC_WAIT_REALTIME
> > is set, the timeout is measured against the REALTIME
> > clock; otherwise it is measured against the MONOTONIC
> > clock. If the timeout is equal to or earlier than the
> > current time, the function returns immediately without
> > sleeping. If "timeout" is U64_MAX, the function will
> > sleep until an object is signaled, and will not fail
> > with ETIMEDOUT.
> >
> > * objs: Pointer to an array of "count" file descriptors
> > (specified as an integer so that the structure has the
> > same size regardless of architecture). If any object is
> > invalid, the function fails with EINVAL.
> >
> > * count: Number of objects specified in the "objs" array. If
> > greater than NTSYNC_MAX_WAIT_COUNT, the function fails
> > with EINVAL.
> >
> > * owner: Mutex owner identifier. If any object in "objs" is a
> > mutex, the ioctl will attempt to acquire that mutex on
> > behalf of "owner". If "owner" is zero, the ioctl
> > fails with EINVAL.
>
> Again, should that not be current? That is, why not maintain the NT
> invariant and mandates TIDs and avoid the arguments in both cases?
I don't think there's any particular reason.
> > * index: On success, contains the index (into "objs") of the
> > object which was signaled. If "alert" was signaled
> > instead, this contains "count".
>
> Could be the actual return value, no? Edit: no it cannot be because
> -EOWNERDEAD case below.
Yeah. Again the advice about "only return zero from an ioctl", too.
Although we could also use a bit in the return value (which is also
kind of what NT does).
> > A semaphore is considered to be signaled if its count is nonzero, and
> > is acquired by decrementing its count by one. A mutex is considered
> > to be signaled if it is unowned or if its owner matches the "owner"
> > argument, and is acquired by incrementing its recursion count by one
> > and setting its owner to the "owner" argument. An auto-reset event
> > is acquired by designaling it; a manual-reset event is not affected
> > by acquisition.
> >
> > Acquisition is atomic and totally ordered with respect to other
> > operations on the same object. If two wait operations (with different
> > "owner" identifiers) are queued on the same mutex, only one is
> > signaled. If two wait operations are queued on the same semaphore,
> > and a value of one is posted to it, only one is signaled. The order
> > in which threads are signaled is not specified.
>
> Note that you do list the lack of guarantee here, but not above. I
> suspect both cases are similar and guarantee nothing.
There's no documented guarantee in either case, but when testing in
controlled well-ordered environments, NtWaitForMultipleObjects() always
acquires the lowest index first, and I think wakes are FIFO. I'm not
really sure why I specified the guarantee for the former but not the
latter.
> > The "alert" argument is an "extra" event which can terminate the
> > wait, independently of all other objects. If members of "objs" and
> > "alert" are both simultaneously signaled, a member of "objs" will
> > always be given priority and acquired first.
> >
> > It is valid to pass the same object more than once, including by
> > passing the same event in the "objs" array and in "alert". If a
> > wakeup occurs due to that object being signaled, "index" is set to
> > the lowest index corresponding to that object.
>
> Urgh, is this an actual guarantee? This almost seems to imply that at
> [A] above we can indeed guarantee the lowest indexed object is acquired
> first.
It's definitely legal in NT to pass the same object more than once (in
wait-for-any, not wait-for-all though), and it's definitely the case
that (at least in controlled well-ordered environments) the lowest
index is acquired first. I don't know of any application that
definitely depends on either of these, and they're not documented
behaviours, but Wine has implemented those behaviours and it would make
me nervous to break them here.
The part about passing the same event in "alert" and "objs" is not part
of NT exactly (in NT the "alert" isn't even an event; it's a special
bit of thread state; we just use an event for simplicity). I think I
specified it just to avoid coding an extra check (since it should Just
Work), while also making it clear that case was considered.
> > The function may fail with EINTR if a signal is received.
>
> In which case @index must be disregarded since nothing will be acquired,
> right?
>
> So far nothing really weird, and I'm thinking futexes should be able to
> do all this, no?
Even disregarding wait-for-all, futexes aren't really good enough. Wait
operations need to consume state, and while we could put that state in
user space (and in fact we *do* have an out of tree patch set that kind
of does this) that requires all that state to be shared across
processes, which is a problem since we want processes to be isolated
unless they explicitly share objects with each other. There's not
a scalable way to achieve this, especially since you can share objects
lazily.
You also cannot do NtPulseEvent() this way. The aforementioned patch
set badly emulates it and it does in practice break any application
that uses it. Similarly there are some applications that do a weird
"fake pulse" where they set and then immediately reset an event from
the same thread, and expect that to always wake.
^ permalink raw reply
* Re: [PATCH v4 02/27] ntsync: Introduce NTSYNC_IOC_WAIT_ALL.
From: Elizabeth Figura @ 2024-04-17 20:03 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Arnd Bergmann, Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan,
linux-kernel, linux-api, wine-devel, André Almeida,
Wolfram Sang, Arkadiusz Hiler, Andy Lutomirski, linux-doc,
linux-kselftest, Randy Dunlap, Ingo Molnar, Will Deacon,
Waiman Long, Boqun Feng
In-Reply-To: <20240417113703.GL30852@noisy.programming.kicks-ass.net>
On Wednesday, 17 April 2024 06:37:03 CDT Peter Zijlstra wrote:
> On Mon, Apr 15, 2024 at 08:08:12PM -0500, Elizabeth Figura wrote:
> > + if (atomic_read(&sem->all_hint) > 0) {
> > + spin_lock(&dev->wait_all_lock);
> > + spin_lock_nest_lock(&sem->lock, &dev->wait_all_lock);
> >
> > + prev_count = sem->u.sem.count;
> > + ret = post_sem_state(sem, args);
> > + if (!ret) {
> > + try_wake_all_obj(dev, sem);
> > + try_wake_any_sem(sem);
> > + }
> >
> > + spin_unlock(&sem->lock);
> > + spin_unlock(&dev->wait_all_lock);
> > + } else {
> > + spin_lock(&sem->lock);
> > +
> > + prev_count = sem->u.sem.count;
> > + ret = post_sem_state(sem, args);
> > + if (!ret)
> > + try_wake_any_sem(sem);
> > +
> > + spin_unlock(&sem->lock);
> > + }
> >
> > if (!ret && put_user(prev_count, user_args))
> > ret = -EFAULT;
>
> vs.
>
> > + /* queue ourselves */
> > +
> > + spin_lock(&dev->wait_all_lock);
> > +
> > + for (i = 0; i < args.count; i++) {
> > + struct ntsync_q_entry *entry = &q->entries[i];
> > + struct ntsync_obj *obj = entry->obj;
> > +
> > + atomic_inc(&obj->all_hint);
> > +
> > + /*
> > + * obj->all_waiters is protected by dev->wait_all_lock rather
> > + * than obj->lock, so there is no need to acquire obj->lock
> > + * here.
> > + */
> > + list_add_tail(&entry->node, &obj->all_waiters);
> > + }
>
> This looks racy, consider:
>
> atomic_read(all_hints) /* 0 */
>
> spin_lock(wait_all_lock)
> atomic_inc(all_hint) /* 1 */
> list_add_tail()
>
> spin_lock(sem->lock)
> /* try_wake_all_obj() missing */
>
>
>
>
> I've not yet thought about if this is harmful or not, but if not, it
> definitely needs a comment.
>
> Anyway, I need a break, maybe more this evening.
Ach. I wrote this with the idea that the race isn't meaningful, but
looking at it again you're right—there is a harmful race here.
I think it should be fixable by moving the atomic_read inside the lock,
though.
^ permalink raw reply
* Re: [PATCH v5 2/3] VT: Add KDFONTINFO ioctl
From: Greg Kroah-Hartman @ 2024-04-18 6:18 UTC (permalink / raw)
To: Alexey Gladkov
Cc: Jiri Slaby, LKML, kbd, linux-api, linux-fbdev, linux-serial,
Helge Deller
In-Reply-To: <bd2755e7b6ebe9b49e82d04d9908a176e0fe2f15.1713375378.git.legion@kernel.org>
On Wed, Apr 17, 2024 at 07:37:36PM +0200, Alexey Gladkov wrote:
> Each driver has its own restrictions on font size. There is currently no
> way to understand what the requirements are. The new ioctl allows
> userspace to get the minimum and maximum font size values.
Is there any userspace code that uses this yet that we can point to
here?
I know tty ioctls are woefully undocumented, but could there be some
documentation here?
>
> Acked-by: Helge Deller <deller@gmx.de>
> Signed-off-by: Alexey Gladkov <legion@kernel.org>
> ---
> drivers/tty/vt/vt.c | 24 ++++++++++++++++++++++++
> drivers/tty/vt/vt_ioctl.c | 13 +++++++++++++
> include/linux/console.h | 3 +++
> include/linux/vt_kern.h | 1 +
> include/uapi/linux/kd.h | 14 ++++++++++++++
> 5 files changed, 55 insertions(+)
>
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index 9b5b98dfc8b4..e8db0e9ea674 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -4851,6 +4851,30 @@ int con_font_op(struct vc_data *vc, struct console_font_op *op)
> return -ENOSYS;
> }
>
> +int con_font_info(struct vc_data *vc, struct console_font_info *info)
> +{
> + int rc;
> +
> + info->min_height = 0;
> + info->max_height = max_font_height;
> +
> + info->min_width = 0;
> + info->max_width = max_font_width;
> +
> + info->flags = KD_FONT_INFO_FLAG_LOW_SIZE | KD_FONT_INFO_FLAG_HIGH_SIZE;
> +
> + console_lock();
> + if (vc->vc_mode != KD_TEXT)
> + rc = -EINVAL;
> + else if (vc->vc_sw->con_font_info)
> + rc = vc->vc_sw->con_font_info(vc, info);
> + else
> + rc = -ENOSYS;
> + console_unlock();
> +
> + return rc;
> +}
> +
> /*
> * Interface exported to selection and vcs.
> */
> diff --git a/drivers/tty/vt/vt_ioctl.c b/drivers/tty/vt/vt_ioctl.c
> index 4b91072f3a4e..9a2f8081f650 100644
> --- a/drivers/tty/vt/vt_ioctl.c
> +++ b/drivers/tty/vt/vt_ioctl.c
> @@ -479,6 +479,19 @@ static int vt_k_ioctl(struct tty_struct *tty, unsigned int cmd,
> break;
> }
>
> + case KDFONTINFO: {
> + struct console_font_info fnt_info;
> +
> + memset(&fnt_info, 0, sizeof(fnt_info));
> +
> + ret = con_font_info(vc, &fnt_info);
Shouldn't con_font_info() memset it first? No need to do it in the
caller.
> + if (ret)
> + return ret;
> + if (copy_to_user(up, &fnt_info, sizeof(fnt_info)))
> + return -EFAULT;
> + break;
> + }
> +
> default:
> return -ENOIOCTLCMD;
> }
> diff --git a/include/linux/console.h b/include/linux/console.h
> index 31a8f5b85f5d..4b798322aa01 100644
> --- a/include/linux/console.h
> +++ b/include/linux/console.h
> @@ -21,6 +21,7 @@
> #include <linux/vesa.h>
>
> struct vc_data;
> +struct console_font_info;
> struct console_font_op;
> struct console_font;
> struct module;
> @@ -102,6 +103,8 @@ struct consw {
> bool (*con_switch)(struct vc_data *vc);
> bool (*con_blank)(struct vc_data *vc, enum vesa_blank_mode blank,
> bool mode_switch);
> + int (*con_font_info)(struct vc_data *vc,
> + struct console_font_info *info);
To make the names more obvious, how about:
con_font_info_get()?
> int (*con_font_set)(struct vc_data *vc,
> const struct console_font *font,
> unsigned int vpitch, unsigned int flags);
> diff --git a/include/linux/vt_kern.h b/include/linux/vt_kern.h
> index d008c3d0a9bb..383b3a4f6113 100644
> --- a/include/linux/vt_kern.h
> +++ b/include/linux/vt_kern.h
> @@ -33,6 +33,7 @@ void do_blank_screen(int entering_gfx);
> void do_unblank_screen(int leaving_gfx);
> void poke_blanked_console(void);
> int con_font_op(struct vc_data *vc, struct console_font_op *op);
> +int con_font_info(struct vc_data *vc, struct console_font_info *info);
> int con_set_cmap(unsigned char __user *cmap);
> int con_get_cmap(unsigned char __user *cmap);
> void scrollback(struct vc_data *vc);
> diff --git a/include/uapi/linux/kd.h b/include/uapi/linux/kd.h
> index 8ddb2219a84b..68b715ad4d5c 100644
> --- a/include/uapi/linux/kd.h
> +++ b/include/uapi/linux/kd.h
> @@ -185,6 +185,20 @@ struct console_font {
>
> #define KD_FONT_FLAG_DONT_RECALC 1 /* Don't recalculate hw charcell size [compat] */
>
> +/* font information */
> +
> +#define KD_FONT_INFO_FLAG_LOW_SIZE _BITUL(0) /* 256 */
> +#define KD_FONT_INFO_FLAG_HIGH_SIZE _BITUL(1) /* 512 */
I don't understand why bit 0 and bit 1 have those comments after them.
That's confusing (i.e. bit 0 is NOT 256...)
> +
> +struct console_font_info {
> + __u32 flags; /* KD_FONT_INFO_FLAG_* */
Why are there flags if you are only setting these 2 values? What are
the flags for?
If this is going to be a "multiplexed" type of structure, then make it a
union? Or maybe we are totally over thinking this whole thing.
All you want is the min/max font size of the console, right? So perhaps
the whole structure is just:
> + __u32 min_width, min_height; /* minimal font size */
> + __u32 max_width, max_height; /* maximum font size */
Those 4 variables? Why have anything else here at all? For any new
thing you wish to discover, have it be a new ioctl?
> + __u32 reserved[5]; /* This field is reserved for future use. Must be 0. */
I understand the "must be 0" but this is a read-only structure, so
saying "it will be set to 0" might be better?" Or something like that?
> +};
> +
> +#define KDFONTINFO _IOR(KD_IOCTL_BASE, 0x73, struct console_font_info)
As mentioned above how about KDFONTINFOGET?
thanks,
greg k-h
^ permalink raw reply
* Re: [PATCH v5 1/3] VT: Use macros to define ioctls
From: Greg Kroah-Hartman @ 2024-04-18 6:18 UTC (permalink / raw)
To: Alexey Gladkov
Cc: Jiri Slaby, LKML, kbd, linux-api, linux-fbdev, linux-serial
In-Reply-To: <e4229fe2933a003341e338b558ab1ea8b63a51f6.1713375378.git.legion@kernel.org>
On Wed, Apr 17, 2024 at 07:37:35PM +0200, Alexey Gladkov wrote:
> All other headers use _IOC() macros to describe ioctls for a long time
> now. This header is stuck in the last century.
>
> Simply use the _IO() macro. No other changes.
>
> Signed-off-by: Alexey Gladkov <legion@kernel.org>
> ---
> include/uapi/linux/kd.h | 96 +++++++++++++++++++++--------------------
> 1 file changed, 49 insertions(+), 47 deletions(-)
This is a nice cleanup, thanks for doing it, I'll just take this one
change now if you don't object.
thanks,
greg k-h
^ permalink raw reply
* Re: [PATCH v4 02/27] ntsync: Introduce NTSYNC_IOC_WAIT_ALL.
From: Peter Zijlstra @ 2024-04-18 9:35 UTC (permalink / raw)
To: Elizabeth Figura
Cc: Arnd Bergmann, Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan,
linux-kernel, linux-api, wine-devel, André Almeida,
Wolfram Sang, Arkadiusz Hiler, Andy Lutomirski, linux-doc,
linux-kselftest, Randy Dunlap, Ingo Molnar, Will Deacon,
Waiman Long, Boqun Feng
In-Reply-To: <3479054.QJadu78ljV@camazotz>
On Wed, Apr 17, 2024 at 03:03:05PM -0500, Elizabeth Figura wrote:
> Ach. I wrote this with the idea that the race isn't meaningful, but
> looking at it again you're right—there is a harmful race here.
>
> I think it should be fixable by moving the atomic_read inside the lock,
> though.
Right, I've ended up with the (as yet untested) below. I'll see if I can
find time later to actually test things.
---
--- a/drivers/misc/ntsync.c
+++ b/drivers/misc/ntsync.c
@@ -18,6 +18,7 @@
#include <linux/sched/signal.h>
#include <linux/slab.h>
#include <linux/spinlock.h>
+#include <linux/mutex.h>
#include <uapi/linux/ntsync.h>
#define NTSYNC_NAME "ntsync"
@@ -43,6 +44,7 @@ enum ntsync_type {
struct ntsync_obj {
spinlock_t lock;
+ int dev_locked;
enum ntsync_type type;
@@ -132,7 +134,7 @@ struct ntsync_device {
* wait_all_lock is taken first whenever multiple objects must be locked
* at the same time.
*/
- spinlock_t wait_all_lock;
+ struct mutex wait_all_lock;
struct file *file;
};
@@ -157,6 +159,56 @@ static bool is_signaled(struct ntsync_ob
}
/*
+ * XXX write coherent comment on the locking
+ */
+
+static void dev_lock_obj(struct ntsync_device *dev, struct ntsync_obj *obj)
+{
+ lockdep_assert_held(&dev->wait_all_lock);
+ WARN_ON_ONCE(obj->dev != dev);
+ spin_lock(&obj->lock);
+ obj->dev_locked = 1;
+ spin_unlock(&obj->lock);
+}
+
+static void dev_unlock_obj(struct ntsync_device *dev, struct ntsync_obj *obj)
+{
+ lockdep_assert_held(&dev->wait_all_lock);
+ WARN_ON_ONCE(obj->dev != dev);
+ spin_lock(&obj->lock);
+ obj->dev_locked = 0;
+ spin_unlock(&obj->lock);
+}
+
+static void obj_lock(struct ntsync_obj *obj)
+{
+ struct ntsync_device *dev = obj->dev;
+
+ for (;;) {
+ spin_lock(&obj->lock);
+ if (likely(!obj->dev_locked))
+ break;
+
+ spin_unlock(&obj->lock);
+ mutex_lock(&dev->wait_all_lock);
+ spin_lock(&obj->lock);
+ /*
+ * obj->dev_locked should be set and released under the same
+ * wait_all_lock section, since we now own this lock, it should
+ * be clear.
+ */
+ WARN_ON_ONCE(obj->dev_locked);
+ spin_unlock(&obj->lock);
+ mutex_unlock(&dev->wait_all_lock);
+ }
+}
+
+static void obj_unlock(struct ntsync_obj *obj)
+{
+ spin_unlock(&obj->lock);
+}
+
+/*
* "locked_obj" is an optional pointer to an object which is already locked and
* should not be locked again. This is necessary so that changing an object's
* state and waking it can be a single atomic operation.
@@ -175,7 +227,7 @@ static void try_wake_all(struct ntsync_d
for (i = 0; i < count; i++) {
if (q->entries[i].obj != locked_obj)
- spin_lock_nest_lock(&q->entries[i].obj->lock, &dev->wait_all_lock);
+ dev_lock_obj(dev, q->entries[i].obj);
}
for (i = 0; i < count; i++) {
@@ -211,7 +263,7 @@ static void try_wake_all(struct ntsync_d
for (i = 0; i < count; i++) {
if (q->entries[i].obj != locked_obj)
- spin_unlock(&q->entries[i].obj->lock);
+ dev_unlock_obj(dev, q->entries[i].obj);
}
}
@@ -231,6 +283,7 @@ static void try_wake_any_sem(struct ntsy
struct ntsync_q_entry *entry;
lockdep_assert_held(&sem->lock);
+ WARN_ON_ONCE(sem->type != NTSYNC_TYPE_SEM);
list_for_each_entry(entry, &sem->any_waiters, node) {
struct ntsync_q *q = entry->q;
@@ -251,6 +304,7 @@ static void try_wake_any_mutex(struct nt
struct ntsync_q_entry *entry;
lockdep_assert_held(&mutex->lock);
+ WARN_ON_ONCE(mutex->type != NTSYNC_TYPE_MUTEX);
list_for_each_entry(entry, &mutex->any_waiters, node) {
struct ntsync_q *q = entry->q;
@@ -302,6 +356,7 @@ static int post_sem_state(struct ntsync_
__u32 sum;
lockdep_assert_held(&sem->lock);
+ WARN_ON_ONCE(sem->type != NTSYNC_TYPE_SEM);
if (check_add_overflow(sem->u.sem.count, count, &sum) ||
sum > sem->u.sem.max)
@@ -316,6 +371,7 @@ static int ntsync_sem_post(struct ntsync
struct ntsync_device *dev = sem->dev;
__u32 __user *user_args = argp;
__u32 prev_count;
+ bool all = false;
__u32 args;
int ret;
@@ -325,28 +381,27 @@ static int ntsync_sem_post(struct ntsync
if (sem->type != NTSYNC_TYPE_SEM)
return -EINVAL;
- if (atomic_read(&sem->all_hint) > 0) {
- spin_lock(&dev->wait_all_lock);
- spin_lock_nest_lock(&sem->lock, &dev->wait_all_lock);
-
- prev_count = sem->u.sem.count;
- ret = post_sem_state(sem, args);
- if (!ret) {
+ obj_lock(sem);
+ all = atomic_read(&sem->all_hint);
+ if (unlikely(all)) {
+ obj_unlock(sem);
+ mutex_lock(&dev->wait_all_lock);
+ dev_lock_obj(dev, sem);
+ }
+
+ prev_count = sem->u.sem.count;
+ ret = post_sem_state(sem, args);
+ if (!ret) {
+ if (all)
try_wake_all_obj(dev, sem);
- try_wake_any_sem(sem);
- }
+ try_wake_any_sem(sem);
+ }
- spin_unlock(&sem->lock);
- spin_unlock(&dev->wait_all_lock);
+ if (all) {
+ dev_unlock_obj(dev, sem);
+ mutex_unlock(&dev->wait_all_lock);
} else {
- spin_lock(&sem->lock);
-
- prev_count = sem->u.sem.count;
- ret = post_sem_state(sem, args);
- if (!ret)
- try_wake_any_sem(sem);
-
- spin_unlock(&sem->lock);
+ obj_unlock(sem);
}
if (!ret && put_user(prev_count, user_args))
@@ -376,6 +431,7 @@ static int ntsync_mutex_unlock(struct nt
struct ntsync_mutex_args __user *user_args = argp;
struct ntsync_device *dev = mutex->dev;
struct ntsync_mutex_args args;
+ bool all = false;
__u32 prev_count;
int ret;
@@ -387,28 +443,27 @@ static int ntsync_mutex_unlock(struct nt
if (mutex->type != NTSYNC_TYPE_MUTEX)
return -EINVAL;
- if (atomic_read(&mutex->all_hint) > 0) {
- spin_lock(&dev->wait_all_lock);
- spin_lock_nest_lock(&mutex->lock, &dev->wait_all_lock);
-
- prev_count = mutex->u.mutex.count;
- ret = unlock_mutex_state(mutex, &args);
- if (!ret) {
+ obj_lock(mutex);
+ all = atomic_read(&mutex->all_hint);
+ if (unlikely(all)) {
+ obj_unlock(mutex);
+ mutex_lock(&dev->wait_all_lock);
+ dev_lock_obj(dev, mutex);
+ }
+
+ prev_count = mutex->u.mutex.count;
+ ret = unlock_mutex_state(mutex, &args);
+ if (!ret) {
+ if (all)
try_wake_all_obj(dev, mutex);
- try_wake_any_mutex(mutex);
- }
+ try_wake_any_mutex(mutex);
+ }
- spin_unlock(&mutex->lock);
- spin_unlock(&dev->wait_all_lock);
+ if (all) {
+ dev_unlock_obj(dev, mutex);
+ mutex_unlock(&dev->wait_all_lock);
} else {
- spin_lock(&mutex->lock);
-
- prev_count = mutex->u.mutex.count;
- ret = unlock_mutex_state(mutex, &args);
- if (!ret)
- try_wake_any_mutex(mutex);
-
- spin_unlock(&mutex->lock);
+ obj_unlock(mutex);
}
if (!ret && put_user(prev_count, &user_args->count))
@@ -437,6 +492,7 @@ static int kill_mutex_state(struct ntsyn
static int ntsync_mutex_kill(struct ntsync_obj *mutex, void __user *argp)
{
struct ntsync_device *dev = mutex->dev;
+ bool all = false;
__u32 owner;
int ret;
@@ -448,26 +504,26 @@ static int ntsync_mutex_kill(struct ntsy
if (mutex->type != NTSYNC_TYPE_MUTEX)
return -EINVAL;
- if (atomic_read(&mutex->all_hint) > 0) {
- spin_lock(&dev->wait_all_lock);
- spin_lock_nest_lock(&mutex->lock, &dev->wait_all_lock);
+ obj_lock(mutex);
+ all = atomic_read(&mutex->all_hint);
+ if (unlikely(all)) {
+ obj_unlock(mutex);
+ mutex_lock(&dev->wait_all_lock);
+ dev_lock_obj(dev, mutex);
+ }
- ret = kill_mutex_state(mutex, owner);
- if (!ret) {
+ ret = kill_mutex_state(mutex, owner);
+ if (!ret) {
+ if (all)
try_wake_all_obj(dev, mutex);
- try_wake_any_mutex(mutex);
- }
+ try_wake_any_mutex(mutex);
+ }
- spin_unlock(&mutex->lock);
- spin_unlock(&dev->wait_all_lock);
+ if (all) {
+ dev_unlock_obj(dev, mutex);
+ mutex_unlock(&dev->wait_all_lock);
} else {
- spin_lock(&mutex->lock);
-
- ret = kill_mutex_state(mutex, owner);
- if (!ret)
- try_wake_any_mutex(mutex);
-
- spin_unlock(&mutex->lock);
+ obj_unlock(mutex);
}
return ret;
@@ -477,35 +533,35 @@ static int ntsync_event_set(struct ntsyn
{
struct ntsync_device *dev = event->dev;
__u32 prev_state;
+ bool all = false;
if (event->type != NTSYNC_TYPE_EVENT)
return -EINVAL;
- if (atomic_read(&event->all_hint) > 0) {
- spin_lock(&dev->wait_all_lock);
- spin_lock_nest_lock(&event->lock, &dev->wait_all_lock);
+ obj_lock(event);
+ all = atomic_read(&event->all_hint);
+ if (unlikely(all)) {
+ obj_unlock(event);
+ mutex_lock(&dev->wait_all_lock);
+ dev_lock_obj(dev, event);
+ }
- prev_state = event->u.event.signaled;
- event->u.event.signaled = true;
+ prev_state = event->u.event.signaled;
+ event->u.event.signaled = true;
+ if (all)
try_wake_all_obj(dev, event);
- try_wake_any_event(event);
- if (pulse)
- event->u.event.signaled = false;
-
- spin_unlock(&event->lock);
- spin_unlock(&dev->wait_all_lock);
+ try_wake_any_event(event);
+ if (pulse)
+ event->u.event.signaled = false;
+
+ if (all) {
+ dev_unlock_obj(dev, event);
+ mutex_unlock(&dev->wait_all_lock);
} else {
- spin_lock(&event->lock);
-
- prev_state = event->u.event.signaled;
- event->u.event.signaled = true;
- try_wake_any_event(event);
- if (pulse)
- event->u.event.signaled = false;
-
- spin_unlock(&event->lock);
+ obj_unlock(event);
}
+
if (put_user(prev_state, (__u32 __user *)argp))
return -EFAULT;
@@ -984,7 +1040,7 @@ static int ntsync_wait_all(struct ntsync
/* queue ourselves */
- spin_lock(&dev->wait_all_lock);
+ mutex_lock(&dev->wait_all_lock);
for (i = 0; i < args.count; i++) {
struct ntsync_q_entry *entry = &q->entries[i];
@@ -1004,7 +1060,7 @@ static int ntsync_wait_all(struct ntsync
try_wake_all(dev, q, NULL);
- spin_unlock(&dev->wait_all_lock);
+ mutex_unlock(&dev->wait_all_lock);
/* sleep */
@@ -1012,7 +1068,7 @@ static int ntsync_wait_all(struct ntsync
/* and finally, unqueue */
- spin_lock(&dev->wait_all_lock);
+ mutex_lock(&dev->wait_all_lock);
for (i = 0; i < args.count; i++) {
struct ntsync_q_entry *entry = &q->entries[i];
@@ -1029,7 +1085,7 @@ static int ntsync_wait_all(struct ntsync
put_obj(obj);
}
- spin_unlock(&dev->wait_all_lock);
+ mutex_unlock(&dev->wait_all_lock);
signaled = atomic_read(&q->signaled);
if (signaled != -1) {
@@ -1056,7 +1112,7 @@ static int ntsync_char_open(struct inode
if (!dev)
return -ENOMEM;
- spin_lock_init(&dev->wait_all_lock);
+ mutex_init(&dev->wait_all_lock);
file->private_data = dev;
dev->file = file;
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox