Re: [PATCH 6/7] blk-mq: enable polling support by default

[Jeff Moyer <jmoyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

Hi, Christoph,

Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> writes:

> Now that applications need to explicitly ask for polling we can enable it
> by default in blk-mq drivers.

I don't think this is a good idea.  I'd just enable it in nvme and the
micron driver for now.

Cheers,
Jeff

>
> Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
> ---
>  include/linux/blkdev.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 4571ef1..458f6ef 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -499,7 +499,8 @@ struct request_queue {
>  
>  #define QUEUE_FLAG_MQ_DEFAULT	((1 << QUEUE_FLAG_IO_STAT) |		\
>  				 (1 << QUEUE_FLAG_STACKABLE)	|	\
> -				 (1 << QUEUE_FLAG_SAME_COMP))
> +				 (1 << QUEUE_FLAG_SAME_COMP)	|	\
> +				 (1 << QUEUE_FLAG_POLL))
>  
>  static inline void queue_lockdep_assert_held(struct request_queue *q)
>  {