From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Moyer Subject: Re: [PATCH 2/4] vfs: Define new syscalls preadv2,pwritev2 Date: Fri, 24 Oct 2014 11:46:56 -0400 Message-ID: References: <1613303dfaa91e6ff09cdd7860e0316765663ba6.1413923420.git.milosz@adfin.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1613303dfaa91e6ff09cdd7860e0316765663ba6.1413923420.git.milosz@adfin.com> (Milosz Tanski's message of "Tue, 21 Oct 2014 16:46:57 -0400") Sender: linux-kernel-owner@vger.kernel.org To: Milosz Tanski Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, Mel Gorman , Volker Lendecke , Tejun Heo , Theodore Ts'o , Al Viro , linux-api@vger.kernel.org, Michael Kerrisk List-Id: linux-api@vger.kernel.org Milosz Tanski writes: > diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h > index 22749c1..10f8883 100644 > --- a/include/uapi/asm-generic/unistd.h > +++ b/include/uapi/asm-generic/unistd.h > @@ -213,6 +213,10 @@ __SC_COMP(__NR_pwrite64, sys_pwrite64, compat_sys_pwrite64) > __SC_COMP(__NR_preadv, sys_preadv, compat_sys_preadv) > #define __NR_pwritev 70 > __SC_COMP(__NR_pwritev, sys_pwritev, compat_sys_pwritev) > +#define __NR_preadv2 281 > +__SC_COMP(__NR_preadv2, sys_preadv2) > +#define __NR_pwritev2 282 > +__SC_COMP(__NR_pwritev2, sys_pwritev2) This looks odd. First, __SC_COMP takes 3 arguments. Second, you are going to need to implement compat wrappers for the new system calls. Cheers, Jeff