From: Jeff Moyer <jmoyer@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: viro@zeniv.linux.org.uk, axboe@fb.com, milosz@adfin.com,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
linux-api@vger.kernel.org
Subject: Re: [PATCH 7/7] block, directio: set a REQ_POLL flag when submitting polled bios
Date: Mon, 29 Feb 2016 09:28:51 -0500 [thread overview]
Message-ID: <x49si0bmvz0.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <20160227085722.GB4255@lst.de> (Christoph Hellwig's message of "Sat, 27 Feb 2016 09:57:22 +0100")
Christoph Hellwig <hch@lst.de> writes:
> On Fri, Feb 26, 2016 at 04:10:51PM -0500, Jeff Moyer wrote:
>> Hi, Christoph,
>>
>> REQ_POLL is set but never checked. Is part of the patch missing, or was
>> that intentional?
>
> Jens insisted that I add it, even if there aren't users. I disagree,
> but in the end he'll have to apply the series..
OK. I think it just adds confusion.
Cheers,
Jeff
next prev parent reply other threads:[~2016-02-29 14:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 17:07 selective block polling and preadv2/pwritev2 revisited V2 Christoph Hellwig
2016-02-22 17:07 ` [PATCH 1/7] vfs: pass a flags argument to vfs_readv/vfs_writev Christoph Hellwig
[not found] ` <1456160876-14560-2-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-26 21:52 ` Jeff Moyer
[not found] ` <1456160876-14560-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-22 17:07 ` [PATCH 2/7] vfs: vfs: Define new syscalls preadv2,pwritev2 Christoph Hellwig
[not found] ` <1456160876-14560-3-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-26 21:51 ` Jeff Moyer
2016-02-27 8:58 ` Christoph Hellwig
2016-02-22 17:07 ` [PATCH 3/7] x86: wire up preadv2 and pwritev2 Christoph Hellwig
2016-02-22 17:07 ` [PATCH 4/7] vfs: add the RWF_HIPRI flag for preadv2/pwritev2 Christoph Hellwig
[not found] ` <1456160876-14560-5-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-26 21:56 ` Jeff Moyer
2016-02-27 8:58 ` Christoph Hellwig
2016-02-22 17:07 ` [PATCH 6/7] blk-mq: enable polling support by default Christoph Hellwig
[not found] ` <1456160876-14560-7-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-26 20:44 ` Jeff Moyer
[not found] ` <x49fuwfmcb5.fsf-RRHT56Q3PSP4kTEheFKJxxDDeQx5vsVwAInAS/Ez/D0@public.gmane.org>
2016-02-27 8:56 ` Christoph Hellwig
2016-02-29 14:27 ` Jeff Moyer
2016-02-22 17:07 ` [PATCH 7/7] block, directio: set a REQ_POLL flag when submitting polled bios Christoph Hellwig
[not found] ` <1456160876-14560-8-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-26 21:10 ` Jeff Moyer
2016-02-27 8:57 ` Christoph Hellwig
2016-02-29 14:28 ` Jeff Moyer [this message]
2016-02-26 21:18 ` selective block polling and preadv2/pwritev2 revisited V2 Jeff Moyer
2016-02-27 8:57 ` Christoph Hellwig
[not found] ` <20160227085744.GC4255-jcswGhMUV9g@public.gmane.org>
2016-02-29 1:30 ` Damien Le Moal
2016-02-29 14:59 ` Jeff Moyer
2016-02-22 17:07 ` [PATCH 5/7] direct-io: only use block polling if explicitly requested Christoph Hellwig
[not found] ` <1456160876-14560-6-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-26 21:58 ` Jeff Moyer
2016-02-26 15:06 ` selective block polling and preadv2/pwritev2 revisited V2 Stephen Bates
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49si0bmvz0.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=milosz@adfin.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).