* [PATCH] usb: gadget: f_fs: add usb_functionfs_descs_head_v2
@ 2014-09-02 6:58 Zhuang Jin Can
2014-09-02 12:45 ` Michal Nazarewicz
0 siblings, 1 reply; 2+ messages in thread
From: Zhuang Jin Can @ 2014-09-02 6:58 UTC (permalink / raw)
To: mina86-deATy8a+UHjQT0dZR+AlfA, balbi-l0cyMroinI0,
mgautam-sgV2jX0FEOL9JmXXK+q4OQ, andrzej.p-Sze3O3UU22JBDgjK7y7TUQ
Cc: jin.can.zhuang-ral2JQCrhuEAvxtiuMwx3w,
linux-api-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
david.a.cohen-ral2JQCrhuEAvxtiuMwx3w,
hang.yuan-ral2JQCrhuEAvxtiuMwx3w
Add usb_functionfs_descs_head_v2 structure for the new layout of
descriptors.
Signed-off-by: Zhuang Jin Can <jin.can.zhuang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
include/uapi/linux/usb/functionfs.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/include/uapi/linux/usb/functionfs.h b/include/uapi/linux/usb/functionfs.h
index 0154b28..0b3f9fc 100644
--- a/include/uapi/linux/usb/functionfs.h
+++ b/include/uapi/linux/usb/functionfs.h
@@ -32,6 +32,15 @@ struct usb_endpoint_descriptor_no_audio {
__u8 bInterval;
} __attribute__((packed));
+struct usb_functionfs_descs_head_v2 {
+ __le32 magic;
+ __le32 length;
+ __le32 flags;
+ __le32 fs_count;
+ __le32 hs_count;
+ __le32 ss_count;
+} __attribute__((packed));
+
/* Legacy format, deprecated as of 3.14. */
struct usb_functionfs_descs_head {
__le32 magic;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] usb: gadget: f_fs: add usb_functionfs_descs_head_v2
2014-09-02 6:58 [PATCH] usb: gadget: f_fs: add usb_functionfs_descs_head_v2 Zhuang Jin Can
@ 2014-09-02 12:45 ` Michal Nazarewicz
0 siblings, 0 replies; 2+ messages in thread
From: Michal Nazarewicz @ 2014-09-02 12:45 UTC (permalink / raw)
To: balbi, mgautam, andrzej.p
Cc: jin.can.zhuang, linux-api, linux-kernel, david.a.cohen, hang.yuan
On Tue, Sep 02 2014, Zhuang Jin Can <jin.can.zhuang@intel.com> wrote:
> Add usb_functionfs_descs_head_v2 structure for the new layout of
> descriptors.
NAK. It's a duplicate of <https://lkml.org/lkml/2014/6/6/128> and even
more importantly, the format of the header is not fixed past the flags
field (e.g. fs_count may be missing), so fs_count, hs_count and ss_count
cannot be in the structure.
> Signed-off-by: Zhuang Jin Can <jin.can.zhuang@intel.com>
> ---
> include/uapi/linux/usb/functionfs.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/include/uapi/linux/usb/functionfs.h b/include/uapi/linux/usb/functionfs.h
> index 0154b28..0b3f9fc 100644
> --- a/include/uapi/linux/usb/functionfs.h
> +++ b/include/uapi/linux/usb/functionfs.h
> @@ -32,6 +32,15 @@ struct usb_endpoint_descriptor_no_audio {
> __u8 bInterval;
> } __attribute__((packed));
>
> +struct usb_functionfs_descs_head_v2 {
> + __le32 magic;
> + __le32 length;
> + __le32 flags;
> + __le32 fs_count;
> + __le32 hs_count;
> + __le32 ss_count;
> +} __attribute__((packed));
> +
> /* Legacy format, deprecated as of 3.14. */
> struct usb_functionfs_descs_head {
> __le32 magic;
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>--ooO--(_)--Ooo--
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-02 12:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-02 6:58 [PATCH] usb: gadget: f_fs: add usb_functionfs_descs_head_v2 Zhuang Jin Can
2014-09-02 12:45 ` Michal Nazarewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).