From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08AE4C43460 for ; Tue, 4 May 2021 17:22:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD9C8613AA for ; Tue, 4 May 2021 17:22:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230396AbhEDRW6 (ORCPT ); Tue, 4 May 2021 13:22:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230318AbhEDRW6 (ORCPT ); Tue, 4 May 2021 13:22:58 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBA72C061574; Tue, 4 May 2021 10:22:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=Nts/+xIWR17zmFxlJ7GtFvHSObw051b9Oj5iVqkqHO4=; b=EZ7MDZsCSx25OCFbAYCOo0KXh1 6kF+lL9DfpUNEnqdLF0n6q5701nnicBTvakqxbRSWcA2s1oGalbtbc3gZEBSLQGMVAIWJ1vPhyqvC mxZ5X6qxRyT9YjnOG/EID/rnewphi12+5QasvyHNa6iQLVVWx6NUlbqQKwkDsioD0P1O3NflRvXHt i1GYePglollvoByFS3wKvBLc5v6RrqdNgXGuaZqY+hst3pD19JsSH8pA3h9pALAnaZzweFPHQnbUc j7SnPIjzUl69eNQb3//YOtHORay5YzoQ1t5tcWUsquUum2RTQYkOzvL98ihsguwwQLEzo/4ue4l1I XTvWevXg==; Received: from [2601:1c0:6280:3f0::7376] by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1ldyjU-00GrbD-2p; Tue, 04 May 2021 17:21:32 +0000 Subject: Re: [PATCH] csky: syscache: Fixup duplicate cache flush To: guoren@kernel.org, arnd@arndb.de Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-arch@vger.kernel.org, Guo Ren References: <1620112488-18773-1-git-send-email-guoren@kernel.org> From: Randy Dunlap Message-ID: <00cd7f1a-c6d4-b8ed-ba60-5c74516f4534@infradead.org> Date: Tue, 4 May 2021 10:21:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <1620112488-18773-1-git-send-email-guoren@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On 5/4/21 12:14 AM, guoren@kernel.org wrote: > From: Guo Ren > > The current csky logic of sys_cacheflush is wrong, it'll cause > icache flush call dcache flush again. Now fixup it with a > conditional "break & fallthrough". > > Fixes: 997153b9a75c ("csky: Add flush_icache_mm to defer flush icache all") > Fixes: 0679d29d3e23 ("csky: fix syscache.c fallthrough warning") > Signed-off-by: Guo Ren > Cc: Randy Dunlap > Cc: Arnd Bergmann Acked-by: Randy Dunlap more below: > --- > arch/csky/mm/syscache.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/arch/csky/mm/syscache.c b/arch/csky/mm/syscache.c > index 4e51d63..a7b53b0 100644 > --- a/arch/csky/mm/syscache.c > +++ b/arch/csky/mm/syscache.c > @@ -12,15 +12,18 @@ SYSCALL_DEFINE3(cacheflush, > int, cache) > { > switch (cache) { > - case ICACHE: > case BCACHE: > - flush_icache_mm_range(current->mm, > - (unsigned long)addr, > - (unsigned long)addr + bytes); > - fallthrough; > case DCACHE: > dcache_wb_range((unsigned long)addr, > (unsigned long)addr + bytes); > + if (cache == BCACHE) > + fallthrough; > + else > + break; I think the above would be more readable as: if (cache != BCACHE) break; fallthrough; fwiw. > + case ICACHE: > + flush_icache_mm_range(current->mm, > + (unsigned long)addr, > + (unsigned long)addr + bytes); > break; > default: > return -EINVAL; > thanks. -- ~Randy