From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Szyprowski Subject: RE: [PATCHv8 05/10] ARM: dma-mapping: use asm-generic/dma-mapping-common.h Date: Wed, 11 Apr 2012 14:07:48 +0200 Message-ID: <012f01cd17db$b5f918d0$21eb4a70$%szyprowski@samsung.com> References: <1334055852-19500-1-git-send-email-m.szyprowski@samsung.com> <1334055852-19500-6-git-send-email-m.szyprowski@samsung.com> <201204101147.20733.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7BIT Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:40455 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752503Ab2DKMHx (ORCPT ); Wed, 11 Apr 2012 08:07:53 -0400 Received: from euspt1 (mailout1.w1.samsung.com [210.118.77.11]) by mailout1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTP id <0M2B00HQPDNFLC@mailout1.w1.samsung.com> for linux-arch@vger.kernel.org; Wed, 11 Apr 2012 13:06:51 +0100 (BST) Received: from linux.samsung.com ([106.116.38.10]) by spt1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0M2B00NM6DP327@spt1.w1.samsung.com> for linux-arch@vger.kernel.org; Wed, 11 Apr 2012 13:07:51 +0100 (BST) In-reply-to: <201204101147.20733.arnd@arndb.de> Content-language: pl Sender: linux-arch-owner@vger.kernel.org List-ID: To: 'Arnd Bergmann' Cc: linux-arm-kernel@lists.infradead.org, linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, iommu@lists.linux-foundation.org, 'Kyungmin Park' , 'Joerg Roedel' , 'Russell King - ARM Linux' , 'Chunsang Jeong' , 'Krishna Reddy' , 'KyongHo Cho' , Andrzej Pietrasiewicz , 'Benjamin Herrenschmidt' , 'Konrad Rzeszutek Wilk' , 'Hiroshi Doyu' , 'Subash Patel' Hi Arnd, On Tuesday, April 10, 2012 1:47 PM Arnd Bergmann wrote: > On Tuesday 10 April 2012, Marek Szyprowski wrote: > > This patch modifies dma-mapping implementation on ARM architecture to > > use common dma_map_ops structure and asm-generic/dma-mapping-common.h > > helpers. > > > > Signed-off-by: Marek Szyprowski > > Acked-by: Kyungmin Park > > --- > > arch/arm/Kconfig | 1 + > > arch/arm/include/asm/device.h | 1 + > > arch/arm/include/asm/dma-mapping.h | 196 +++++------------------------------- > > arch/arm/mm/dma-mapping.c | 148 ++++++++++++++++----------- > > 4 files changed, 115 insertions(+), 231 deletions(-) > > Looks good in principle. One question: Now that many of the functions are only > used in the dma_map_ops, can you make them 'static' instead? Some of these non static functions (mainly arm_dma_*_sg_* family) are also used by dma bounce code introduced in the next patch, that's why I left them without static attribute. Best regards -- Marek Szyprowski Samsung Poland R&D Center