From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Zanussi Subject: Re: [patch V2 20/29] tracing: Simplify stacktrace retrieval in histograms Date: Thu, 18 Apr 2019 14:58:55 -0500 Message-ID: <014a7564d606b249a5e50bef0fedf266977a935b.camel@linux.intel.com> References: <20190418084119.056416939@linutronix.de> <20190418084254.910579307@linutronix.de> <20190418094014.7d457f29@gandalf.local.home> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190418094014.7d457f29@gandalf.local.home> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Steven Rostedt , Thomas Gleixner Cc: Mike Snitzer , David Airlie , Catalin Marinas , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, dm-devel@redhat.com, Alexander Potapenko , Christoph Lameter , Christoph Hellwig , Alasdair Kergon , Marek Szyprowski , linux-arch@vger.kernel.org, x86@kernel.org, kasan-dev@googlegroups.com, Johannes Thumshirn , Andrey Ryabinin , Alexey Dobriyan , intel-gfx@lists.freedesktop.org, David Rientjes , Akinobu Mita , Josef Bacik , Mike Rapoport , Andy Lutomirski , Josh Poimboeuf , David Sterba , Dmitry Vyukov List-Id: linux-arch.vger.kernel.org T24gVGh1LCAyMDE5LTA0LTE4IGF0IDA5OjQwIC0wNDAwLCBTdGV2ZW4gUm9zdGVkdCB3cm90ZToK PiBbIEFkZGVkIFRvbSBaYW51c3NpIF0KPiAKPiBPbiBUaHUsIDE4IEFwciAyMDE5IDEwOjQxOjM5 ICswMjAwCj4gVGhvbWFzIEdsZWl4bmVyIDx0Z2x4QGxpbnV0cm9uaXguZGU+IHdyb3RlOgo+IAo+ ID4gVGhlIGluZGlyZWN0aW9uIHRocm91Z2ggc3RydWN0IHN0YWNrX3RyYWNlIGlzIG5vdCBuZWNl c3NhcnkgYXQgYWxsLgo+ID4gVXNlIHRoZQo+ID4gc3RvcmFnZSBhcnJheSBiYXNlZCBpbnRlcmZh Y2UuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IFRob21hcyBHbGVpeG5lciA8dGdseEBsaW51dHJv bml4LmRlPgo+ID4gQ2M6IFN0ZXZlbiBSb3N0ZWR0IDxyb3N0ZWR0QGdvb2RtaXMub3JnPgo+IAo+ IExvb2tzIGZpbmUgdG8gbWUKPiAKPiBBY2tlZC1ieTogU3RldmVuIFJvc3RlZHQgKFZNd2FyZSkg PHJvc3RlZHRAZ29vZG1pcy5vcmc+Cj4gCj4gIEJ1dC4uLgo+IAo+IFRvbSwKPiAKPiBDYW4geW91 IHJldmlldyB0aGlzIHRvbz8KCkxvb2tzIGdvb2QgdG8gbWUgdG9vIQoKQWNrZWQtYnk6IFRvbSBa YW51c3NpIDx0b20uemFudXNzaUBsaW51eC5pbnRlbC5jb20+CgoKPiAKPiBQYXRjaCBzZXJpZXMg c3RhcnRzIGhlcmU6Cj4gCj4gICBodHRwOi8vbGttbC5rZXJuZWwub3JnL3IvMjAxOTA0MTgwODQx MTkuMDU2NDE2OTM5QGxpbnV0cm9uaXguZGUKPiAKPiBUaGFua3MsCj4gCj4gLS0gU3RldmUKPiAK PiA+IC0tLQo+ID4gIGtlcm5lbC90cmFjZS90cmFjZV9ldmVudHNfaGlzdC5jIHwgICAxMiArKyst LS0tLS0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9u cygtKQo+ID4gCj4gPiAtLS0gYS9rZXJuZWwvdHJhY2UvdHJhY2VfZXZlbnRzX2hpc3QuYwo+ID4g KysrIGIva2VybmVsL3RyYWNlL3RyYWNlX2V2ZW50c19oaXN0LmMKPiA+IEBAIC01MTg2LDcgKzUx ODYsNiBAQCBzdGF0aWMgdm9pZCBldmVudF9oaXN0X3RyaWdnZXIoc3RydWN0IGV2Cj4gPiAgCXU2 NCB2YXJfcmVmX3ZhbHNbVFJBQ0lOR19NQVBfVkFSU19NQVhdOwo+ID4gIAljaGFyIGNvbXBvdW5k X2tleVtISVNUX0tFWV9TSVpFX01BWF07Cj4gPiAgCXN0cnVjdCB0cmFjaW5nX21hcF9lbHQgKmVs dCA9IE5VTEw7Cj4gPiAtCXN0cnVjdCBzdGFja190cmFjZSBzdGFja3RyYWNlOwo+ID4gIAlzdHJ1 Y3QgaGlzdF9maWVsZCAqa2V5X2ZpZWxkOwo+ID4gIAl1NjQgZmllbGRfY29udGVudHM7Cj4gPiAg CXZvaWQgKmtleSA9IE5VTEw7Cj4gPiBAQCAtNTE5OCwxNCArNTE5Nyw5IEBAIHN0YXRpYyB2b2lk IGV2ZW50X2hpc3RfdHJpZ2dlcihzdHJ1Y3QgZXYKPiA+ICAJCWtleV9maWVsZCA9IGhpc3RfZGF0 YS0+ZmllbGRzW2ldOwo+ID4gIAo+ID4gIAkJaWYgKGtleV9maWVsZC0+ZmxhZ3MgJiBISVNUX0ZJ RUxEX0ZMX1NUQUNLVFJBQ0UpIHsKPiA+IC0JCQlzdGFja3RyYWNlLm1heF9lbnRyaWVzID0gSElT VF9TVEFDS1RSQUNFX0RFUFRIOwo+ID4gLQkJCXN0YWNrdHJhY2UuZW50cmllcyA9IGVudHJpZXM7 Cj4gPiAtCQkJc3RhY2t0cmFjZS5ucl9lbnRyaWVzID0gMDsKPiA+IC0JCQlzdGFja3RyYWNlLnNr aXAgPSBISVNUX1NUQUNLVFJBQ0VfU0tJUDsKPiA+IC0KPiA+IC0JCQltZW1zZXQoc3RhY2t0cmFj ZS5lbnRyaWVzLCAwLAo+ID4gSElTVF9TVEFDS1RSQUNFX1NJWkUpOwo+ID4gLQkJCXNhdmVfc3Rh Y2tfdHJhY2UoJnN0YWNrdHJhY2UpOwo+ID4gLQo+ID4gKwkJCW1lbXNldChlbnRyaWVzLCAwLCBI SVNUX1NUQUNLVFJBQ0VfU0laRSk7Cj4gPiArCQkJc3RhY2tfdHJhY2Vfc2F2ZShlbnRyaWVzLAo+ ID4gSElTVF9TVEFDS1RSQUNFX0RFUFRILAo+ID4gKwkJCQkJIEhJU1RfU1RBQ0tUUkFDRV9TS0lQ KTsKPiA+ICAJCQlrZXkgPSBlbnRyaWVzOwo+ID4gIAkJfSBlbHNlIHsKPiA+ICAJCQlmaWVsZF9j b250ZW50cyA9IGtleV9maWVsZC0+Zm4oa2V5X2ZpZWxkLCBlbHQsCj4gPiByYmUsIHJlYyk7Cj4g PiAKPiAKPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com ([134.134.136.20]:46205 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389754AbfDRT7B (ORCPT ); Thu, 18 Apr 2019 15:59:01 -0400 Message-ID: <014a7564d606b249a5e50bef0fedf266977a935b.camel@linux.intel.com> Subject: Re: [patch V2 20/29] tracing: Simplify stacktrace retrieval in histograms From: Tom Zanussi Date: Thu, 18 Apr 2019 14:58:55 -0500 In-Reply-To: <20190418094014.7d457f29@gandalf.local.home> References: <20190418084119.056416939@linutronix.de> <20190418084254.910579307@linutronix.de> <20190418094014.7d457f29@gandalf.local.home> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Steven Rostedt , Thomas Gleixner Cc: LKML , Josh Poimboeuf , x86@kernel.org, Andy Lutomirski , Alexander Potapenko , Alexey Dobriyan , Andrew Morton , Pekka Enberg , linux-mm@kvack.org, David Rientjes , Christoph Lameter , Catalin Marinas , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Mike Rapoport , Akinobu Mita , iommu@lists.linux-foundation.org, Robin Murphy , Christoph Hellwig , Marek Szyprowski , Johannes Thumshirn , David Sterba , Chris Mason , Josef Bacik , linux-btrfs@vger.kernel.org, dm-devel@redhat.com, Mike Snitzer , Alasdair Kergon , intel-gfx@lists.freedesktop.org, Joonas Lahtinen , Maarten Lankhorst , dri-devel@lists.freedesktop.org, David Airlie , Jani Nikula , Daniel Vetter , Rodrigo Vivi , linux-arch@vger.kernel.org Message-ID: <20190418195855.kMzGyrxupua1BFA-5W329nvilax9H3YQbuTHpq4tvV8@z> On Thu, 2019-04-18 at 09:40 -0400, Steven Rostedt wrote: > [ Added Tom Zanussi ] > > On Thu, 18 Apr 2019 10:41:39 +0200 > Thomas Gleixner wrote: > > > The indirection through struct stack_trace is not necessary at all. > > Use the > > storage array based interface. > > > > Signed-off-by: Thomas Gleixner > > Cc: Steven Rostedt > > Looks fine to me > > Acked-by: Steven Rostedt (VMware) > > But... > > Tom, > > Can you review this too? Looks good to me too! Acked-by: Tom Zanussi > > Patch series starts here: > > http://lkml.kernel.org/r/20190418084119.056416939@linutronix.de > > Thanks, > > -- Steve > > > --- > > kernel/trace/trace_events_hist.c | 12 +++--------- > > 1 file changed, 3 insertions(+), 9 deletions(-) > > > > --- a/kernel/trace/trace_events_hist.c > > +++ b/kernel/trace/trace_events_hist.c > > @@ -5186,7 +5186,6 @@ static void event_hist_trigger(struct ev > > u64 var_ref_vals[TRACING_MAP_VARS_MAX]; > > char compound_key[HIST_KEY_SIZE_MAX]; > > struct tracing_map_elt *elt = NULL; > > - struct stack_trace stacktrace; > > struct hist_field *key_field; > > u64 field_contents; > > void *key = NULL; > > @@ -5198,14 +5197,9 @@ static void event_hist_trigger(struct ev > > key_field = hist_data->fields[i]; > > > > if (key_field->flags & HIST_FIELD_FL_STACKTRACE) { > > - stacktrace.max_entries = HIST_STACKTRACE_DEPTH; > > - stacktrace.entries = entries; > > - stacktrace.nr_entries = 0; > > - stacktrace.skip = HIST_STACKTRACE_SKIP; > > - > > - memset(stacktrace.entries, 0, > > HIST_STACKTRACE_SIZE); > > - save_stack_trace(&stacktrace); > > - > > + memset(entries, 0, HIST_STACKTRACE_SIZE); > > + stack_trace_save(entries, > > HIST_STACKTRACE_DEPTH, > > + HIST_STACKTRACE_SKIP); > > key = entries; > > } else { > > field_contents = key_field->fn(key_field, elt, > > rbe, rec); > > > >