linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greentime Hu <green.hu@gmail.com>
To: greentime@andestech.com, linux-kernel@vger.kernel.org,
	arnd@arndb.de, linux-arch@vger.kernel.org, tglx@linutronix.de,
	jason@lakedaemon.net, marc.zyngier@arm.com, robh+dt@kernel.org,
	netdev@vger.kernel.org, deanbo422@gmail.com,
	devicetree@vger.kernel.org, viro@zeniv.linux.org.uk,
	dhowells@redhat.com, will.deacon@arm.com,
	daniel.lezcano@linaro.org, linux-serial@vger.kernel.org,
	geert.uytterhoeven@gmail.com, linus.walleij@linaro.org,
	mark.rutland@arm.com, greg@kroah.com, ren_guo@c-sky.com,
	rdunlap@infradead.org, davem@davemloft.net, jonas@southpole.se,
	stefan.kristiansson@saunalahti.fi, shorne@gmail.com
Cc: green.hu@gmail.com
Subject: [PATCH v5 04/39] earlycon: add reg-offset to physical address before mapping
Date: Tue,  2 Jan 2018 16:24:36 +0800	[thread overview]
Message-ID: <030b9e2ee2d6ee309eebe00feea0e92687304e64.1514874857.git.green.hu@gmail.com> (raw)
In-Reply-To: <cover.1514874857.git.green.hu@gmail.com>
In-Reply-To: <cover.1514874857.git.green.hu@gmail.com>

From: Greentime Hu <greentime@andestech.com>

It will get the wrong virtual address because port->mapbase is not added
the correct reg-offset yet. We have to update it before earlycon_map()
is called

Signed-off-by: Greentime Hu <greentime@andestech.com>
---
 drivers/tty/serial/earlycon.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/earlycon.c b/drivers/tty/serial/earlycon.c
index 98928f0..17dba0a 100644
--- a/drivers/tty/serial/earlycon.c
+++ b/drivers/tty/serial/earlycon.c
@@ -253,11 +253,12 @@ int __init of_setup_earlycon(const struct earlycon_id *match,
 	}
 	port->mapbase = addr;
 	port->uartclk = BASE_BAUD * 16;
-	port->membase = earlycon_map(port->mapbase, SZ_4K);
 
 	val = of_get_flat_dt_prop(node, "reg-offset", NULL);
 	if (val)
 		port->mapbase += be32_to_cpu(*val);
+	port->membase = earlycon_map(port->mapbase, SZ_4K);
+
 	val = of_get_flat_dt_prop(node, "reg-shift", NULL);
 	if (val)
 		port->regshift = be32_to_cpu(*val);
-- 
1.7.9.5

  parent reply	other threads:[~2018-01-02  8:24 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-02  8:24 [PATCH v5 00/39] Andes(nds32) Linux Kernel Port Greentime Hu
2018-01-02  8:24 ` [PATCH v5 01/39] asm-generic/io.h: move ioremap_nocache/ioremap_uc/ioremap_wc/ioremap_wt out of ifndef CONFIG_MMU Greentime Hu
2018-01-02  8:24   ` Greentime Hu
2018-01-02  8:24 ` [PATCH v5 02/39] openrisc: add ioremap_nocache declaration before include asm-generic/io.h and sync ioremap prototype with it Greentime Hu
2018-01-02  8:24   ` Greentime Hu
2018-01-03 14:38   ` Stafford Horne
2018-01-03 14:38     ` Stafford Horne
2018-01-03 15:23     ` Greentime Hu
2018-01-03 15:23       ` Greentime Hu
2018-01-02  8:24 ` Greentime Hu [this message]
2018-01-02  8:24   ` [PATCH v5 04/39] earlycon: add reg-offset to physical address before mapping Greentime Hu
2018-01-02  8:24 ` [PATCH v5 05/39] nds32: Assembly macros and definitions Greentime Hu
2018-01-02  8:24   ` Greentime Hu
2018-01-02  8:24 ` [PATCH v5 07/39] nds32: Exception handling Greentime Hu
2018-01-02  8:24   ` Greentime Hu
2018-01-02  8:24 ` [PATCH v5 08/39] nds32: MMU definitions Greentime Hu
2018-01-02  8:24 ` [PATCH v5 09/39] nds32: MMU initialization Greentime Hu
2018-01-02  8:24   ` Greentime Hu
2018-01-02  8:24 ` [PATCH v5 10/39] nds32: MMU fault handling and page table management Greentime Hu
2018-01-02  8:24   ` Greentime Hu
2018-01-02  8:24 ` [PATCH v5 11/39] nds32: Cache and TLB routines Greentime Hu
2018-01-02  8:24   ` Greentime Hu
2018-01-02  8:24 ` [PATCH v5 12/39] nds32: Process management Greentime Hu
2018-01-02  8:24   ` Greentime Hu
2018-01-02  8:24 ` [PATCH v5 13/39] nds32: IRQ handling Greentime Hu
2018-01-02  8:24   ` Greentime Hu
2018-01-02  8:24 ` [PATCH v5 14/39] nds32: Atomic operations Greentime Hu
2018-01-02  8:24   ` Greentime Hu
2018-01-02  8:24 ` [PATCH v5 15/39] nds32: Device specific operations Greentime Hu
2018-01-02  8:24   ` Greentime Hu
2018-01-02  8:24 ` [PATCH v5 16/39] nds32: DMA mapping API Greentime Hu
2018-01-02  8:24 ` [PATCH v5 17/39] nds32: ELF definitions Greentime Hu
2018-01-02  8:24   ` Greentime Hu
2018-01-02  8:24 ` [PATCH v5 18/39] nds32: System calls handling Greentime Hu
2018-01-02  8:24   ` Greentime Hu
2018-01-02  8:24 ` [PATCH v5 19/39] nds32: VDSO support Greentime Hu
2018-01-02  8:24   ` Greentime Hu
2018-01-02  8:24 ` [PATCH v5 20/39] nds32: Signal handling support Greentime Hu
2018-01-02  8:24   ` Greentime Hu
2018-01-02  8:24 ` [PATCH v5 21/39] nds32: Library functions Greentime Hu
2018-01-02  8:24   ` Greentime Hu
2018-01-02  8:24 ` [PATCH v5 22/39] nds32: Debugging support Greentime Hu
2018-01-02  8:24 ` [PATCH v5 23/39] nds32: L2 cache support Greentime Hu
2018-01-02  8:24   ` Greentime Hu
2018-01-02  8:24 ` [PATCH v5 24/39] nds32: Loadable modules Greentime Hu
2018-01-02  8:24   ` Greentime Hu
2018-01-02  8:24 ` [PATCH v5 25/39] nds32: Generic timers support Greentime Hu
2018-01-02  8:24   ` Greentime Hu
2018-01-02  8:24 ` [PATCH v5 26/39] nds32: Device tree support Greentime Hu
2018-01-02  8:24   ` Greentime Hu
     [not found]   ` <7fe1190a9cf8e30f1b8af52dd382ba1176997786.1514874857.git.green.hu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-03 19:14     ` Rob Herring
2018-01-03 19:14       ` Rob Herring
     [not found]       ` <CAL_Jsq+CC-3w8BVcUP77__ZR8aYMhxiXDYJ--HZwA=ezHG548g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-04  7:57         ` Greentime Hu
2018-01-04  7:57           ` Greentime Hu
     [not found] ` <cover.1514874857.git.green.hu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-02  8:24   ` [PATCH v5 03/39] sparc: io: To use the define of ioremap_[nocache|wc|wb] in asm-generic/io.h Greentime Hu
2018-01-02  8:24     ` Greentime Hu
2018-01-02  8:24   ` [PATCH v5 06/39] nds32: Kernel booting and initialization Greentime Hu
2018-01-02  8:24     ` Greentime Hu
2018-01-02  8:24   ` [PATCH v5 27/39] nds32: Miscellaneous header files Greentime Hu
2018-01-02  8:24     ` Greentime Hu
2018-01-02  8:25   ` [PATCH v5 31/39] dt-bindings: nds32 CPU Bindings Greentime Hu
2018-01-02  8:25     ` Greentime Hu
2018-01-02  8:25 ` [PATCH v5 28/39] nds32: defconfig Greentime Hu
2018-01-02  8:25   ` Greentime Hu
2018-01-02  8:25 ` [PATCH v5 29/39] nds32: Build infrastructure Greentime Hu
2018-01-02  8:25   ` Greentime Hu
2018-01-02  8:25 ` [PATCH v5 30/39] MAINTAINERS: Add nds32 Greentime Hu
2018-01-02  8:25   ` Greentime Hu
2018-01-02  8:25 ` [PATCH v5 32/39] dt-bindings: nds32 L2 cache controller Bindings Greentime Hu
2018-01-02  8:25   ` Greentime Hu
     [not found]   ` <fc1f58a97003b4bedfbb8b6e3d29b1628ff61f9a.1514874858.git.green.hu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-03 21:10     ` Rob Herring
2018-01-03 21:10       ` Rob Herring
2018-01-02  8:25 ` [PATCH v5 33/39] dt-bindings: nds32 SoC Bindings Greentime Hu
2018-01-02  8:25   ` Greentime Hu
2018-01-02  8:25 ` [PATCH v5 34/39] dt-bindings: interrupt-controller: Andestech Internal Vector Interrupt Controller Greentime Hu
2018-01-02  8:25   ` Greentime Hu
2018-01-02  8:25 ` [PATCH v5 35/39] irqchip: Andestech Internal Vector Interrupt Controller driver Greentime Hu
2018-01-02  8:25   ` Greentime Hu
2018-01-02  8:25 ` [PATCH v5 36/39] net: faraday add nds32 support Greentime Hu
2018-01-02  8:25   ` Greentime Hu
2018-01-02  8:25 ` [PATCH v5 37/39] clocksource/drivers/atcpit100: Add andestech atcpit100 timer Greentime Hu
2018-01-02  8:25 ` [PATCH v5 38/39] clocksource/drivers/atcpit100: VDSO support Greentime Hu
2018-01-02  8:25 ` [PATCH v5 39/39] dt-bindings: timer: Add andestech atcpit100 timer binding doc Greentime Hu
2018-01-02  8:25   ` Greentime Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=030b9e2ee2d6ee309eebe00feea0e92687304e64.1514874857.git.green.hu@gmail.com \
    --to=green.hu@gmail.com \
    --cc=arnd@arndb.de \
    --cc=daniel.lezcano@linaro.org \
    --cc=davem@davemloft.net \
    --cc=deanbo422@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dhowells@redhat.com \
    --cc=geert.uytterhoeven@gmail.com \
    --cc=greentime@andestech.com \
    --cc=greg@kroah.com \
    --cc=jason@lakedaemon.net \
    --cc=jonas@southpole.se \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=ren_guo@c-sky.com \
    --cc=robh+dt@kernel.org \
    --cc=shorne@gmail.com \
    --cc=stefan.kristiansson@saunalahti.fi \
    --cc=tglx@linutronix.de \
    --cc=viro@zeniv.linux.org.uk \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).