linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: Ludovic Desroches <ludovic.desroches@microchip.com>,
	linux-serial@vger.kernel.org, linux-arch@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: alexandre.belloni@bootlin.com, arnd@arndb.de,
	richard.genoud@gmail.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, jslaby@suse.com
Subject: Re: [PATCH v2 0/2] add ISO7816 support
Date: Thu, 19 Jul 2018 10:59:47 +0200	[thread overview]
Message-ID: <034fe4ed-979b-51ee-db7c-5dc7137b98e5@baylibre.com> (raw)
In-Reply-To: <20180719084737.1490-1-ludovic.desroches@microchip.com>

Hi Ludovic,

On 19/07/2018 10:47, Ludovic Desroches wrote:
> Hi,
> 
> This patchset adds support for the ISO7816 standard. The USART devices in
> Microchip SoCs have an ISO7816 mode. It allows to let the USART managing
> the CLK and I/O signals of a smart card.

Wow, I would have loved to have this at the time...
I'm curious, do you have an example of userspace code using this ?
The ATR rx needs a very weird handling, I'm curious how you managed it.

Thanks,
Neil

> 
> Changes:
> - v2
>   - uart_get_iso7816_config: check there is an iso7816_config function
>   - use IOCTL macros to generate the IOCTL number
>   - check that reserved field is not used
>   - remove debug logs
>   - check that the iso7816_config is right before doing any action
>   - change the error from nack and max iteration status to a debug message
>   - remove patch 3 as it concerns both rs485 and iso7816 to think more
>   about the need of adding a lock or not
> 
> Nicolas Ferre (2):
>   tty/serial_core: add ISO7816 infrastructure
>   tty/serial: atmel: add ISO7816 support
> 
>  arch/alpha/include/uapi/asm/ioctls.h   |   2 +
>  arch/mips/include/uapi/asm/ioctls.h    |   2 +
>  arch/powerpc/include/uapi/asm/ioctls.h |   2 +
>  arch/sh/include/uapi/asm/ioctls.h      |   2 +
>  arch/sparc/include/uapi/asm/ioctls.h   |   2 +
>  arch/xtensa/include/uapi/asm/ioctls.h  |   2 +
>  drivers/tty/serial/atmel_serial.c      | 170 +++++++++++++++++++++++++++++++--
>  drivers/tty/serial/atmel_serial.h      |   3 +-
>  drivers/tty/serial/serial_core.c       |  60 ++++++++++++
>  include/linux/serial_core.h            |   3 +
>  include/uapi/asm-generic/ioctls.h      |   2 +
>  include/uapi/linux/serial.h            |  17 ++++
>  12 files changed, 256 insertions(+), 11 deletions(-)
> 

  parent reply	other threads:[~2018-07-19  8:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-19  8:47 [PATCH v2 0/2] add ISO7816 support Ludovic Desroches
2018-07-19  8:47 ` Ludovic Desroches
2018-07-19  8:47 ` [PATCH v2 1/2] tty/serial_core: add ISO7816 infrastructure Ludovic Desroches
2018-07-19  8:47   ` Ludovic Desroches
2018-07-19 23:54   ` kbuild test robot
2018-07-19  8:47 ` [PATCH v2 2/2] tty/serial: atmel: add ISO7816 support Ludovic Desroches
2018-07-19  8:47   ` Ludovic Desroches
2018-07-27 14:39   ` Richard Genoud
2018-07-27 14:39     ` Richard Genoud
2018-08-03  8:50     ` Ludovic Desroches
2018-08-03  8:50       ` Ludovic Desroches
2018-07-19  8:59 ` Neil Armstrong [this message]
2018-07-19  8:59   ` [PATCH v2 0/2] " Neil Armstrong
2018-07-19  9:26   ` Ludovic Desroches
2018-07-19  9:26     ` Ludovic Desroches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=034fe4ed-979b-51ee-db7c-5dc7137b98e5@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=richard.genoud@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).