From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Marek Subject: Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Date: Tue, 29 Nov 2016 22:23:51 +0100 Message-ID: <04650a4f-8ba7-a44c-6777-68dc413b683d@suse.com> References: <20161129131922.GA31466@angband.pl> <20161129135118.24696-1-kilobyte@angband.pl> <20161129170522.GA3441@angband.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de ([195.135.220.15]:45033 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751917AbcK2VXy (ORCPT ); Tue, 29 Nov 2016 16:23:54 -0500 In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Linus Torvalds , Adam Borowski Cc: Greg Kroah-Hartman , Linux Kbuild mailing list , Ben Hutchings , Debian kernel maintainers , "linux-arch@vger.kernel.org" , Arnd Bergmann , Ingo Molnar , Nicholas Piggin , Linux Kernel Mailing List Dne 29.11.2016 v 18:10 Linus Torvalds napsal(a): > How about this stupid patch? It weakens modversions, but that may be > ok for Debian, and a better alternative than just saying "we don't > support it at all". [...] > - pr_warn("%s: no symbol version for %s\n", mod->name, symname); > - return 0; > + /* Broken toolchain. Warn once, then let it go.. */ > + pr_warn_once("%s: no symbol version for %s\n", mod->name, symname); > + return 1; Fine with me, if it goes with the revert of the "depends on BROKEN." Michal