From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C3C4216604 for ; Fri, 20 Dec 2024 14:35:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734705336; cv=none; b=YLbHW/7y9sZqHUx/Gx5DQ06KP62U72XRH3Ts59IlaESe8klnG4p5tpzPbLF281dmKh+rR9bB90fd1wAivbvoUrgdWFWE/s6Ka7/OP+eeHnrd/2abVUBgZuFks2+ZxnJuQ2WX6CA4Ekq2z6tc4zCynkeH3T+v1F40Zs8PoxJy4U0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734705336; c=relaxed/simple; bh=mal3yYV/2puIWYQMpkgozfsCLOtcbEomeCKa3z1Lb4c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=acC7pt/rWs7jgszcRlDEZ4X9/nkqWP2pD0nMvT6tOxOQ133sADrzKWIlTNC3LvtFJCtIdiFYoCsgJVkPv2ooBGZ704a6HuSBwJJi5LM3kkOBfkK+g16di5DVNJtGnGvXaZxg0ryE2UciVodgkx5/MMg36+WqNJJh/iI2gmkQrjw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=WpUi0YSd; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="WpUi0YSd" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-21634338cfdso25712955ad.2 for ; Fri, 20 Dec 2024 06:35:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1734705334; x=1735310134; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nZtvjese48KZzlytF02YIE1ieOtjMj+XC4JVW8Rkw1o=; b=WpUi0YSdSzwsedoFq1iaUFnMB1ZuB/fJnX1nhwb+WCgEZd4ahZWHtbpCLoc6mjeFss 1PqUPopcSeiI8hLGOxgW+V/A3VUH6ba4tTixAO4ugjcXcjYL+K45ZXruc6lObMUkN6bY kVfj9y3z5ro0lQIIxHj3W2EENSaL7koOJMx4TRpWVrGvm7F20dLUMuyJTNoe7yrKGjvr +cFzDpa810ZozN3J0g6EXhIDowHhVLHwXfmH9nX+kNz1hnIjaXisldeIkRpVQclHtPUQ IAPh8QcwrW20GsAztG9Ajud2tCCI4WlH3ANIN+UKjDQRIvsINL6LSUb5Ge0SY615+g0K SUzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734705334; x=1735310134; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nZtvjese48KZzlytF02YIE1ieOtjMj+XC4JVW8Rkw1o=; b=cPO6gnzOev8ePcluXaXEvCnJbQnPOM5KCWmMPuKUXo+XvGlftnrrjX3XwZ9bP/bHwC iYV57p/IctA36DX2dgONI8r80j0298PIDBHVBY/m99JDyj0Nf91NhQ7BBKatEsA29GBA 4amZy0hc7gU68LwnIqbHYzJgMP5MoDzC1J9sKxhNiyoA9kMKfqjDLMiZA0a9nW+yrHNR tlQulJC/WwodAzkEC400Bkwyv1+7OXWSSnAsezTRqjftMnc+u3fakx1V6RI1Vh6QjO8D rO1t0tZ9YRAbdB/je6cYT2KMY5YtO0sY74rHlEJdCF9hKc+T2z6wGvfLYkdhitwiz4LS q/Pg== X-Forwarded-Encrypted: i=1; AJvYcCXkz0CYDdFN69IkKyyKH/xSy6je2OJy0bZyEdVUiG39pSHqeKkKEascHJNHTwoS+u3oNBDLmgeICDr7@vger.kernel.org X-Gm-Message-State: AOJu0YzTEdIWHSE1v9mzpAQYY0zyUt4YIHg3CGn9jX8C0sNKYVA6k0Kz dLyT5aTLUXfKSJaiDUr332GjCR3ItBLiP9Hc8owm7dyqkVqwlE7tKxymL9k2ocxcJMKX1qyFHzB P X-Gm-Gg: ASbGncvi5CFt2xyPGgvniERY8GY5hwKJfM1TSYTHl1pEpTpX/8VIBDV1mxiBUuBxVul kTEQfKKpo64gjDCBHqWC3GuxnVoPlfBKhnOcuBjBlGCs9Zc6I2LVS7IGrgI3GpvqTupOwmpNc8R VIUPJUT0WPV0v1s52dlEt48dvUYneo3rkQiLX+36XcHGB4htbzP0FXqSFYxZ81QumH6YzYfU/m8 uJyWeufJgc701ooKDRljP7YcmU8DcUPneYUi9BRRPpSBgQEanXcxfYvANz+626eGHdys7D/o5ok FaiEYI3/Gw2yzLlWNrBrponbD5gA/muezcr6048VxABt+Fi6ZlkRIwE= X-Google-Smtp-Source: AGHT+IEB+BvsoefjQ7Vgsp4o6cvW8xDLBZZay+9fVCOXIUsW3GchN/svfJCRC88uzsyXVDtiu7XXHA== X-Received: by 2002:a17:902:d485:b0:215:b5d6:5fa8 with SMTP id d9443c01a7336-219e6ea8948mr44866765ad.22.1734705333728; Fri, 20 Dec 2024 06:35:33 -0800 (PST) Received: from ?IPV6:2409:8a28:f44:3764:dc48:fb1b:dd06:cba7? ([2409:8a28:f44:3764:dc48:fb1b:dd06:cba7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc9704dbsm29773545ad.98.2024.12.20.06.35.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 06:35:32 -0800 (PST) Message-ID: <0725252d-1339-4841-bc1d-6cf9e82b2170@bytedance.com> Date: Fri, 20 Dec 2024 22:35:23 +0800 Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/10] mm: Move common parts of pagetable_*_[cd]tor to helpers Content-Language: en-US To: Kevin Brodsky Cc: Peter Zijlstra , linux-mm@kvack.org, Andrew Morton , Catalin Marinas , Dave Hansen , Linus Walleij , Andy Lutomirski , "Mike Rapoport (IBM)" , Ryan Roberts , Thomas Gleixner , Will Deacon , Matthew Wilcox , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, loongarch@lists.linux.dev, x86@kernel.org, Alexander Gordeev References: <20241219164425.2277022-1-kevin.brodsky@arm.com> <20241219164425.2277022-2-kevin.brodsky@arm.com> <20241219171920.GB26279@noisy.programming.kicks-ass.net> <75cb4ff8-eb0c-4519-a30a-f8be717ba278@arm.com> <0daabd32-cba4-4345-baa8-e8c66bc899ff@bytedance.com> <2f65f93e-9d44-4acc-b63c-8f5a35f59699@arm.com> <33ce9b58-4787-49cd-a7f2-34272cb3ecf7@bytedance.com> <7f5e6ac7-01ef-46c8-bc85-7f8399dadb19@arm.com> From: Qi Zheng In-Reply-To: <7f5e6ac7-01ef-46c8-bc85-7f8399dadb19@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2024/12/20 22:28, Kevin Brodsky wrote: > On 20/12/2024 15:16, Qi Zheng wrote: >>>> >>>> Did I miss something? >>>> >>>> My patch series is not only for cleanup, but also for fixes of >>>> UAF issue [1], so is it possible to rebase your patch series onto >>>> mine? I can post v3 ASAP. >>> >>> I see, yours should be merged first then. The issue is that yours would >>> depend on some of the patches in mine, not the other way round. >>> >>> My suggestion would then be for you to take patch 5, 6 and 7 from my >>> series, as they match Alexander's suggestions (and patch 5 is I think a >>> useful simplification), and replace patch 2 in your series with those. I >>> would then rebase my series on top and adapt it accordingly. Does that >>> sound reasonable? >> >> Sounds good. But maybe just patch 5 and 6. Because I actually did >> the work of your patch 7 in my patch 2 and 4. > > Yes that's fair! You'd have to do adapt my patch 7 to make it fit in > your series so I agree it makes more sense this way. Thanks! > >> >> So, is it okay to do something like the following? >> >> 1. I separate the ctor()/dtor() part from my patch 2, and then replace >>    the rest with your patch 6. >> 2. take your patch 5 form your series > > Sounds good to me! > > IIUC Dave Hansen gave his Acked-by for the x86 part of patch 6 [1], > would make sense to add it when you post your v3. OK, will add it! > >> >> If it's ok, I will post the v3 next Monday. ;) > > Perfect. I'm going offline tonight, when I come back in the new year > I'll review your v3 series and post a new version of this one. Thank you very much! And Happy New Year! > > Cheers, > - Kevin > > [1] > https://lore.kernel.org/linux-mm/a7398426-56d1-40b4-a1c9-40ae8c8a4b4b@intel.com/