From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincenzo Frascino Subject: Re: [PATCH v5 00/23] Unify vDSOs across more architectures Date: Thu, 28 Feb 2019 15:51:45 +0000 Message-ID: <0b7d7219-cc7f-9ef1-7945-b609b2f36597@arm.com> References: <20190222122430.21180-1-vincenzo.frascino@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Arnd Bergmann Cc: linux-arch , Shuah Khan , Rasmus Villemoes , Catalin Marinas , Daniel Lezcano , Will Deacon , Russell King , Ralf Baechle , Mark Salyzyn , Paul Burton , Dmitry Safonov <0x7f454c46@gmail.com>, Thomas Gleixner , Peter Collingbourne , Linux ARM List-Id: linux-arch.vger.kernel.org Hi Arnd, On 28/02/2019 13:54, Arnd Bergmann wrote: > On Thu, Feb 28, 2019 at 1:42 PM Vincenzo Frascino > wrote: >> >> On 28/02/2019 12:38, Arnd Bergmann wrote: >>> On Thu, Feb 28, 2019 at 1:09 PM Vincenzo Frascino >>> wrote: >>>> >>>> thank you for testing my code. >>>> >>>> On 28/02/2019 11:40, Arnd Bergmann wrote: >>>>> On Fri, Feb 22, 2019 at 1:25 PM Vincenzo Frascino >>>>> wrote: >>>>> ^ >>>>> >>>>> I think this is all harmless, but we need to limit the set of header files >>>>> that can be included indirectly when compiling the vdso in arm32 mode. >>>>> >>>> >>>> I agree with you on the principle, but I am unable to replicate the warnings. >>>> Did you make any customization to the default defconfig? What is the top >>>> commit-id you have on your tree? >>> >>> I observed this on top of v5.0-rc7 earlier, and have since rebased to >>> today's linux-next, where it still happens with the regular 'make defconfig', >>> on all compiler versions I have (4.8 through 8.1). >>> >> >> Thanks, I will try to rebase my patches on linux-next and see if I can reproduce it. > > I just found a related issue: when CONFIG_CPU_BIG_ENDIAN is > set, everything breaks in the compat vdso because of the included > arm64 headers in arm32 code. That should be easier to reproduce. > For the moment, I'm using this patch: > > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -103,7 +103,7 @@ config ARM64 > select GENERIC_STRNLEN_USER > select GENERIC_TIME_VSYSCALL > select GENERIC_GETTIMEOFDAY > - select GENERIC_COMPAT_VDSO > + select GENERIC_COMPAT_VDSO if !CPU_BIG_ENDIAN > select HANDLE_DOMAIN_IRQ > select HARDIRQS_SW_RESEND > select HAVE_PCI > > Thanks for this, but I can't still reproduce the issue. I rebased my patches on: commit 42fd8df9d1d9c83046226e771a4f5f3d05a706ff (tag: next-20190228, linux-next/master) and enabled CONFIG_CPU_BIG_ENDIAN. > Arnd > -- Regards, Vincenzo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com ([217.140.101.70]:50576 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727878AbfB1Pvt (ORCPT ); Thu, 28 Feb 2019 10:51:49 -0500 Subject: Re: [PATCH v5 00/23] Unify vDSOs across more architectures References: <20190222122430.21180-1-vincenzo.frascino@arm.com> From: Vincenzo Frascino Message-ID: <0b7d7219-cc7f-9ef1-7945-b609b2f36597@arm.com> Date: Thu, 28 Feb 2019 15:51:45 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: linux-arch , Linux ARM , Catalin Marinas , Will Deacon , Russell King , Ralf Baechle , Paul Burton , Daniel Lezcano , Thomas Gleixner , Mark Salyzyn , Peter Collingbourne , Shuah Khan , Dmitry Safonov <0x7f454c46@gmail.com>, Rasmus Villemoes Message-ID: <20190228155145.UOCfbFNT2UYyq7dGmqQgJmAiP_wxL1oQjM8mRT49fS4@z> Hi Arnd, On 28/02/2019 13:54, Arnd Bergmann wrote: > On Thu, Feb 28, 2019 at 1:42 PM Vincenzo Frascino > wrote: >> >> On 28/02/2019 12:38, Arnd Bergmann wrote: >>> On Thu, Feb 28, 2019 at 1:09 PM Vincenzo Frascino >>> wrote: >>>> >>>> thank you for testing my code. >>>> >>>> On 28/02/2019 11:40, Arnd Bergmann wrote: >>>>> On Fri, Feb 22, 2019 at 1:25 PM Vincenzo Frascino >>>>> wrote: >>>>> ^ >>>>> >>>>> I think this is all harmless, but we need to limit the set of header files >>>>> that can be included indirectly when compiling the vdso in arm32 mode. >>>>> >>>> >>>> I agree with you on the principle, but I am unable to replicate the warnings. >>>> Did you make any customization to the default defconfig? What is the top >>>> commit-id you have on your tree? >>> >>> I observed this on top of v5.0-rc7 earlier, and have since rebased to >>> today's linux-next, where it still happens with the regular 'make defconfig', >>> on all compiler versions I have (4.8 through 8.1). >>> >> >> Thanks, I will try to rebase my patches on linux-next and see if I can reproduce it. > > I just found a related issue: when CONFIG_CPU_BIG_ENDIAN is > set, everything breaks in the compat vdso because of the included > arm64 headers in arm32 code. That should be easier to reproduce. > For the moment, I'm using this patch: > > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -103,7 +103,7 @@ config ARM64 > select GENERIC_STRNLEN_USER > select GENERIC_TIME_VSYSCALL > select GENERIC_GETTIMEOFDAY > - select GENERIC_COMPAT_VDSO > + select GENERIC_COMPAT_VDSO if !CPU_BIG_ENDIAN > select HANDLE_DOMAIN_IRQ > select HARDIRQS_SW_RESEND > select HAVE_PCI > > Thanks for this, but I can't still reproduce the issue. I rebased my patches on: commit 42fd8df9d1d9c83046226e771a4f5f3d05a706ff (tag: next-20190228, linux-next/master) and enabled CONFIG_CPU_BIG_ENDIAN. > Arnd > -- Regards, Vincenzo