public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: Linux Arch list <linux-arch@vger.kernel.org>
Subject: Re: More DMA API junk
Date: Tue, 16 Mar 2004 14:53:52 +1100	[thread overview]
Message-ID: <1079409231.1967.229.camel@gaston> (raw)
In-Reply-To: <1079408930.2158.408.camel@mulgrave>


> On your platform, dma_sync_single_range() has a defined meaning for
> streaming mappings.  dma_cache_sync will be a nop, so they're not
> interchangeable.

Ok, so we should make that clear in DMA-API.txt, currently it's
definitely not ;) I'll propose a patch later on if nobody beats me
on this.

> You're confused about what it's used for.  It's designed only to be
> called on memory allocated by dma_alloc_noncoherent() and tells you if
> that API actually returned coherent memory or not.  This was designed
> for ARM which has a limited range of allocateable coherent memory and
> then would need to fail dma_alloc_coherent() or, in the case of
> dma_alloc_noncoherent() begin handing out ordinary kmalloc'd memory.

I still have a problem with the argument. We should pass at least both
the virtual and physical address then. Or also make it clear in the
DMA-API.txt that it is only valid on the result of dma_alloc_noncoherent
in which case it becomes legal for me to hard-wire a result of 1.

Ben

  reply	other threads:[~2004-03-16  3:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-16  0:53 More DMA API junk Benjamin Herrenschmidt
2004-03-16  1:12 ` James Bottomley
2004-03-16  1:32   ` Benjamin Herrenschmidt
2004-03-16  3:24     ` James Bottomley
2004-03-16  3:32       ` Benjamin Herrenschmidt
2004-03-16  3:48         ` James Bottomley
2004-03-16  3:53           ` Benjamin Herrenschmidt [this message]
2004-03-16 11:17           ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1079409231.1967.229.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=James.Bottomley@steeleye.com \
    --cc=linux-arch@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox