Re: static DEFINE_PER_CPU vs. modules

[Rusty Russell <rusty@rustcorp.com.au>]

On Wed, 2004-05-05 at 18:21, Arnd Bergmann wrote:
> On Tuesday 04 May 2004 21:45, David Mosberger wrote:
> >   Andrew> But then things will work OK on x86 but there's a risk that
> >   Andrew> s390 will see duplicated symbols at link-time.  Admittedly
> >   Andrew> the risk is pretty low, but in that case the risk is also
> >   Andrew> low on other architectures, so they can live with making the
> >   Andrew> symbols global.
> > 
> >   Andrew> What's the concern?  Just the tidiness thing?
> > 
> > It's wrong to change the kernel just because it happens to be the easy
> > way out.

Arnd,

	I agree with David Mosberger-Tang.  If there is no simpler way, do what
other archs do: make your module_alloc() allocate in a restricted
range.  Then have your own setup_per_cpu_areas() allocate from that
space, too, at boot.

This will solve the problem.  I realized this might be an issue when I
wrote this code, but wasn't aware of an existing arch which required it.

Hope that helps (took some time off, sorry for delayed response)
Rusty.
-- 
Anyone who quotes me in their signature is an idiot -- Rusty Russell