From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Linux Arch list <linux-arch@vger.kernel.org>
Subject: Re: [RFC] Add NO_IRQ to all architectures
Date: Tue, 26 Oct 2004 12:31:22 +1000 [thread overview]
Message-ID: <1098757882.17887.35.camel@gaston> (raw)
In-Reply-To: <Pine.LNX.4.58.0410251926340.427@ppc970.osdl.org>
On Mon, 2004-10-25 at 19:27 -0700, Linus Torvalds wrote:
>
> On Tue, 26 Oct 2004, Benjamin Herrenschmidt wrote:
> >
> > Here'd a patch adding a definition of NO_IRQ to all archs include/asm-*/irq.h.
>
> ..and is there any reason to make it arch-specific?
>
> iow, I really can't imagine it not being ok to just have a global
>
> #define NO_IRQ (-1)
>
> in one place, rather than in every arch.
Hehe... just after I went through all include/asm-*/... :)
Well, the reason I did it that way is that I wasn't sure an arch
wouldn't want to revert to 0 ... like x86 to be more "backward
compatible" or to better match what probe_irq_* does ...
Note to Willy: In the long run, the irq number should indeed be a
typedef, it would be nice indeed to hide it in a structure, with some
ISA_TO_IRQ and IRQ_TO_ISA for drivers who care about legacy numbers
maybe ?
Ben.
next prev parent reply other threads:[~2004-10-26 2:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-26 2:08 [RFC] Add NO_IRQ to all architectures Benjamin Herrenschmidt
2004-10-26 2:17 ` William Lee Irwin III
2004-10-26 2:27 ` Linus Torvalds
2004-10-26 2:31 ` Benjamin Herrenschmidt [this message]
2004-10-26 2:41 ` William Lee Irwin III
2004-10-26 8:24 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1098757882.17887.35.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=linux-arch@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox