From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Weimer Subject: Re: [RFC PATCH v2 20/27] x86/cet/shstk: ELF header parsing of CET Date: Wed, 11 Jul 2018 13:12:57 +0200 Message-ID: <10c224e9-933a-20d8-a286-5065a6cb10f1@redhat.com> References: <20180710222639.8241-1-yu-cheng.yu@intel.com> <20180710222639.8241-21-yu-cheng.yu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180710222639.8241-21-yu-cheng.yu@intel.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Yu-cheng Yu , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek Peter List-Id: linux-arch.vger.kernel.org On 07/11/2018 12:26 AM, Yu-cheng Yu wrote: > + /* > + * PT_NOTE segment is small. Read at most > + * PAGE_SIZE. > + */ > + if (note_size > PAGE_SIZE) > + note_size = PAGE_SIZE; That's not really true. There are some huge PT_NOTE segments out there. Why can't you check the notes after the executable has been mapped? Thanks, Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:40474 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732387AbeGKLQw (ORCPT ); Wed, 11 Jul 2018 07:16:52 -0400 Subject: Re: [RFC PATCH v2 20/27] x86/cet/shstk: ELF header parsing of CET References: <20180710222639.8241-1-yu-cheng.yu@intel.com> <20180710222639.8241-21-yu-cheng.yu@intel.com> From: Florian Weimer Message-ID: <10c224e9-933a-20d8-a286-5065a6cb10f1@redhat.com> Date: Wed, 11 Jul 2018 13:12:57 +0200 MIME-Version: 1.0 In-Reply-To: <20180710222639.8241-21-yu-cheng.yu@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Yu-cheng Yu , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , "Ravi V. Shankar" , Vedvyas Shanbhogue Message-ID: <20180711111257.zZQu7lHlvthKKuq543kl72TJX6YSwYSWGmLAWH2DFT8@z> On 07/11/2018 12:26 AM, Yu-cheng Yu wrote: > + /* > + * PT_NOTE segment is small. Read at most > + * PAGE_SIZE. > + */ > + if (note_size > PAGE_SIZE) > + note_size = PAGE_SIZE; That's not really true. There are some huge PT_NOTE segments out there. Why can't you check the notes after the executable has been mapped? Thanks, Florian