From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation From: Alan Cox In-Reply-To: <3874.1134480759@warthog.cambridge.redhat.com> References: <1134479118.11732.14.camel@localhost.localdomain> <3874.1134480759@warthog.cambridge.redhat.com> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Tue, 13 Dec 2005 14:00:08 +0000 Message-Id: <1134482408.11732.30.camel@localhost.localdomain> Mime-Version: 1.0 To: David Howells Cc: torvalds@osdl.org, akpm@osdl.org, hch@infradead.org, arjan@infradead.org, matthew@wil.cx, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org List-ID: On Maw, 2005-12-13 at 13:32 +0000, David Howells wrote: > > Its then obvious what it does, you don't randomly break other drivers you've > > not reviewed and the interface is intuitive rather than obfuscated. > > I've attempted to review everything in 2.6.15-rc5 outside of most of the archs. > I can't easily modify any driver not contained in that tarball, but at least > the compiler will barf and force a review. Is there a reason you didnt answer the comment about down/up being the usual way computing refers to the operations on counting semaphores but just deleted it ?