From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh1-smtp.messagingengine.com (fhigh1-smtp.messagingengine.com [103.168.172.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 788EA1D2F43; Fri, 6 Sep 2024 17:20:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.152 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725643211; cv=none; b=YoqJjUDJcIzSIuCIb3baHpN95zExjAsw6TsEQkXoNkLffW+EwVp+aEXdaLD7EQqvgOsBkHExD8IO2zo4zniBcPB3nnNPvMJNwSdWiSqZ6cTnwOcT8+X8FGroK+W3kygJNbp/k5CXrVZQ/iD/iD92WwRREruclm5pfngMOL1IXk8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725643211; c=relaxed/simple; bh=hFsVCuWFovzKfydtu/2HfnueKRA8iG/FfmTYP+cgV60=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=n4pgNb35Ltt5qIrM8nSkrb6SYstEoEHr0gBZdwifNkYqZeKpwZ2K1Q523ZgLwLu+y7Ux2Dw851v0V2kovhOvG4nFnfcDQY6INI9xOnDg+2YozZnJ2kNIVjRSoHO6XBqYEr+Wi0LvTWJCEFlmviIH3wx6OcRzr0pFhNWaMCrKSPQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=GUTFNgtQ; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=U9R9wPK1; arc=none smtp.client-ip=103.168.172.152 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="GUTFNgtQ"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="U9R9wPK1" Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfhigh.phl.internal (Postfix) with ESMTP id 8FB57114017E; Fri, 6 Sep 2024 13:20:08 -0400 (EDT) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Fri, 06 Sep 2024 13:20:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1725643208; x=1725729608; bh=pGqQNxsj9qfH9QsO5+3KB74ZxiKlh96u9meajutmSw8=; b= GUTFNgtQFspoqY52oTwNT8LGQnoU4H5uEN9RCeE6gsv3bwEHDlnVhLP50Pdu9Fu2 2kdGuRC787ra70SOi0UHXcegX3AHoLHukGeHXAxg56kIS58HVYC7w0+P/Sm2cSLN DlbIi+sdAUcRaOLVdAU1qUpy/WCbNDNwKiSA6lU8WR8S55y1WdO/oJyoHm07EssY osYOgAcVNnf8/sawYqWKezWV/nLNODEen6w+s2P8IiLxkOjLiI4YkBD/VLV0Q/Nl 6LgaZTm7eHbRfQmgYIxXLKmyMpGoLDZRf0mr70S4kMDxBizzrN9ysSeLtNhthK// LeElrKukKR3n4/4pKHbsYg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1725643208; x= 1725729608; bh=pGqQNxsj9qfH9QsO5+3KB74ZxiKlh96u9meajutmSw8=; b=U 9R9wPK1G+49xOApyDsYUf3Fu3yQ5Vpd576/nOMIoIbwoax7odlvHHdYUQdZREVmx QM0CI//E+Bd1YBnjFtXWJqWAI/+gS2W6Br6mrc9hWBYIotQZp/LIjc1yeih9r2RK YSX5FTqLJ28Y/ekzoUfrJHsdpTQx1lH9uBInGAazEeAImpPc248R57rdLjcJKh7b FC0zG3bUZ7bgUI1Ypp1mUO+ZpoF4QLx2p8qce88pDSkAhmKPZFCRg7cpuojXe9Zb uwIPs45uyLTqZzS06qMWOb1tRyHBPRe70+6F2cKBNHPLL0PizwmXMCaEqWbgDz02 WNjstbFo++LL9oHYolAiw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudeiuddguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthejredtredt tdenucfhrhhomhepfdetrhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusg druggvqeenucggtffrrghtthgvrhhnpefhtdfhvddtfeehudekteeggffghfejgeegteef gffgvedugeduveelvdekhfdvieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggvpdhnsggprhgtphhtthhopedv tddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepsghpsegrlhhivghnkedruggvpd hrtghpthhtohepvhhinhgtvghniihordhfrhgrshgtihhnohesrghrmhdrtghomhdprhgt phhtthhopegthhhrihhsthhophhhvgdrlhgvrhhohiestghsghhrohhuphdrvghupdhrtg hpthhtohepmhgrthhhihgvuhdruggvshhnohihvghrshesvghffhhitghiohhsrdgtohhm pdhrtghpthhtohepmhhpvgesvghllhgvrhhmrghnrdhiugdrrghupdhrtghpthhtohepnh hpihhgghhinhesghhmrghilhdrtghomhdprhgtphhtthhopehrohhsthgvughtsehgohho ughmihhsrdhorhhgpdhrtghpthhtoheplhhuthhosehkvghrnhgvlhdrohhrghdprhgtph htthhopehmhhhirhgrmhgrtheskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 2F9C7222006F; Fri, 6 Sep 2024 13:20:07 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Fri, 06 Sep 2024 19:19:46 +0000 From: "Arnd Bergmann" To: "Vincenzo Frascino" , linux-kernel@vger.kernel.org, Linux-Arch , linux-mm@kvack.org Cc: "Andy Lutomirski" , "Thomas Gleixner" , "Jason A . Donenfeld" , "Christophe Leroy" , "Michael Ellerman" , "Nicholas Piggin" , "Naveen N Rao" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , "H. Peter Anvin" , "Theodore Ts'o" , "Andrew Morton" , "Steven Rostedt" , "Masami Hiramatsu" , "Mathieu Desnoyers" Message-Id: <11527a80-7453-4624-b406-e88c5692b015@app.fastmail.com> In-Reply-To: References: <20240903151437.1002990-1-vincenzo.frascino@arm.com> <20240903151437.1002990-4-vincenzo.frascino@arm.com> Subject: Re: [PATCH 3/9] x86: vdso: Introduce asm/vdso/page.h Content-Type: text/plain Content-Transfer-Encoding: 7bit On Fri, Sep 6, 2024, at 11:20, Vincenzo Frascino wrote: > On 04/09/2024 15:52, Arnd Bergmann wrote: >> On Tue, Sep 3, 2024, at 15:14, Vincenzo Frascino wrote: > Looking at the definition of PAGE_SIZE and PAGE_MASK for each architecture they > all depend on CONFIG_PAGE_SHIFT but they are slightly different, e.g.: > > x86: > #define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT) > > powerpc: > #define PAGE_SIZE (ASM_CONST(1) << PAGE_SHIFT) > > hence I left to the architecture the responsibility of redefining the constants > for the VSDO. ASM_CONST() is a powerpc-specific macro that is defined the same way as _AC(). We could probably just replace all ASM_CONST() as a cleanup, but for this purpose, just remove the custom PAGE_SIZE and PAGE_SHIFT macros. This can be a single patch fro all architectures. Arnd