public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <haveblue@us.ibm.com>
To: Paul Mundt <lethal@linux-sh.org>
Cc: linux-arch@vger.kernel.org
Subject: Re: [RFC][PATCH] unify all architecture PAGE_SIZE definitions
Date: Fri, 25 Aug 2006 08:03:43 -0700	[thread overview]
Message-ID: <1156518223.12011.175.camel@localhost.localdomain> (raw)
In-Reply-To: <20060825053127.GA9066@localhost.hsdv.com>

On Fri, 2006-08-25 at 14:31 +0900, Paul Mundt wrote:
> I like the idea of asm-generic/page_size.h (though why not just use
> asm-generic/page.h?)

asm-generic/page.h looks good.  I'll give it a shot.

> and ripping that out from the architecture headers,
> though the mm/Kconfig bits look like something best left in the
> architecture Kconfigs.
> 
> PAGE_SHIFT is really the only thing of interest, and that can be handled
> without the CONFIG_PAGE_SIZE mess. The architectures that really care
> about it can use their current hacks or just check PAGE_SHIFT. 

I just changed this around a little bit so that only the architectures
that care see the prompt:

> choice
>         prompt "Kernel Page Size"
>         depends on IA64 || SPARC64 || PARISC || MIPS
>         default PAGE_SIZE_4KB if MIPS
>         default PAGE_SIZE_8KB if IA64 || SPARC64 || PARISC
> config PAGE_SIZE_4KB
...

That at least consolidates the four architectures.  I guess I could move
them back, but some of the help text was _really_ similar and it all
seemed pretty redundant.

It wouldn't be hard to move it back, though.  That would certainly work.

-- Dave


  reply	other threads:[~2006-08-25 15:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-24 23:44 [RFC][PATCH] unify all architecture PAGE_SIZE definitions Dave Hansen
2006-08-24 23:58 ` William Lee Irwin III
2006-08-25  0:07   ` Dave Hansen
2006-08-25  0:14     ` William Lee Irwin III
2006-08-25  0:23       ` Dave Hansen
2006-08-25  0:32         ` William Lee Irwin III
2006-08-25  8:12           ` Geert Uytterhoeven
2006-08-25  5:31 ` Paul Mundt
2006-08-25 15:03   ` Dave Hansen [this message]
2006-08-26  1:17     ` Paul Mundt
2006-08-25 21:04   ` Dave Hansen
2006-08-25  8:11 ` Geert Uytterhoeven
2006-08-25 14:55   ` Dave Hansen
2006-08-25 15:07     ` Geert Uytterhoeven
2006-08-25 17:16 ` David Howells
2006-08-25 17:31   ` Dave Hansen
2006-09-11  0:51 ` Jeff Dike
2006-09-11 17:33   ` Dave Hansen
2006-09-11 18:43   ` Dave Hansen
2006-09-11 23:40     ` Jeff Dike
2006-09-11 13:34 ` Ralf Baechle
2006-09-11 17:43   ` Dave Hansen
     [not found] <BFECAF9E178F144FAEF2BF4CE739C66804016FA5@exmail1.se.axis.com>
2006-08-25  5:04 ` Mikael Starvik
  -- strict thread matches above, loose matches on Subject: below --
2006-08-25 16:06 Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1156518223.12011.175.camel@localhost.localdomain \
    --to=haveblue@us.ibm.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-arch@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox