From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Arch list <linux-arch@vger.kernel.org>,
Len Brown <len.brown@intel.com>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 1/2] Add arch specific dev_sysdata to struct device
Date: Sat, 11 Nov 2006 07:46:45 +1100 [thread overview]
Message-ID: <1163191605.4982.175.camel@localhost.localdomain> (raw)
In-Reply-To: <20061110234757.27677dcd.sfr@canb.auug.org.au>
On Fri, 2006-11-10 at 23:47 +1100, Stephen Rothwell wrote:
> On Fri, 10 Nov 2006 17:58:50 +1100 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > Adds an arch specific struct dev_sysdata to struct device. This enables
> > architecture to add specific fields to every device in the system, like
> > DMA operation pointers, NUMA node ID, firmware specific data, etc...
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> I would have done this by creating a single line asm-xxx/device.h containing
>
> #include <asm-generic/device.h>
A lot of archs will add custome things, so I felt it simpler that way,
but I can do it via asm-generic... Anybody else preferring it that
way ?
> (except for asm-generic, of course) and then as each architecture implements
> its own dev_sysdata, it can flesh out its asm/device.h.
>
> Also, I would use _ASM_<ARCH>_DEVICE_H, but thats just my preference.
Because I'm overly lazy, I prefer just cp'ing an identical file to all
asm-* dirs :-) Now I suppose it should be easy to do a little script to
get it "right". I'll look into it for the patch renaming it to
arch_data, I'll try to get that out later this morning.
Ben.
prev parent reply other threads:[~2006-11-10 20:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-10 6:58 [PATCH 1/2] Add arch specific dev_sysdata to struct device Benjamin Herrenschmidt
2006-11-10 12:47 ` Stephen Rothwell
2006-11-10 20:46 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163191605.4982.175.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox