From: Catalin Marinas <catalin.marinas@arm.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-arch@vger.kernel.org,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [RFC PATCH 0/9] Thumb-2 ISA kernel port
Date: Wed, 06 Jun 2007 22:19:07 +0100 [thread overview]
Message-ID: <1181164747.27659.7.camel@localhost.localdomain> (raw)
In-Reply-To: <20070606211042.GA7542@uranus.ravnborg.org>
On Wed, 2007-06-06 at 23:10 +0200, Sam Ravnborg wrote:
> On Wed, Jun 06, 2007 at 09:47:49PM +0100, Russell King - ARM Linux wrote:
> > On Wed, Jun 06, 2007 at 08:29:14PM +0200, Sam Ravnborg wrote:
> > > #define FUNCTION(name) .type name, %function
> > > Introducing this simple macro in the generic ARM codebase would
> > > bring down the diff significantly
> >
> > We have such a macro already - ENDPROC(). Recently introduced,
> > we should probably make more use of it.
> Took a short look at include/linux/linkage.h
> There is also ENTRY() that seems resonable to introduce.
The problem is that ENTRY is not used for functions only (I tried this
initially). The linker needs to know which .globl object is a function
because the Thumb-2 function addresses used in branch instructions have
bit 0 set (even if the address is 2 bytes aligned).
--
Catalin
next prev parent reply other threads:[~2007-06-06 21:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070606172409.6689.26641.stgit@localhost.localdomain>
2007-06-06 18:29 ` [RFC PATCH 0/9] Thumb-2 ISA kernel port Sam Ravnborg
2007-06-06 20:47 ` Russell King - ARM Linux
2007-06-06 21:10 ` Sam Ravnborg
2007-06-06 21:19 ` Catalin Marinas [this message]
2007-06-06 22:04 ` Russell King - ARM Linux
2007-06-06 22:01 ` Russell King - ARM Linux
2007-06-06 22:02 ` Catalin Marinas
2007-06-07 21:05 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1181164747.27659.7.camel@localhost.localdomain \
--to=catalin.marinas@arm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux@arm.linux.org.uk \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox