From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH 1/8] kernel: add common infrastructure for unaligned access Date: Thu, 10 Apr 2008 23:15:58 +0100 Message-ID: <11907.1207865758@redhat.com> References: <1207865183.22001.49.camel@brick> <1207864537.22001.47.camel@brick> <1207856646.22001.25.camel@brick> <11527.1207863801@redhat.com> <11814.1207864864@redhat.com> Return-path: In-Reply-To: <1207865183.22001.49.camel@brick> Sender: linux-arch-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: To: Harvey Harrison Cc: dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Andrew Morton , linux-arch Harvey Harrison wrote: > Expands to int, not unsigned int, I think that cast is still needed? What for? The return is going to do the same cast anyway because of the function return type. David From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([66.187.233.31]:34908 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753477AbYDJWQg (ORCPT ); Thu, 10 Apr 2008 18:16:36 -0400 From: David Howells In-Reply-To: <1207865183.22001.49.camel@brick> References: <1207865183.22001.49.camel@brick> <1207864537.22001.47.camel@brick> <1207856646.22001.25.camel@brick> <11527.1207863801@redhat.com> <11814.1207864864@redhat.com> Subject: Re: [PATCH 1/8] kernel: add common infrastructure for unaligned access Date: Thu, 10 Apr 2008 23:15:58 +0100 Message-ID: <11907.1207865758@redhat.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Harvey Harrison Cc: dhowells@redhat.com, Andrew Morton , linux-arch Message-ID: <20080410221558.EwBfD--0FXNjYmZXdjFlrEzUVMH-fdl4re25Ry1OobE@z> Harvey Harrison wrote: > Expands to int, not unsigned int, I think that cast is still needed? What for? The return is going to do the same cast anyway because of the function return type. David