* Re: mm snapshot broken-out-2007-11-13-04-14 Build Fails at memory.c
2007-11-13 14:43 ` mm snapshot broken-out-2007-11-13-04-14 Build Fails at memory.c Kamalesh Babulal
@ 2007-11-13 15:17 ` Martin Schwidefsky
2007-11-13 15:29 ` Martin Schwidefsky
1 sibling, 0 replies; 3+ messages in thread
From: Martin Schwidefsky @ 2007-11-13 15:17 UTC (permalink / raw)
To: Kamalesh Babulal
Cc: akpm, mm-commits, linux-kernel, benh, linux-arch, Andy Whitcroft
On Tue, 2007-11-13 at 20:13 +0530, Kamalesh Babulal wrote:
> Hi Andrew,
>
> The kernel build fails, with following build error
>
> mm/memory.c: In function ‘free_pte_range’:
> mm/memory.c:126: error: implicit declaration of function ‘pmd_pgtable’
> mm/memory.c:126: warning: initialization makes pointer from integer without a cast
> mm/memory.c: In function ‘apply_to_pte_range’:
> mm/memory.c:1389: warning: assignment makes pointer from integer without a cast
> make[1]: *** [mm/memory.o] Error 1
> make: *** [mm] Error 2
>
> The patch causing this issue is config_highpte-vs-sub-page-page-tables.patch.
> Where the marco is defined #ifndef CONFIG_PPC_64K_PAGES.
Hmm, the default config for ppc compiled. Can you send me the .config
for the failed compile? I'll fix it up.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mm snapshot broken-out-2007-11-13-04-14 Build Fails at memory.c
2007-11-13 14:43 ` mm snapshot broken-out-2007-11-13-04-14 Build Fails at memory.c Kamalesh Babulal
2007-11-13 15:17 ` Martin Schwidefsky
@ 2007-11-13 15:29 ` Martin Schwidefsky
1 sibling, 0 replies; 3+ messages in thread
From: Martin Schwidefsky @ 2007-11-13 15:29 UTC (permalink / raw)
To: Kamalesh Babulal
Cc: akpm, mm-commits, linux-kernel, benh, linux-arch, Andy Whitcroft
On Tue, 2007-11-13 at 20:13 +0530, Kamalesh Babulal wrote:
> Hi Andrew,
>
> The kernel build fails, with following build error
>
> mm/memory.c: In function ‘free_pte_range’:
> mm/memory.c:126: error: implicit declaration of function ‘pmd_pgtable’
> mm/memory.c:126: warning: initialization makes pointer from integer without a cast
> mm/memory.c: In function ‘apply_to_pte_range’:
> mm/memory.c:1389: warning: assignment makes pointer from integer without a cast
> make[1]: *** [mm/memory.o] Error 1
> make: *** [mm] Error 2
>
> The patch causing this issue is config_highpte-vs-sub-page-page-tables.patch.
> Where the marco is defined #ifndef CONFIG_PPC_64K_PAGES.
Forget the request for the .config. Found the problem, fixup patch
below.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
---
diff -urpN linux-2.6/include/asm-powerpc/pgalloc-64.h linux-2.6-patched/include/asm-powerpc/pgalloc-64.h
--- linux-2.6/include/asm-powerpc/pgalloc-64.h 2007-11-12 17:31:58.000000000 +0100
+++ linux-2.6-patched/include/asm-powerpc/pgalloc-64.h 2007-11-13 16:23:50.000000000 +0100
@@ -68,6 +68,7 @@ static inline void pmd_populate_kernel(s
#define pmd_populate(mm, pmd, pte_page) \
pmd_populate_kernel(mm, pmd, page_address(pte_page))
+#define pmd_pgtable(pmd) pmd_page(pmd)
#endif /* CONFIG_PPC_64K_PAGES */
^ permalink raw reply [flat|nested] 3+ messages in thread