Re: [PATCH 1/8] kernel: add common infrastructure for unaligned access

[David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

Harvey Harrison <harvey.harrison-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> Well, for the u16 case, won't the compiler warn about truncating the
> return if I return an int when the function returns u16?

It doesn't for me for:

	u16 test(const u8 *p)
	{
		return (u16) (p[0] | p[1] << 8);
	}

> In the u64 case, I need the cast to ensure it expands to u64 rather than
> int from the shift.  Agreed in the u32 case, but then it looks different
> than the u16/u64 case (cargo-cult I know, but nice for consistency).

Agreed, the u64 cast is necessary, but I was talking about casts generally of:

	<TYPE> function(...)
	{
		return (<TYPE>) (...);
	}

David