From: David Woodhouse <dwmw2@infradead.org>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Roland McGrath <roland@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-s390@vger.kernel.org, tony.luck@intel.com,
linux-ia64@vger.kernel.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING
Date: Wed, 09 Apr 2008 19:40:33 +0100 [thread overview]
Message-ID: <1207766433.27048.86.camel@shinybook.infradead.org> (raw)
In-Reply-To: <20080409162206.GA764@tv-sign.ru>
On Wed, 2008-04-09 at 20:22 +0400, Oleg Nesterov wrote:
> On 04/09, David Woodhouse wrote:
> >
> > One of the supposed advantages of TIF_RESTORE_SIGMASK in the first
> > place, iirc, was that it allowed us to return a result code other than
> > -EINTR as _well_ as restoring the signal mask.
>
> Agreed, good point. ERESTART_ is not that flexible.
>
> Somehow I assumed we will never need something "special" here, this is
> not very clever.
Well, it's not clear that we _will_ need it to be so special. You could
perhaps argue that it's overengineering. It's just that at the time I
did it, I _thought_ I'd need it for ppoll().
It's only in later optimisations that I realised we only ever really
needed to use TIF_RESTORE_SIGMASK in the case where ppoll() or pselect()
was interrupted.
--
dwmw2
next prev parent reply other threads:[~2008-04-09 18:40 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-29 0:12 [PATCH 1/4] set_restore_sigmask Roland McGrath
2008-03-29 0:12 ` Roland McGrath
[not found] ` <20080329001230.D013726FA1D-nL1rrgvulkcB9AHHLWeGtNQXobZC6xk2@public.gmane.org>
2008-03-29 0:13 ` [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING Roland McGrath
2008-03-29 0:13 ` Roland McGrath
[not found] ` <20080329001341.7F93826FA1D-nL1rrgvulkcB9AHHLWeGtNQXobZC6xk2@public.gmane.org>
2008-03-29 0:53 ` Linus Torvalds
2008-03-29 0:53 ` Linus Torvalds
[not found] ` <alpine.LFD.1.00.0803281746480.14670-5CScLwifNT1QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2008-03-29 2:24 ` Roland McGrath
2008-03-29 2:24 ` Roland McGrath
2008-03-29 2:52 ` Linus Torvalds
2008-03-29 2:52 ` Linus Torvalds
[not found] ` <alpine.LFD.1.00.0803281942440.14670-5CScLwifNT1QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2008-03-29 3:12 ` Roland McGrath
2008-03-29 3:12 ` Roland McGrath
[not found] ` <20080329022408.0DD4726FA1D-nL1rrgvulkcB9AHHLWeGtNQXobZC6xk2@public.gmane.org>
2008-03-29 3:11 ` [PATCH 1/2] HAVE_SET_RESTORE_SIGMASK Roland McGrath
2008-03-29 3:11 ` Roland McGrath
2008-04-09 11:45 ` David Woodhouse
2008-04-09 11:45 ` David Woodhouse
2008-04-10 20:32 ` Russell King
2008-04-10 20:32 ` Russell King
[not found] ` <20080410203250.GA21589-f404yB8NqCZvn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2008-04-11 13:40 ` David Woodhouse
2008-04-11 13:40 ` David Woodhouse
2008-03-29 3:14 ` Roland McGrath
2008-03-29 3:14 ` Roland McGrath
2008-03-29 3:14 ` [PATCH 2/2] x86 TS_RESTORE_SIGMASK Roland McGrath
2008-03-29 3:14 ` Roland McGrath
2008-03-31 13:01 ` Ingo Molnar
2008-03-31 13:01 ` Ingo Molnar
2008-03-31 19:30 ` Roland McGrath
2008-03-31 19:30 ` Roland McGrath
2008-03-30 10:53 ` [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING Paul Mackerras
2008-03-30 10:53 ` Paul Mackerras
2008-04-08 11:35 ` Oleg Nesterov
2008-04-08 11:35 ` Oleg Nesterov
[not found] ` <20080408113519.GA227-6lXkIZvqkOAvJsYlp49lxw@public.gmane.org>
2008-04-08 14:53 ` Linus Torvalds
2008-04-08 14:53 ` Linus Torvalds
2008-04-08 19:51 ` Roland McGrath
2008-04-08 19:51 ` Roland McGrath
2008-04-09 11:16 ` David Woodhouse
2008-04-09 11:16 ` David Woodhouse
[not found] ` <1207739787.27048.57.camel-Fexsq3y4057IgHVZqg5X0TlWvGAXklZc@public.gmane.org>
2008-04-09 11:39 ` Oleg Nesterov
2008-04-09 11:39 ` Oleg Nesterov
2008-04-09 12:57 ` Petr Tesarik
2008-04-09 12:57 ` Petr Tesarik
[not found] ` <20080409113939.GA99-6lXkIZvqkOAvJsYlp49lxw@public.gmane.org>
2008-04-09 16:14 ` David Woodhouse
2008-04-09 16:14 ` David Woodhouse
2008-04-09 16:22 ` Oleg Nesterov
2008-04-09 16:22 ` Oleg Nesterov
2008-04-09 18:40 ` David Woodhouse [this message]
2008-04-09 18:40 ` David Woodhouse
2008-03-29 0:14 ` [PATCH 3/4] s390 renumber TIF_RESTORE_SIGMASK Roland McGrath
2008-03-29 0:14 ` Roland McGrath
2008-03-31 7:53 ` Martin Schwidefsky
2008-03-31 7:53 ` Martin Schwidefsky
2008-03-29 0:14 ` [PATCH 4/4] ia64 " Roland McGrath
2008-03-29 0:14 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207766433.27048.86.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=roland@redhat.com \
--cc=schwidefsky@de.ibm.com \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox