From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harvey Harrison Subject: Re: [PATCHv3 2/2] kernel: Move arches to use common unaligned access Date: Mon, 14 Apr 2008 09:52:06 -0700 Message-ID: <1208191926.5721.37.camel@brick> References: <1207950449.22001.106.camel@brick> <4392.1208169129@redhat.com> <20080414111119.GA6228@flint.arm.linux.org.uk> <1208190432.5721.1.camel@brick> <20080414163448.GA8473@flint.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080414163448.GA8473-f404yB8NqCZvn6HldHNs0ANdhmdF6hFW@public.gmane.org> Sender: linux-arch-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: To: Russell King Cc: Andrew Morton , Linus Torvalds , David Howells , linux-arch On Mon, 2008-04-14 at 17:34 +0100, Russell King wrote: > On Mon, Apr 14, 2008 at 09:27:12AM -0700, Harvey Harrison wrote: > > On Mon, 2008-04-14 at 12:11 +0100, Russell King wrote: > > > On Mon, Apr 14, 2008 at 11:32:09AM +0100, David Howells wrote: > > > > Harvey Harrison wrote: > > > > > > > > > -#ifndef _ASM_UNALIGNED_H > > > > > -#define _ASM_UNALIGNED_H > > > > > +#ifndef _ASM_FRV_UNALIGNED_H_ > > > > > +#define _ASM_FRV_UNALIGNED_H_ > > > > > > > > Please don't. Why do you need to change these to make your patch work? > > > > > > Indeed - ditto for the ARM changes. The patch is changing them to a > > > different style to the others in the respective asm/ directories - > > > which is also different from the linux/ directory. > > > > > > IMHO, if Harvey wishes to clean those up, then that should be a separate > > > patch and should be part of a set converting all includes to use the > > > same style. > > > > > > > OK, I'll revise without these changes. I am curious what the preferred > > 'linux' style is (if there is one). > > The one that's already established by the majority is one answer. 8) > > $ grep '^#ifndef LINUX_.*_H$' include/linux/*.h | wc -l > 33 > $ grep '^#ifndef _LINUX_.*_H$' include/linux/*.h | wc -l > 388 > $ grep '^#ifndef __LINUX_.*_H$' include/linux/*.h | wc -l > 110 > $ grep '^#ifndef LINUX_.*_H_$' include/linux/*.h | wc -l > 1 > $ grep '^#ifndef LINUX_.*_H__$' include/linux/*.h | wc -l > 0 > $ grep '^#ifndef _LINUX_.*_H_$' include/linux/*.h | wc -l > 20 > $ grep '^#ifndef __LINUX_.*_H__$' include/linux/*.h | wc -l > 20 > > So it seems _LINUX_FOO_H for linux/foo.h wins. > > But... honestly, I wouldn't bother with such a cleanup - at the end of > the day, it's personal choice and people are always going to do something > slightly different. So it's probably best all round to just accept what's > already in the files you're modifying. > > Let's not add to the expanding beaurocracy by demanding a format for these > macro names. > Well, I'm not interested in a comprehensive cleanup here, but as I am changing every arch's asm/unaligned.h, may as well at least do those ones. Would you accept my patch with ARM's changed to _ASM_ARM_UNALIGNED_H? Harvey From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from el-out-1112.google.com ([209.85.162.183]:55716 "EHLO el-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754988AbYDNQwI (ORCPT ); Mon, 14 Apr 2008 12:52:08 -0400 Received: by el-out-1112.google.com with SMTP id n30so64465elf.21 for ; Mon, 14 Apr 2008 09:52:06 -0700 (PDT) Subject: Re: [PATCHv3 2/2] kernel: Move arches to use common unaligned access From: Harvey Harrison In-Reply-To: <20080414163448.GA8473@flint.arm.linux.org.uk> References: <1207950449.22001.106.camel@brick> <4392.1208169129@redhat.com> <20080414111119.GA6228@flint.arm.linux.org.uk> <1208190432.5721.1.camel@brick> <20080414163448.GA8473@flint.arm.linux.org.uk> Content-Type: text/plain Date: Mon, 14 Apr 2008 09:52:06 -0700 Message-ID: <1208191926.5721.37.camel@brick> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Russell King Cc: Andrew Morton , Linus Torvalds , David Howells , linux-arch Message-ID: <20080414165206.YVEXGpIeFzgveKx8KdOHSPKe7sZ6atntXWxWlnnUL9A@z> On Mon, 2008-04-14 at 17:34 +0100, Russell King wrote: > On Mon, Apr 14, 2008 at 09:27:12AM -0700, Harvey Harrison wrote: > > On Mon, 2008-04-14 at 12:11 +0100, Russell King wrote: > > > On Mon, Apr 14, 2008 at 11:32:09AM +0100, David Howells wrote: > > > > Harvey Harrison wrote: > > > > > > > > > -#ifndef _ASM_UNALIGNED_H > > > > > -#define _ASM_UNALIGNED_H > > > > > +#ifndef _ASM_FRV_UNALIGNED_H_ > > > > > +#define _ASM_FRV_UNALIGNED_H_ > > > > > > > > Please don't. Why do you need to change these to make your patch work? > > > > > > Indeed - ditto for the ARM changes. The patch is changing them to a > > > different style to the others in the respective asm/ directories - > > > which is also different from the linux/ directory. > > > > > > IMHO, if Harvey wishes to clean those up, then that should be a separate > > > patch and should be part of a set converting all includes to use the > > > same style. > > > > > > > OK, I'll revise without these changes. I am curious what the preferred > > 'linux' style is (if there is one). > > The one that's already established by the majority is one answer. 8) > > $ grep '^#ifndef LINUX_.*_H$' include/linux/*.h | wc -l > 33 > $ grep '^#ifndef _LINUX_.*_H$' include/linux/*.h | wc -l > 388 > $ grep '^#ifndef __LINUX_.*_H$' include/linux/*.h | wc -l > 110 > $ grep '^#ifndef LINUX_.*_H_$' include/linux/*.h | wc -l > 1 > $ grep '^#ifndef LINUX_.*_H__$' include/linux/*.h | wc -l > 0 > $ grep '^#ifndef _LINUX_.*_H_$' include/linux/*.h | wc -l > 20 > $ grep '^#ifndef __LINUX_.*_H__$' include/linux/*.h | wc -l > 20 > > So it seems _LINUX_FOO_H for linux/foo.h wins. > > But... honestly, I wouldn't bother with such a cleanup - at the end of > the day, it's personal choice and people are always going to do something > slightly different. So it's probably best all round to just accept what's > already in the files you're modifying. > > Let's not add to the expanding beaurocracy by demanding a format for these > macro names. > Well, I'm not interested in a comprehensive cleanup here, but as I am changing every arch's asm/unaligned.h, may as well at least do those ones. Would you accept my patch with ARM's changed to _ASM_ARM_UNALIGNED_H? Harvey