From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH 3/3] Use __weak macro for smp_setup_processor_id Date: Fri, 18 Apr 2008 18:19:07 +1000 Message-ID: <1208506747.6958.402.camel@pasglop> References: <20080418065728.31AF4DE255@ozlabs.org> <20080418000717.5a9c9758.akpm@linux-foundation.org> Reply-To: benh@kernel.crashing.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080418000717.5a9c9758.akpm@linux-foundation.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org To: Andrew Morton Cc: Linux-Arch , linuxppc-dev@ozlabs.org, Paul Mackerras , linux-kernel@vger.kernel.org List-Id: linux-arch.vger.kernel.org On Fri, 2008-04-18 at 00:07 -0700, Andrew Morton wrote: > On Fri, 18 Apr 2008 16:56:18 +1000 Benjamin Herrenschmidt wrote: > > > Use the __weak macro instead of the longer __attribute__ ((weak)) form > > > > Signed-off-by: Benjamin Herrenschmidt > > -- > > > > init/main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- linux-work.orig/init/main.c 2008-04-18 16:44:32.000000000 +1000 > > +++ linux-work/init/main.c 2008-04-18 16:44:37.000000000 +1000 > > @@ -500,7 +500,7 @@ static void __init boot_cpu_init(void) > > cpu_set(cpu, cpu_possible_map); > > } > > > > -void __init __attribute__((weak)) smp_setup_processor_id(void) > > +void __init __weak smp_setup_processor_id(void) > > { > > } > > ack on all three. Please fold #3 into #1 and add both to git-powerpc. Damn ! I took 5mn to actually split it out in order to not do two different things in one patch :-) Will do. Cheers, Ben. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org ([63.228.1.57]:42146 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755940AbYDRITU (ORCPT ); Fri, 18 Apr 2008 04:19:20 -0400 Subject: Re: [PATCH 3/3] Use __weak macro for smp_setup_processor_id From: Benjamin Herrenschmidt Reply-To: benh@kernel.crashing.org In-Reply-To: <20080418000717.5a9c9758.akpm@linux-foundation.org> References: <20080418065728.31AF4DE255@ozlabs.org> <20080418000717.5a9c9758.akpm@linux-foundation.org> Content-Type: text/plain Date: Fri, 18 Apr 2008 18:19:07 +1000 Message-ID: <1208506747.6958.402.camel@pasglop> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Andrew Morton Cc: Paul Mackerras , linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, Linux-Arch Message-ID: <20080418081907.aP5kwWkapLyobvgoLBEBq4Wqz2O0K7Li8f8wO15L1PM@z> On Fri, 2008-04-18 at 00:07 -0700, Andrew Morton wrote: > On Fri, 18 Apr 2008 16:56:18 +1000 Benjamin Herrenschmidt wrote: > > > Use the __weak macro instead of the longer __attribute__ ((weak)) form > > > > Signed-off-by: Benjamin Herrenschmidt > > -- > > > > init/main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- linux-work.orig/init/main.c 2008-04-18 16:44:32.000000000 +1000 > > +++ linux-work/init/main.c 2008-04-18 16:44:37.000000000 +1000 > > @@ -500,7 +500,7 @@ static void __init boot_cpu_init(void) > > cpu_set(cpu, cpu_possible_map); > > } > > > > -void __init __attribute__((weak)) smp_setup_processor_id(void) > > +void __init __weak smp_setup_processor_id(void) > > { > > } > > ack on all three. Please fold #3 into #1 and add both to git-powerpc. Damn ! I took 5mn to actually split it out in order to not do two different things in one patch :-) Will do. Cheers, Ben.