From: Joe Perches <joe@perches.com>
To: monstr@seznam.cz
Cc: paulus@samba.org, arnd@arndb.de, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, Michal Simek <monstr@monstr.eu>
Subject: Re: [PATCH 1/2] OF: clean coding style - prom_parse.c
Date: Sat, 03 May 2008 10:26:22 -0700 [thread overview]
Message-ID: <1209835583.16966.10.camel@localhost> (raw)
In-Reply-To: <c382f7ff87d1502c20423742ad738e50a118cf62.1209827449.git.monstr@monstr.eu>
On Sat, 2008-05-03 at 17:13 +0200, monstr@seznam.cz wrote:
> /* Debug utility */
> #ifdef DEBUG
> static void of_dump_addr(const char *s, const u32 *addr, int na)
> {
> - printk("%s", s);
> - while(na--)
> - printk(" %08x", *(addr++));
> - printk("\n");
> + printk(KERN_INFO "%s", s);
> + while (na--)
> + printk(KERN_INFO " %08x", *(addr++));
> + printk(KERN_INFO "\n");
> }
You've prefixed KERN_INFO before every address block.
How about:
print_hex_dump(KERN_<level>, s, DUMP_PREFIX_NONE, 4, addr, na, false);
next prev parent reply other threads:[~2008-05-03 17:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-03 15:13 Clean PROM_PARSE.C file monstr
2008-05-03 15:13 ` [PATCH 1/2] OF: clean coding style - prom_parse.c monstr
2008-05-03 15:13 ` [PATCH 2/2] OF: move prom_parse to drivers/of folder monstr
2008-05-03 17:25 ` [PATCH 1/2] OF: clean coding style - prom_parse.c Jiri Slaby
2008-05-03 17:26 ` Joe Perches [this message]
2008-05-04 8:17 ` Michal Simek
2008-05-04 15:51 ` Jiri Slaby
2008-05-04 16:18 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209835583.16966.10.camel@localhost \
--to=joe@perches.com \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=monstr@seznam.cz \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox