* [PATCH 02/37] powerpc: use get/put_endian helpers
@ 2008-05-29 20:17 Harvey Harrison
2008-05-30 3:33 ` Paul Mackerras
0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-05-29 20:17 UTC (permalink / raw)
To: Andrew Morton; +Cc: Paul Mackerras, linux-arch
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
arch/powerpc/sysdev/qe_lib/qe.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/sysdev/qe_lib/qe.c b/arch/powerpc/sysdev/qe_lib/qe.c
index cff550e..7981205 100644
--- a/arch/powerpc/sysdev/qe_lib/qe.c
+++ b/arch/powerpc/sysdev/qe_lib/qe.c
@@ -528,7 +528,7 @@ int qe_upload_firmware(const struct qe_firmware *firmware)
}
/* Validate the CRC */
- crc = be32_to_cpu(*(__be32 *)((void *)firmware + calc_size));
+ crc = get_be32((__be32 *)((void *)firmware + calc_size));
if (crc != crc32(0, firmware, calc_size)) {
printk(KERN_ERR "qe-firmware: firmware CRC is invalid\n");
return -EIO;
--
1.5.6.rc0.277.g804cf
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 02/37] powerpc: use get/put_endian helpers
2008-05-29 20:17 [PATCH 02/37] powerpc: use get/put_endian helpers Harvey Harrison
@ 2008-05-30 3:33 ` Paul Mackerras
0 siblings, 0 replies; 2+ messages in thread
From: Paul Mackerras @ 2008-05-30 3:33 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Andrew Morton, linux-arch
Harvey Harrison writes:
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
Somewhere in this series of patches there should be a patch
description that tells us why we're making all these changes. I don't
know what the motivation for them is and I don't see it spelled out
anywhere. If/when these patches go into git there needs to be at
least one of the commits whose description records the motivation for
posterity.
Paul.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-30 3:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-29 20:17 [PATCH 02/37] powerpc: use get/put_endian helpers Harvey Harrison
2008-05-30 3:33 ` Paul Mackerras
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox