public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 09/37] firewire: use get/put_endian helpers
@ 2008-05-29 20:18 Harvey Harrison
  2008-05-29 23:34 ` Stefan Richter
  0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-05-29 20:18 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Stefan Richter, linux-arch

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
 drivers/firewire/fw-card.c   |    2 +-
 drivers/firewire/fw-device.c |    2 +-
 drivers/firewire/fw-ohci.c   |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/firewire/fw-card.c b/drivers/firewire/fw-card.c
index 5b4c0d9..2947db5 100644
--- a/drivers/firewire/fw-card.c
+++ b/drivers/firewire/fw-card.c
@@ -204,7 +204,7 @@ complete_bm_lock(struct fw_card *card, int rcode,
 	struct bm_data *bmd = data;
 
 	if (rcode == RCODE_COMPLETE)
-		bmd->old = be32_to_cpu(*(__be32 *) payload);
+		bmd->old = get_be32((__be32 *)payload);
 	bmd->rcode = rcode;
 	complete(&bmd->done);
 }
diff --git a/drivers/firewire/fw-device.c b/drivers/firewire/fw-device.c
index d9c8daf..4072658 100644
--- a/drivers/firewire/fw-device.c
+++ b/drivers/firewire/fw-device.c
@@ -394,7 +394,7 @@ complete_transaction(struct fw_card *card, int rcode,
 	struct read_quadlet_callback_data *callback_data = data;
 
 	if (rcode == RCODE_COMPLETE)
-		callback_data->data = be32_to_cpu(*(__be32 *)payload);
+		callback_data->data = get_be32((__be32 *)payload);
 	callback_data->rcode = rcode;
 	complete(&callback_data->done);
 }
diff --git a/drivers/firewire/fw-ohci.c b/drivers/firewire/fw-ohci.c
index 4f02c55..ee5c87f 100644
--- a/drivers/firewire/fw-ohci.c
+++ b/drivers/firewire/fw-ohci.c
@@ -1781,7 +1781,7 @@ static int handle_ir_dualbuffer_packet(struct context *context,
 		memcpy(ctx->header + i + 4, p + 8, ctx->base.header_size - 4);
 		i += ctx->base.header_size;
 		ctx->excess_bytes +=
-			(le32_to_cpu(*(__le32 *)(p + 4)) >> 16) & 0xffff;
+			(get_le32((__le32 *)(p + 4)) >> 16) & 0xffff;
 		p += ctx->base.header_size + 4;
 	}
 	ctx->header_length = i;
-- 
1.5.6.rc0.277.g804cf

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 09/37] firewire: use get/put_endian helpers
  2008-05-29 20:18 [PATCH 09/37] firewire: use get/put_endian helpers Harvey Harrison
@ 2008-05-29 23:34 ` Stefan Richter
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Richter @ 2008-05-29 23:34 UTC (permalink / raw)
  To: Harvey Harrison; +Cc: Andrew Morton, linux-arch

Harvey,

a minor side note:  A pointer to your patch which adds the helpers would 
have saved me 10 minutes of my life.  I wasn't up to speed where this 
API is available.

I.e. please add "requires patch $FOOBAR" below the --- delimiter when 
you post dependent and depending patch to different addresses.
-- 
Stefan Richter
-=====-==--- -=-= ====-
http://arcgraph.de/sr/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-05-29 23:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-29 20:18 [PATCH 09/37] firewire: use get/put_endian helpers Harvey Harrison
2008-05-29 23:34 ` Stefan Richter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox