From: Harvey Harrison <harvey.harrison@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-arch <linux-arch@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
John Linville <linville@tuxdriver.com>
Subject: Re: [PATCH 15/37] wireless: use get/put_endian helpers
Date: Thu, 29 May 2008 14:35:45 -0700 [thread overview]
Message-ID: <1212096945.28403.141.camel@brick> (raw)
In-Reply-To: <1212096681.10109.0.camel@johannes.berg>
On Thu, 2008-05-29 at 23:31 +0200, Johannes Berg wrote:
> > - ADM8211_CSR_WRITE(BSSID0, le32_to_cpu(*(__le32 *)bssid));
> > + ADM8211_CSR_WRITE(BSSID0, get_le32((__le32 *)bssid));
>
> Maybe I'm stupid, but isn't this the same as le32_to_cpup? Or does
> get_le32 handle unaligned values?
>
> johannes
You're not stupid, but there is a new put_le32 as well that takes
aligned values similar to the put_unaligned_le32, so get_le32 was
added to have an analog to get_unaligned_le32 as well.
Harvey
next prev parent reply other threads:[~2008-05-29 21:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 20:18 [PATCH 15/37] wireless: use get/put_endian helpers Harvey Harrison
2008-05-29 21:31 ` Johannes Berg
2008-05-29 21:35 ` Harvey Harrison [this message]
2008-05-29 21:43 ` Johannes Berg
2008-05-29 21:47 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212096945.28403.141.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=johannes@sipsolutions.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox