From mboxrd@z Thu Jan  1 00:00:00 1970
From: Harvey Harrison <harvey.harrison@gmail.com>
Subject: Re: [PATCH 15/37] wireless: use get/put_endian helpers
Date: Thu, 29 May 2008 14:35:45 -0700
Message-ID: <1212096945.28403.141.camel@brick>
References: <1212092308.28403.117.camel@brick>
	 (sfid-20080529_221900_617991_210BEC75)  <1212096681.10109.0.camel@johannes.berg>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <linux-arch-owner@vger.kernel.org>
Received: from yx-out-2324.google.com ([74.125.44.30]:4940 "EHLO
	yx-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754366AbYE2Vfu (ORCPT
	<rfc822;linux-arch@vger.kernel.org>); Thu, 29 May 2008 17:35:50 -0400
Received: by yx-out-2324.google.com with SMTP id 31so406983yxl.1
        for <linux-arch@vger.kernel.org>; Thu, 29 May 2008 14:35:48 -0700 (PDT)
In-Reply-To: <1212096681.10109.0.camel@johannes.berg>
Sender: linux-arch-owner@vger.kernel.org
List-ID: <linux-arch.vger.kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-arch <linux-arch@vger.kernel.org>, linux-wireless <linux-wireless@vger.kernel.org>, John Linville <linville@tuxdriver.com>

On Thu, 2008-05-29 at 23:31 +0200, Johannes Berg wrote:
> > -	ADM8211_CSR_WRITE(BSSID0, le32_to_cpu(*(__le32 *)bssid));
> > +	ADM8211_CSR_WRITE(BSSID0, get_le32((__le32 *)bssid));
> 
> Maybe I'm stupid, but isn't this the same as le32_to_cpup? Or does
> get_le32 handle unaligned values?
> 
> johannes

You're not stupid, but there is a new put_le32 as well that takes
aligned values similar to the put_unaligned_le32, so get_le32 was
added to have an analog to get_unaligned_le32 as well.

Harvey