Re: [PATCH 15/37] wireless: use get/put_endian helpers

[Harvey Harrison <harvey.harrison@gmail.com>]

On Thu, 2008-05-29 at 23:43 +0200, Johannes Berg wrote:
> On Thu, 2008-05-29 at 14:35 -0700, Harvey Harrison wrote:
> > On Thu, 2008-05-29 at 23:31 +0200, Johannes Berg wrote:
> > > > -	ADM8211_CSR_WRITE(BSSID0, le32_to_cpu(*(__le32 *)bssid));
> > > > +	ADM8211_CSR_WRITE(BSSID0, get_le32((__le32 *)bssid));
> > > 
> > > Maybe I'm stupid, but isn't this the same as le32_to_cpup? Or does
> > > get_le32 handle unaligned values?
> 
> > You're not stupid, but there is a new put_le32 as well that takes
> > aligned values similar to the put_unaligned_le32, so get_le32 was
> > added to have an analog to get_unaligned_le32 as well.
> 
> So this is just to make the API "complete"? Are we removing le32_to_cpup
> and the associated API then?
> 
> johannes

At the end of the series, there are no more users of the
{endian}_to_cpup family left, so they could be removed, but I
did not include that in this set.

It seems as if infiniband and some areas of net/ were the only places
that knew of the p version as there were lots of le16_to_cpu(*(__le16 *)ptr)
around the tree.

Harvey