From: Harvey Harrison <harvey.harrison@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mark Lord <liml@rtr.ca>, linux-arch <linux-arch@vger.kernel.org>,
Jeff Garzik <jeff@garzik.org>,
linux-ide <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 05/37] ata: use get/put_endian helpers
Date: Thu, 29 May 2008 20:37:40 -0700 [thread overview]
Message-ID: <1212118661.28403.175.camel@brick> (raw)
In-Reply-To: <20080529195225.5665ae9c.akpm@linux-foundation.org>
On Thu, 2008-05-29 at 19:52 -0700, Andrew Morton wrote:
> On Thu, 29 May 2008 22:26:18 -0400 Mark Lord <liml@rtr.ca> wrote:
>
> otoh,
>
> - I think the args are backwards
>
It was made to look like put_unaligned_* and put_unaligned()
I think of it as put_le16(source, dest)
> - I don't like the use of the put_*() namespace. It makes it look
> like a uaccess operation.
I'm flexible...although I'd probably get nailed to a cross for changing
it again so soon. (the unaligned versions, that is)
Harvey
next prev parent reply other threads:[~2008-05-30 3:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 20:18 [PATCH 05/37] ata: use get/put_endian helpers Harvey Harrison
2008-05-29 20:18 ` Harvey Harrison
2008-05-30 2:26 ` Mark Lord
2008-05-30 2:52 ` Andrew Morton
2008-05-30 3:37 ` Harvey Harrison [this message]
2008-05-30 4:08 ` Andrew Morton
2008-05-30 4:08 ` Andrew Morton
2008-05-30 4:14 ` Harvey Harrison
2008-05-30 4:10 ` Paul Mackerras
2008-05-30 4:10 ` Paul Mackerras
2008-05-30 4:18 ` Harvey Harrison
2008-05-30 4:18 ` Harvey Harrison
2008-05-30 5:04 ` Andrew Morton
2008-05-30 5:04 ` Andrew Morton
2008-05-30 13:15 ` Mark Lord
2008-05-30 13:15 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212118661.28403.175.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=liml@rtr.ca \
--cc=linux-arch@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox