From: Harvey Harrison <harvey.harrison@gmail.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCHv4 3/6] byteorder: add get/put endian helpers for the aligned case
Date: Fri, 30 May 2008 12:09:46 -0700 [thread overview]
Message-ID: <1212174586.28403.204.camel@brick> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0805301452270.18142-100000@netrider.rowland.org>
On Fri, 2008-05-30 at 15:05 -0400, Alan Stern wrote:
> On Thu, 29 May 2008, Harvey Harrison wrote:
>
> > Add a set of endian helpers for the pattern:
> > *(__le16 *)ptr = cpu_to_le16(val);
> >
> > put_le16(val, (__le16 *)ptr);
> >
> > The argument order follows that of the get/put_unaligned_{endian}
> > helpers.
> >
> > The get_ helpers are exactly equivalent to the existing {endian}_to_cpup
> > functions, but have been added anyway for symmetry in the apis.
> >
> > Myrinet had a put_be32 helper that has been changed to myri_put_be32 to
> > avoid namespace collisions.
> >
> > Private helpers in the usb-gadget drivers have been removed and switched
> > over to the common ones. Note that the put helpers here had the args in
> > the opposite order from the common version.
>
Sorry about that, it completely went out of my head that the usb-helper
was ok for unaligned access...I do know better.
I'll send a patch that move the unaligned ones over to the unaligned
access api and the aligned cases to be32_to_cpup and resend shortly.
Harvey
prev parent reply other threads:[~2008-05-30 19:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 19:56 [PATCHv4 3/6] byteorder: add get/put endian helpers for the aligned case Harvey Harrison
2008-05-30 19:05 ` Alan Stern
2008-05-30 19:09 ` Harvey Harrison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212174586.28403.204.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox