From: Harvey Harrison <harvey.harrison@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-arch <linux-arch@vger.kernel.org>,
Russell King <rmk@arm.linux.org.uk>,
"tony.luck" <tony.luck@intel.com>
Subject: Re: [PATCHv4 6/6] byteorder: add copy_{endian} helpers
Date: Wed, 04 Jun 2008 12:39:45 -0700 [thread overview]
Message-ID: <1212608385.6340.32.camel@brick> (raw)
In-Reply-To: <Pine.LNX.4.64.0806042133510.32459@anakin>
On Wed, 2008-06-04 at 21:34 +0200, Geert Uytterhoeven wrote:
> On Wed, 4 Jun 2008, Harvey Harrison wrote:
> > On Mon, 2008-06-02 at 21:15 +0200, Geert Uytterhoeven wrote:
> > > On Mon, 2 Jun 2008, Harvey Harrison wrote:
> Sounds still a bit strange to me...
>
> As `get' and `put' have connotations of reference counts, what about
> `load' and `store', e.g. `load_le32()' and `store_be16()'?
>
Well, load is covered by le16_to_cpup and friends.
I could live with store_le16 though. I had originally added get_le16,
put_le16 to match up with the get_unaligned_le16, put_unaligned_le16
functions. Maybe these would have been better as load_unaligned_*
store_unaligned_* and during this change we could fix the argument
order to be (ptr, val) allowing a gradual changeover without a flag
day.
Andrew? What do you think of load/store?
Harvey
next prev parent reply other threads:[~2008-06-04 19:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-02 17:37 [PATCHv4 6/6] byteorder: add copy_{endian} helpers Harvey Harrison
2008-06-02 19:15 ` Geert Uytterhoeven
2008-06-04 18:38 ` Harvey Harrison
2008-06-04 19:34 ` Geert Uytterhoeven
2008-06-04 19:39 ` Harvey Harrison [this message]
2008-06-04 23:20 ` Russell King
2008-06-04 23:27 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212608385.6340.32.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-arch@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox