From: Harvey Harrison <harvey.harrison@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-arch <linux-arch@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] byteorder: fix direct byteswap includes
Date: Fri, 04 Jul 2008 09:37:53 -0700 [thread overview]
Message-ID: <1215189473.16647.80.camel@brick> (raw)
In-Reply-To: <27042.1215185863@redhat.com>
On Fri, 2008-07-04 at 16:37 +0100, David Howells wrote:
> Harvey Harrison <harvey.harrison@gmail.com> wrote:
>
> > +#include <asm/byteorder.h>
>
> Please use <linux/byteorder.h> rather than <asm/byteorder.h> when including
> stuff from .c files outside the include and arch directories.
asm/byteorder.h is the file included everywhere else, and before my
patches, linux/byteorder.h didn't even exist. Thus, when preparing my
patches I made sure that including asm/byteorder.h continued to be the
way to get this functionality.
I could add another patch on top that makes linux/byteorder the one we
want included and search/replace the existing asm includes, but I thought
that was a bit too big to do in one go.
If people think this is the way to go, I'll prepare a patch to change the
includes.
> And whilst you're at it, Documentation/byteorder.txt is yours for the
> creation:-)
Already working on an update to unaligned_access.txt, I'll get to
byteorder next.
Harvey
prev parent reply other threads:[~2008-07-04 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-04 4:12 [PATCH 4/5] byteorder: fix direct byteswap includes Harvey Harrison
2008-07-04 15:37 ` David Howells
2008-07-04 16:37 ` Harvey Harrison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215189473.16647.80.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).