linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: schwidefsky@de.ibm.com
Cc: linux-arch@vger.kernel.org,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Paul Mackerras <paulus@samba.org>,
	Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
	Tony Luck <tony.luck@intel.com>,
	Jeremy Fitzhardinge <jeremy@xensource.com>,
	Chris Wright <chrisw@sous-sol.org>,
	Michael Neuling <mikey@neuling.org>
Subject: Re: [patch 0/4] [RFC] true vs. system idle cputime
Date: Thu, 16 Oct 2008 07:56:30 +1100	[thread overview]
Message-ID: <1224104190.8157.473.camel@pasglop> (raw)
In-Reply-To: <1224079316.16990.28.camel@localhost>

On Wed, 2008-10-15 at 16:01 +0200, Martin Schwidefsky wrote:
> > There is one change in patch #2 that might require a change on powerpc
> > and/or ia64. The generic TICK_ONESHOT/NO_HZ code calculates the number
> > of ticks spent with a disabled HZ timer and accounts this as idle time.
> > For a configuration for VIRT_CPU_ACCOUNTING=y this is horribly wrong.
> > Either you have precise accounting or you don't. Patch #2 just removes
> > the calculation for VIRT_CPU_ACCOUNTING=y. The architectures which support
> > precise accounting have to deal with it on their own. This is where the
> > powerpc and ia64 maintainer come into play. Would you look at patch #2
> > please ?
> > 
> > To make it clearer what happens in tick_nohz_restart_sched_tick I've added
> > a new function account_idle_ticks(). And for good measure another one named
> > account_steal_ticks() for xen where "interesting" things have been done
> > with the account_steal_time interface.
> 
> Any news about powerpc? Do these patches break anything or does it work?

I didn't have a chance to look at it yet. I'll try to get that looked at
today.

Cheers,
Ben.

      reply	other threads:[~2008-10-15 20:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-08 16:19 [patch 0/4] [RFC] true vs. system idle cputime Martin Schwidefsky
2008-10-08 16:19 ` [patch 1/4] fix scaled & unscaled cputime accounting Martin Schwidefsky
2008-10-16  4:31   ` Paul Mackerras
2008-10-08 16:20 ` [patch 2/4] idle " Martin Schwidefsky
2008-10-16  4:59   ` Paul Mackerras
2008-10-16  6:42     ` Martin Schwidefsky
2008-10-16  9:08       ` Martin Schwidefsky
2008-10-08 16:20 ` [patch 3/4] improve precision of idle accounting Martin Schwidefsky
2008-10-08 16:20 ` [patch 4/4] improve idle cputime accounting Martin Schwidefsky
2008-10-08 21:22 ` [patch 0/4] [RFC] true vs. system idle cputime Luck, Tony
2008-10-09  8:03   ` Martin Schwidefsky
2008-10-15 14:01 ` Martin Schwidefsky
2008-10-15 20:56   ` Benjamin Herrenschmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1224104190.8157.473.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=chrisw@sous-sol.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jeremy@xensource.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=mikey@neuling.org \
    --cc=paulus@samba.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).