From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linux-arch@vger.kernel.org,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Tony Luck <tony.luck@intel.com>,
Jeremy Fitzhardinge <jeremy@xensource.com>,
Chris Wright <chrisw@sous-sol.org>,
Michael Neuling <mikey@neuling.org>
Subject: Re: [patch 2/4] idle cputime accounting
Date: Thu, 16 Oct 2008 11:08:28 +0200 [thread overview]
Message-ID: <1224148108.9617.5.camel@localhost> (raw)
In-Reply-To: <1224139369.6228.8.camel@localhost>
On Thu, 2008-10-16 at 08:42 +0200, Martin Schwidefsky wrote:
> > Finally, with this patch I get the following compilation error on
> > powerpc:
> >
> > arch/powerpc/kernel/process.c: In function '__switch_to':
> > arch/powerpc/kernel/process.c:400: error: implicit declaration of
> function 'account_process_tick'
> > make[2]: *** [arch/powerpc/kernel/process.o] Error 1
> > make[1]: *** [arch/powerpc/kernel] Error 2
>
> This is with CONFIG_VIRT_CPU_ACCOUNTING=y?
Ok, the include for kernel_stat.h has been missing in
arch/powerpc/kernel/process.c. All the other call sites already have the
include.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2008-10-16 9:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 16:19 [patch 0/4] [RFC] true vs. system idle cputime Martin Schwidefsky
2008-10-08 16:19 ` [patch 1/4] fix scaled & unscaled cputime accounting Martin Schwidefsky
2008-10-16 4:31 ` Paul Mackerras
2008-10-08 16:20 ` [patch 2/4] idle " Martin Schwidefsky
2008-10-16 4:59 ` Paul Mackerras
2008-10-16 6:42 ` Martin Schwidefsky
2008-10-16 9:08 ` Martin Schwidefsky [this message]
2008-10-08 16:20 ` [patch 3/4] improve precision of idle accounting Martin Schwidefsky
2008-10-08 16:20 ` [patch 4/4] improve idle cputime accounting Martin Schwidefsky
2008-10-08 21:22 ` [patch 0/4] [RFC] true vs. system idle cputime Luck, Tony
2008-10-09 8:03 ` Martin Schwidefsky
2008-10-15 14:01 ` Martin Schwidefsky
2008-10-15 20:56 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224148108.9617.5.camel@localhost \
--to=schwidefsky@de.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=chrisw@sous-sol.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jeremy@xensource.com \
--cc=linux-arch@vger.kernel.org \
--cc=mikey@neuling.org \
--cc=paulus@samba.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).